Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] flot: add fillbetween plugin.
@ 2013-02-13 15:25 Arnaud Rébillout
  2013-03-10 22:13 ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Arnaud Rébillout @ 2013-02-13 15:25 UTC (permalink / raw)
  To: buildroot

Flot plugin for computing bottoms for filled line and bar charts.

Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
---
 package/flot/Config.in |    5 +++++
 package/flot/flot.mk   |    1 +
 2 files changed, 6 insertions(+)

diff --git a/package/flot/Config.in b/package/flot/Config.in
index 60534c1..0124b2d 100644
--- a/package/flot/Config.in
+++ b/package/flot/Config.in
@@ -20,6 +20,11 @@ if BR2_PACKAGE_FLOT
 
 comment "flot plugins"
 
+config BR2_PACKAGE_FLOT_FILLBETWEEN
+	bool "fillbetween"
+	help
+	  Flot plugin for computing bottoms for filled line and bar charts. 
+
 config BR2_PACKAGE_FLOT_NAVIGATE
 	bool "navigate"
 	help
diff --git a/package/flot/flot.mk b/package/flot/flot.mk
index f4ba604..41f5a42 100644
--- a/package/flot/flot.mk
+++ b/package/flot/flot.mk
@@ -1,6 +1,7 @@
 FLOT_VERSION = 0.7
 FLOT_SITE = http://flot.googlecode.com/files
 FLOT_FILES = jquery.flot $(addprefix jquery.flot.,\
+	$(if $(BR2_PACKAGE_FLOT_FILLBETWEEN),fillbetween) \
 	$(if $(BR2_PACKAGE_FLOT_NAVIGATE),navigate) \
 	$(if $(BR2_PACKAGE_FLOT_PIE),pie) \
 	$(if $(BR2_PACKAGE_FLOT_RESIZE),resize) \
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] flot: add fillbetween plugin.
  2013-02-13 15:25 [Buildroot] [PATCH] flot: add fillbetween plugin Arnaud Rébillout
@ 2013-03-10 22:13 ` Peter Korsgaard
  2013-03-11  9:51   ` Arnaud Rébillout
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2013-03-10 22:13 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnaud" == Arnaud R?billout <rebillout@syscom.ch> writes:

 Arnaud> Flot plugin for computing bottoms for filled line and bar charts.
 Arnaud> Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
 Arnaud> ---
 Arnaud>  package/flot/Config.in |    5 +++++
 Arnaud>  package/flot/flot.mk   |    1 +
 Arnaud>  2 files changed, 6 insertions(+)

 Arnaud> diff --git a/package/flot/Config.in b/package/flot/Config.in
 Arnaud> index 60534c1..0124b2d 100644
 Arnaud> --- a/package/flot/Config.in
 Arnaud> +++ b/package/flot/Config.in
 Arnaud> @@ -20,6 +20,11 @@ if BR2_PACKAGE_FLOT
 
 Arnaud>  comment "flot plugins"
 
 Arnaud> +config BR2_PACKAGE_FLOT_FILLBETWEEN
 Arnaud> +	bool "fillbetween"
 Arnaud> +	help
 Arnaud> +	  Flot plugin for computing bottoms for filled line and bar charts. 

You have a trailing space here in the help text.

Otherwise it looks good, committed - Thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] flot: add fillbetween plugin.
  2013-03-10 22:13 ` Peter Korsgaard
@ 2013-03-11  9:51   ` Arnaud Rébillout
  2013-03-11 10:01     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Arnaud Rébillout @ 2013-03-11  9:51 UTC (permalink / raw)
  To: buildroot

You have sharp eyes !

Thanks for committing,

Regards,
Arnaud

On 03/10/2013 11:13 PM, Peter Korsgaard wrote:
>>>>>> "Arnaud" == Arnaud R?billout<rebillout@syscom.ch>  writes:
>   Arnaud>  Flot plugin for computing bottoms for filled line and bar charts.
>   Arnaud>  Signed-off-by: Arnaud R?billout<rebillout@syscom.ch>
>   Arnaud>  ---
>   Arnaud>   package/flot/Config.in |    5 +++++
>   Arnaud>   package/flot/flot.mk   |    1 +
>   Arnaud>   2 files changed, 6 insertions(+)
>
>   Arnaud>  diff --git a/package/flot/Config.in b/package/flot/Config.in
>   Arnaud>  index 60534c1..0124b2d 100644
>   Arnaud>  --- a/package/flot/Config.in
>   Arnaud>  +++ b/package/flot/Config.in
>   Arnaud>  @@ -20,6 +20,11 @@ if BR2_PACKAGE_FLOT
>
>   Arnaud>   comment "flot plugins"
>
>   Arnaud>  +config BR2_PACKAGE_FLOT_FILLBETWEEN
>   Arnaud>  +	bool "fillbetween"
>   Arnaud>  +	help
>   Arnaud>  +	  Flot plugin for computing bottoms for filled line and bar charts.
>
> You have a trailing space here in the help text.
>
> Otherwise it looks good, committed - Thanks.
>


-- 
Arnaud R?billout
SYSCOM Instruments SA
rue de l'industrie 21
CH-1450 Sainte-Croix
Switzerland
Tel: +41 (0)24 455 44 11

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] flot: add fillbetween plugin.
  2013-03-11  9:51   ` Arnaud Rébillout
@ 2013-03-11 10:01     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-03-11 10:01 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnaud" == Arnaud R?billout <rebillout@syscom.ch> writes:

 Arnaud> You have sharp eyes !

It helps that my editor highlights trailing spaces ;)

 Arnaud> Thanks for committing,

You're welcome. Thanks for constributing to buildroot.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-03-11 10:01 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-13 15:25 [Buildroot] [PATCH] flot: add fillbetween plugin Arnaud Rébillout
2013-03-10 22:13 ` Peter Korsgaard
2013-03-11  9:51   ` Arnaud Rébillout
2013-03-11 10:01     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox