Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] 2013.02: sysvinit-2.88 build failure undefined reference to -lcrypt
@ 2013-03-12  9:37 Roland Uuesoo
  2013-03-13  0:04 ` Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Roland Uuesoo @ 2013-03-12  9:37 UTC (permalink / raw)
  To: buildroot

Hi.

Sysvinit doesn't build on the following system:

Buildroot: 2013.02
OS: Ubuntu 12.10 x64

The problem looks very similar to this....
http://buildroot-busybox.2317881.n4.nabble.com/Bug-2401-New-sysvinit-2-86-fails-to-build-on-MIPS-because-is-missing-lcrypt-td6901.html

Compile output is basically the same as the link above:
sulogin.c:(.text+0xf94): undefined reference to `crypt'

As I understand the problem is this...

sysvinit's makefile can't find libcrypt.a and doesn't add -lcrypt to
sulogin.c linker options.

On 64bit ubuntu the libcrypt.a is located at
/usr/lib/x86_64-linux-gnu/libcrypt.a

Best regards,
Roland Uuesoo
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130312/3a36e8f5/attachment-0001.html>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] 2013.02: sysvinit-2.88 build failure undefined reference to -lcrypt
  2013-03-12  9:37 [Buildroot] 2013.02: sysvinit-2.88 build failure undefined reference to -lcrypt Roland Uuesoo
@ 2013-03-13  0:04 ` Arnout Vandecappelle
  2013-03-13  0:05   ` [Buildroot] [PATCH] sysvinit: fix linking of sulogin with -lcrypt Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-03-13  0:04 UTC (permalink / raw)
  To: buildroot

On 03/12/13 10:37, Roland Uuesoo wrote:
>
> Sysvinit doesn't build on the following system:
>
> Buildroot: 2013.02
> OS: Ubuntu 12.10 x64
>
> The problem looks very similar to this....
> http://buildroot-busybox.2317881.n4.nabble.com/Bug-2401-New-sysvinit-2-86-fails-to-build-on-MIPS-because-is-missing-lcrypt-td6901.html
>
>
> Compile output is basically the same as the link above:
> sulogin.c:(.text+0xf94): undefined reference to `crypt'
>
> As I understand the problem is this...
>
> sysvinit's makefile can't find libcrypt.a and doesn't add -lcrypt to
> sulogin.c linker options.
>
> On 64bit ubuntu the libcrypt.a is located at
> /usr/lib/x86_64-linux-gnu/libcrypt.a

  Wow, it looks like this one has been lingering around ever since 
7e2bf630 in December 2010...

  It looks like the LCRYPT variable is no longer working. I'll cook up a 
patch, but can't really test it since the included makefile works for me.

  If my patch works, please reply to it with

Tested-by: Roland Uuesoo <rolandu@gmail.com>


  Regards,
  Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] sysvinit: fix linking of sulogin with -lcrypt
  2013-03-13  0:04 ` Arnout Vandecappelle
@ 2013-03-13  0:05   ` Arnout Vandecappelle
  2013-04-14 21:22     ` Peter Korsgaard
  0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2013-03-13  0:05 UTC (permalink / raw)
  To: buildroot

From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>

The LCRYPT variable is no longer used; use SULOGINLIBS instead.

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 package/sysvinit/sysvinit.mk |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/sysvinit/sysvinit.mk b/package/sysvinit/sysvinit.mk
index 10feb96..606c33e 100644
--- a/package/sysvinit/sysvinit.mk
+++ b/package/sysvinit/sysvinit.mk
@@ -24,7 +24,7 @@ SYSVINIT_POST_PATCH_HOOKS = SYSVINIT_DEBIAN_PATCHES
 define SYSVINIT_BUILD_CMDS
 	# Force sysvinit to link against libcrypt as it otherwise
 	# use an incorrect test to see if it's available
-	$(MAKE) $(TARGET_CONFIGURE_OPTS) LCRYPT="-lcrypt" -C $(@D)/src
+	$(MAKE) $(TARGET_CONFIGURE_OPTS) SULOGINLIBS="-lcrypt" -C $(@D)/src
 endef
 
 define SYSVINIT_INSTALL_TARGET_CMDS
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH] sysvinit: fix linking of sulogin with -lcrypt
  2013-03-13  0:05   ` [Buildroot] [PATCH] sysvinit: fix linking of sulogin with -lcrypt Arnout Vandecappelle
@ 2013-04-14 21:22     ` Peter Korsgaard
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-04-14 21:22 UTC (permalink / raw)
  To: buildroot

>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:

 Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
 Arnout> The LCRYPT variable is no longer used; use SULOGINLIBS instead.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-04-14 21:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-12  9:37 [Buildroot] 2013.02: sysvinit-2.88 build failure undefined reference to -lcrypt Roland Uuesoo
2013-03-13  0:04 ` Arnout Vandecappelle
2013-03-13  0:05   ` [Buildroot] [PATCH] sysvinit: fix linking of sulogin with -lcrypt Arnout Vandecappelle
2013-04-14 21:22     ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox