From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3 of 3] oprofile 0.9.8: fix compilation on powerpc
Date: Wed, 13 Mar 2013 21:18:17 +0100 [thread overview]
Message-ID: <5140DF09.3030705@mind.be> (raw)
In-Reply-To: <CAAXf6LXsr5Jw4=q8M=oZRbaiLnOzokt_svb2dmiKqvw1oGzwHw@mail.gmail.com>
On 03/13/13 17:14, Thomas De Schampheleire wrote:
> Hi Reuben,
>
> On Tue, Mar 12, 2013 at 9:20 PM, Reuben Dowle <reuben.dowle@4rf.com> wrote:
[snip]
>>> -OPROFILE_DEPENDENCIES = popt binutils
>>> +OPROFILE_DEPENDENCIES = popt binutils libpfm4
>>
>> I think this dependency is only needed for powerpc. So something like:
>>
>> OPROFILE_DEPENDENCIES = popt binutils
>> ifeq ($(BR2_powerpc),y)
>> OPROFILE_DEPENDENCIES += libpfm4
>> Endif
>>
>> Might be better?
>
> As far as I understand, these dependencies are only used for
> build-time ordering. This means that libfm4, *if selected in the
> config* will be built before oprofile.
Nope. If libpfm4 is a dependency, it will be built even if you haven't
configured it. So libpfm4 will be built unnecessarily.
Regards,
Arnout
> However, if libpfm4 is not
> selected, and you're not on powerpc, you can still build oprofile.
> The only benefit from the suggested code above, I think, is that on
> non-powerpc targets the unnecessary ordering of oprofile / libpfm4 is
> not enforced, but I think this will hardly give an impact on build
> time.
>
> Best regards,
> Thomas
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-03-13 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-12 18:10 [Buildroot] [PATCH 0 of 3] Fix oprofile build on powerpc Thomas De Schampheleire
2013-03-12 18:10 ` [Buildroot] [PATCH 1 of 3] libpfm4: new package Thomas De Schampheleire
2013-03-18 21:16 ` Peter Korsgaard
2013-03-12 18:10 ` [Buildroot] [PATCH 2 of 3] oprofile: upstep 0.9.7 patches to 0.9.8 Thomas De Schampheleire
2013-03-13 7:24 ` Thomas Petazzoni
2013-03-13 8:27 ` Thomas De Schampheleire
2013-03-13 20:12 ` Arnout Vandecappelle
2013-03-14 7:49 ` Thomas Petazzoni
2013-03-18 21:20 ` Peter Korsgaard
2013-03-12 18:10 ` [Buildroot] [PATCH 3 of 3] oprofile 0.9.8: fix compilation on powerpc Thomas De Schampheleire
2013-03-12 20:20 ` Reuben Dowle
2013-03-13 16:14 ` Thomas De Schampheleire
2013-03-13 20:18 ` Arnout Vandecappelle [this message]
2013-03-13 7:28 ` [Buildroot] [PATCH 0 of 3] Fix oprofile build " Thomas Petazzoni
2013-03-13 8:38 ` Thomas De Schampheleire
2013-03-15 10:15 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140DF09.3030705@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox