* [Buildroot] [PATCH v2 1/1] python-thrift: new package @ 2013-03-13 14:43 Vinicius Tinti 2013-03-13 20:35 ` Arnout Vandecappelle 0 siblings, 1 reply; 9+ messages in thread From: Vinicius Tinti @ 2013-03-13 14:43 UTC (permalink / raw) To: buildroot Add Python bindings for the Apache Thrift RPC. Thrift is an interface definition language that is used to define and create services for numerous languages using remote procedure calls (RPC). This patch does not include the Thrift code generator. It only includes the Thrift libraries used at runtime. Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> --- package/Config.in | 1 + package/python-thrift/Config.in | 7 +++++++ package/python-thrift/python-thrift.mk | 23 +++++++++++++++++++++++ 3 files changed, 31 insertions(+) create mode 100644 package/python-thrift/Config.in create mode 100644 package/python-thrift/python-thrift.mk diff --git a/package/Config.in b/package/Config.in index a65054c..8467735 100644 --- a/package/Config.in +++ b/package/Config.in @@ -334,6 +334,7 @@ source "package/python-pygame/Config.in" source "package/python-pyparsing/Config.in" source "package/python-serial/Config.in" source "package/python-setuptools/Config.in" +source "package/python-thrift/Config.in" endmenu endif source "package/ruby/Config.in" diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in new file mode 100644 index 0000000..f4ad4ba --- /dev/null +++ b/package/python-thrift/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_PYTHON_THRIFT + bool "python-thrift" + help + python-thrift is a Python bindings for the Apache Thrift RPC system. + + http://thrift.apache.org/ + diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk new file mode 100644 index 0000000..40ae57b --- /dev/null +++ b/package/python-thrift/python-thrift.mk @@ -0,0 +1,23 @@ +############################################################# +# +# python-thrift +# +############################################################# + +PYTHON_THRIFT_VERSION = 0.9.0 +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ +PYTHON_THRIFT_LICENSE = Apache v2.0 +PYTHON_THRIFT_LICENSE_FILES = README + +PYTHON_THRIFT_DEPENDENCIES = python + +define PYTHON_THRIFT_BUILD_CMDS + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build) +endef + +define PYTHON_THRIFT_INSTALL_TARGET_CMDS + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) +endef + +$(eval $(generic-package)) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-thrift: new package 2013-03-13 14:43 [Buildroot] [PATCH v2 1/1] python-thrift: new package Vinicius Tinti @ 2013-03-13 20:35 ` Arnout Vandecappelle 2013-03-14 16:15 ` Tinti 0 siblings, 1 reply; 9+ messages in thread From: Arnout Vandecappelle @ 2013-03-13 20:35 UTC (permalink / raw) To: buildroot On 03/13/13 15:43, Vinicius Tinti wrote: > Add Python bindings for the Apache Thrift RPC. > > Thrift is an interface definition language that is used to define and create > services for numerous languages using remote procedure calls (RPC). > > This patch does not include the Thrift code generator. It only includes the > Thrift libraries used at runtime. > > Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> > Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> When you post a v2 of a patch, it is nice if you can add a changelog below your signed-off-by line (separated by ---). > --- > package/Config.in | 1 + > package/python-thrift/Config.in | 7 +++++++ > package/python-thrift/python-thrift.mk | 23 +++++++++++++++++++++++ > 3 files changed, 31 insertions(+) > create mode 100644 package/python-thrift/Config.in > create mode 100644 package/python-thrift/python-thrift.mk > > diff --git a/package/Config.in b/package/Config.in > index a65054c..8467735 100644 > --- a/package/Config.in > +++ b/package/Config.in > @@ -334,6 +334,7 @@ source "package/python-pygame/Config.in" > source "package/python-pyparsing/Config.in" > source "package/python-serial/Config.in" > source "package/python-setuptools/Config.in" > +source "package/python-thrift/Config.in" > endmenu > endif > source "package/ruby/Config.in" > diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in > new file mode 100644 > index 0000000..f4ad4ba > --- /dev/null > +++ b/package/python-thrift/Config.in > @@ -0,0 +1,7 @@ > +config BR2_PACKAGE_PYTHON_THRIFT > + bool "python-thrift" > + help > + python-thrift is a Python bindings for the Apache Thrift RPC system. > + > + http://thrift.apache.org/ > + Redundant empty line at end of file. > diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk > new file mode 100644 > index 0000000..40ae57b > --- /dev/null > +++ b/package/python-thrift/python-thrift.mk > @@ -0,0 +1,23 @@ > +############################################################# > +# > +# python-thrift > +# > +############################################################# > + > +PYTHON_THRIFT_VERSION = 0.9.0 > +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz This is the default, so can be removed. > +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ > +PYTHON_THRIFT_LICENSE = Apache v2.0 We currently have Apache-v2 (ImageMagick), Apache-2.0 (lua-msgpack) and Apache v2.0 (zxing). I personally prefer Apache-2.0. > +PYTHON_THRIFT_LICENSE_FILES = README > + > +PYTHON_THRIFT_DEPENDENCIES = python > + > +define PYTHON_THRIFT_BUILD_CMDS > + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build) > +endef > + > +define PYTHON_THRIFT_INSTALL_TARGET_CMDS > + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) > +endef Unfortunately, installation fails when host-python-distutilscross has been installed already (by python-protobuf or python-netifaces). ------ running install Checking .pth file support in $(TARGET_DIR)/usr/lib/python2.7/site-packages/ $(HOST_DIR)/usr/bin/python -E -c pass TEST FAILED: $(TARGET_DIR)/usr/lib/python2.7/site-packages/ does NOT support .pth files error: bad install directory or PYTHONPATH You are attempting to install a package to a directory that is not on PYTHONPATH and which Python does not read ".pth" files from. The installation directory you specified (via --install-dir, --prefix, or the distutils default setting) was: $(TARGET_DIR)/usr/lib/python2.7/site-packages/ ------ What happens is very clear: we're installing using the host-python, which doesn't look at TARGET_DIR to load packages. I would expect that distutilscross knows how to deal with that, but haven't found how... Regards, Arnout > + > +$(eval $(generic-package)) > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-thrift: new package 2013-03-13 20:35 ` Arnout Vandecappelle @ 2013-03-14 16:15 ` Tinti 2013-03-14 21:47 ` [Buildroot] [PATCH v3 " Vinicius Tinti 2013-03-15 12:33 ` [Buildroot] [PATCH v2 " Arnout Vandecappelle 0 siblings, 2 replies; 9+ messages in thread From: Tinti @ 2013-03-14 16:15 UTC (permalink / raw) To: buildroot On Wed, Mar 13, 2013 at 5:35 PM, Arnout Vandecappelle <arnout@mind.be>wrote: > On 03/13/13 15:43, Vinicius Tinti wrote: > >> Add Python bindings for the Apache Thrift RPC. >> >> Thrift is an interface definition language that is used to define and >> create >> services for numerous languages using remote procedure calls (RPC). >> >> This patch does not include the Thrift code generator. It only includes >> the >> Thrift libraries used at runtime. >> >> Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> >> Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> >> > > When you post a v2 of a patch, it is nice if you can add a changelog > below your signed-off-by line (separated by ---). > Got it. > > --- >> package/Config.in | 1 + >> package/python-thrift/Config.**in | 7 +++++++ >> package/python-thrift/python-**thrift.mk <http://python-thrift.mk> | >> 23 +++++++++++++++++++++++ >> 3 files changed, 31 insertions(+) >> create mode 100644 package/python-thrift/Config.**in >> create mode 100644 package/python-thrift/python-**thrift.mk<http://python-thrift.mk> >> >> diff --git a/package/Config.in b/package/Config.in >> index a65054c..8467735 100644 >> --- a/package/Config.in >> +++ b/package/Config.in >> @@ -334,6 +334,7 @@ source "package/python-pygame/Config.**in" >> source "package/python-pyparsing/**Config.in" >> source "package/python-serial/Config.**in" >> source "package/python-setuptools/**Config.in" >> +source "package/python-thrift/Config.**in" >> endmenu >> endif >> source "package/ruby/Config.in" >> diff --git a/package/python-thrift/**Config.in b/package/python-thrift/** >> Config.in >> new file mode 100644 >> index 0000000..f4ad4ba >> --- /dev/null >> +++ b/package/python-thrift/**Config.in >> @@ -0,0 +1,7 @@ >> +config BR2_PACKAGE_PYTHON_THRIFT >> + bool "python-thrift" >> + help >> + python-thrift is a Python bindings for the Apache Thrift RPC >> system. >> + >> + http://thrift.apache.org/ >> + >> > > Redundant empty line at end of file. > > Ok. I will remove. Note that there are other python modules that are with this (i.e. python-serial). > diff --git a/package/python-thrift/python**-thrift.mk<http://python-thrift.mk>b/package/python-thrift/ >> python**-thrift.mk <http://python-thrift.mk> >> new file mode 100644 >> index 0000000..40ae57b >> --- /dev/null >> +++ b/package/python-thrift/python**-thrift.mk <http://python-thrift.mk> >> @@ -0,0 +1,23 @@ >> +#############################**##############################**## >> +# >> +# python-thrift >> +# >> +#############################**##############################**## >> + >> +PYTHON_THRIFT_VERSION = 0.9.0 >> +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_**VERSION).tar.gz >> > > This is the default, so can be removed. > > Can I keep it? I think it makes more clear. > +PYTHON_THRIFT_SITE = https://pypi.python.org/**packages/source/t/thrift/<https://pypi.python.org/packages/source/t/thrift/> >> +PYTHON_THRIFT_LICENSE = Apache v2.0 >> > > We currently have Apache-v2 (ImageMagick), Apache-2.0 (lua-msgpack) and > Apache v2.0 (zxing). I personally prefer Apache-2.0. > > Changed to Apache-2.0. > > +PYTHON_THRIFT_LICENSE_FILES = README >> + >> +PYTHON_THRIFT_DEPENDENCIES = python >> + >> +define PYTHON_THRIFT_BUILD_CMDS >> + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build) >> +endef >> + >> +define PYTHON_THRIFT_INSTALL_TARGET_**CMDS >> + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install >> --prefix=$(TARGET_DIR)/usr) >> +endef >> > > Unfortunately, installation fails when host-python-distutilscross has > been installed already (by python-protobuf or python-netifaces). > > ------ > running install > Checking .pth file support in $(TARGET_DIR)/usr/lib/python2.** > 7/site-packages/ > $(HOST_DIR)/usr/bin/python -E -c pass > TEST FAILED: $(TARGET_DIR)/usr/lib/python2.**7/site-packages/ does NOT > support .pth files > error: bad install directory or PYTHONPATH > > You are attempting to install a package to a directory that is not > on PYTHONPATH and which Python does not read ".pth" files from. The > installation directory you specified (via --install-dir, --prefix, or > the distutils default setting) was: > > $(TARGET_DIR)/usr/lib/python2.**7/site-packages/ > ------ > > What happens is very clear: we're installing using the host-python, which > doesn't look at TARGET_DIR to load packages. I would expect that > distutilscross knows how to deal with that, but haven't found how... > > I have used the code from python-netifaces. It builds without generating an error at least. Do you think it is ok? +define PYTHON_THRIFT_BUILD_CMDS + (cd $(@D); \ + PYTHONXCPREFIX="$(STAGING_DIR)/usr/" \ + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ + $(HOST_DIR)/usr/bin/python setup.py build -x) +endef + +define PYTHON_THRIFT_INSTALL_TARGET_CMDS + (cd $(@D); PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages \ + $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) +endef > Regards, > Arnout > > + >> +$(eval $(generic-package)) >> >> > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/**arnoutvandecappelle<http://www.linkedin.com/in/arnoutvandecappelle> > GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F > Best regards, Tinti -- Simplicity is the ultimate sophistication -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130314/eb562bb0/attachment.html> ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v3 1/1] python-thrift: new package 2013-03-14 16:15 ` Tinti @ 2013-03-14 21:47 ` Vinicius Tinti 2013-03-18 6:57 ` Arnout Vandecappelle 2013-03-15 12:33 ` [Buildroot] [PATCH v2 " Arnout Vandecappelle 1 sibling, 1 reply; 9+ messages in thread From: Vinicius Tinti @ 2013-03-14 21:47 UTC (permalink / raw) To: buildroot Add Python bindings for the Apache Thrift RPC. Thrift is an interface definition language that is used to define and create services for numerous languages using remote procedure calls (RPC). This patch does not include the Thrift code generator. It only includes the Thrift libraries used at runtime. Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> --- Changes since v2: 1. Remove empty line in Config.in 2. Change to Apache-2.0 3. Solve python-thrift, python-protobuf and python-netifaces conflict --- package/Config.in | 1 + package/python-thrift/Config.in | 7 +++++++ package/python-thrift/python-thrift.mk | 27 +++++++++++++++++++++++++++ 3 files changed, 35 insertions(+) create mode 100644 package/python-thrift/Config.in create mode 100644 package/python-thrift/python-thrift.mk diff --git a/package/Config.in b/package/Config.in index b8b1e60..fc50465 100644 --- a/package/Config.in +++ b/package/Config.in @@ -334,6 +334,7 @@ source "package/python-pygame/Config.in" source "package/python-pyparsing/Config.in" source "package/python-serial/Config.in" source "package/python-setuptools/Config.in" +source "package/python-thrift/Config.in" endmenu endif source "package/ruby/Config.in" diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in new file mode 100644 index 0000000..94a7590 --- /dev/null +++ b/package/python-thrift/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_PYTHON_THRIFT + bool "python-thrift" + depends on BR2_PACKAGE_PYTHON + help + python-thrift is a Python bindings for the Apache Thrift RPC system. + + http://thrift.apache.org/ diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk new file mode 100644 index 0000000..5d9831e --- /dev/null +++ b/package/python-thrift/python-thrift.mk @@ -0,0 +1,27 @@ +############################################################# +# +# python-thrift +# +############################################################# + +PYTHON_THRIFT_VERSION = 0.9.0 +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ +PYTHON_THRIFT_LICENSE = Apache-2.0 +PYTHON_THRIFT_LICENSE_FILES = README + +PYTHON_THRIFT_DEPENDENCIES = python + +define PYTHON_THRIFT_BUILD_CMDS + (cd $(@D); \ + PYTHONXCPREFIX="$(STAGING_DIR)/usr/" \ + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ + $(HOST_DIR)/usr/bin/python setup.py build) +endef + +define PYTHON_THRIFT_INSTALL_TARGET_CMDS + (cd $(@D); PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages \ + $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) +endef + +$(eval $(generic-package)) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v3 1/1] python-thrift: new package 2013-03-14 21:47 ` [Buildroot] [PATCH v3 " Vinicius Tinti @ 2013-03-18 6:57 ` Arnout Vandecappelle 2013-03-21 9:59 ` [Buildroot] [PATCH v4 " Vinicius Tinti 0 siblings, 1 reply; 9+ messages in thread From: Arnout Vandecappelle @ 2013-03-18 6:57 UTC (permalink / raw) To: buildroot On 03/14/13 22:47, Vinicius Tinti wrote: > Add Python bindings for the Apache Thrift RPC. > > Thrift is an interface definition language that is used to define and create > services for numerous languages using remote procedure calls (RPC). > > This patch does not include the Thrift code generator. It only includes the > Thrift libraries used at runtime. > > Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> > Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Still some remarks below, up to Peter to decide if they need to be fixed before committing. [snip] > diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk > new file mode 100644 > index 0000000..5d9831e > --- /dev/null > +++ b/package/python-thrift/python-thrift.mk > @@ -0,0 +1,27 @@ > +############################################################# > +# > +# python-thrift > +# > +############################################################# > + > +PYTHON_THRIFT_VERSION = 0.9.0 > +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz Redundant. > +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ Should be http rather than https, and the final / is redundant. > +PYTHON_THRIFT_LICENSE = Apache-2.0 > +PYTHON_THRIFT_LICENSE_FILES = README > + > +PYTHON_THRIFT_DEPENDENCIES = python > + > +define PYTHON_THRIFT_BUILD_CMDS > + (cd $(@D); \ > + PYTHONXCPREFIX="$(STAGING_DIR)/usr/" \ > + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ > + $(HOST_DIR)/usr/bin/python setup.py build) This should be indented one tab more. > +endef > + Missing comment: # host-distutilscross, if it has been installed before, will check that # the installation directory is in python's load path. For host-python, # it is not, so add it explicitly while installing to target. > +define PYTHON_THRIFT_INSTALL_TARGET_CMDS > + (cd $(@D); PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages \ > + $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) > +endef > + > +$(eval $(generic-package)) > Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v4 1/1] python-thrift: new package 2013-03-18 6:57 ` Arnout Vandecappelle @ 2013-03-21 9:59 ` Vinicius Tinti 2013-05-06 22:38 ` Peter Korsgaard 0 siblings, 1 reply; 9+ messages in thread From: Vinicius Tinti @ 2013-03-21 9:59 UTC (permalink / raw) To: buildroot Add Python bindings for the Apache Thrift RPC. Thrift is an interface definition language that is used to define and create services for numerous languages using remote procedure calls (RPC). This patch does not include the Thrift code generator. It only includes the Thrift libraries used at runtime. Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> --- Changes since v2: 1. Remove empty line in Config.in 2. Change to Apache-2.0 3. Solve python-thrift, python-protobuf and python-netifaces conflict Changes since v3: 1. Add workaround comment. Suggested by Arnout 2. Fix extra / and https in package URL 3. Change indentation 4. Acked by Arnout 5. Tested by Arnout --- --- package/Config.in | 1 + package/python-thrift/Config.in | 7 +++++++ package/python-thrift/python-thrift.mk | 30 ++++++++++++++++++++++++++++++ 3 files changed, 38 insertions(+) create mode 100644 package/python-thrift/Config.in create mode 100644 package/python-thrift/python-thrift.mk diff --git a/package/Config.in b/package/Config.in index 94e279b..69ab06e 100644 --- a/package/Config.in +++ b/package/Config.in @@ -332,6 +332,7 @@ source "package/python-pygame/Config.in" source "package/python-pyparsing/Config.in" source "package/python-serial/Config.in" source "package/python-setuptools/Config.in" +source "package/python-thrift/Config.in" endmenu endif source "package/ruby/Config.in" diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in new file mode 100644 index 0000000..94a7590 --- /dev/null +++ b/package/python-thrift/Config.in @@ -0,0 +1,7 @@ +config BR2_PACKAGE_PYTHON_THRIFT + bool "python-thrift" + depends on BR2_PACKAGE_PYTHON + help + python-thrift is a Python bindings for the Apache Thrift RPC system. + + http://thrift.apache.org/ diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk new file mode 100644 index 0000000..c2fc752 --- /dev/null +++ b/package/python-thrift/python-thrift.mk @@ -0,0 +1,30 @@ +############################################################# +# +# python-thrift +# +############################################################# + +PYTHON_THRIFT_VERSION = 0.9.0 +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz +PYTHON_THRIFT_SITE = http://pypi.python.org/packages/source/t/thrift +PYTHON_THRIFT_LICENSE = Apache-2.0 +PYTHON_THRIFT_LICENSE_FILES = README + +PYTHON_THRIFT_DEPENDENCIES = python + +define PYTHON_THRIFT_BUILD_CMDS + (cd $(@D); \ + PYTHONXCPREFIX="$(STAGING_DIR)/usr/" \ + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ + $(HOST_DIR)/usr/bin/python setup.py build) +endef + +# host-distutilscross, if it has been installed before, will check that +# the installation directory is in python's load path. For host-python, +# it is not, so add it explicitly while installing to target. +define PYTHON_THRIFT_INSTALL_TARGET_CMDS + (cd $(@D); PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages \ + $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) +endef + +$(eval $(generic-package)) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v4 1/1] python-thrift: new package 2013-03-21 9:59 ` [Buildroot] [PATCH v4 " Vinicius Tinti @ 2013-05-06 22:38 ` Peter Korsgaard 0 siblings, 0 replies; 9+ messages in thread From: Peter Korsgaard @ 2013-05-06 22:38 UTC (permalink / raw) To: buildroot On Thu, Mar 21, 2013 at 10:59 AM, Vinicius Tinti <viniciustinti@gmail.com> wrote: > Add Python bindings for the Apache Thrift RPC. > > Thrift is an interface definition language that is used to define and create > services for numerous languages using remote procedure calls (RPC). > > This patch does not include the Thrift code generator. It only includes the > Thrift libraries used at runtime. > > Signed-off-by: Tiago Maluta <tiagomaluta@gmail.com> > Signed-off-by: Vinicius Tinti <viniciustinti@gmail.com> > Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Committed, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-thrift: new package 2013-03-14 16:15 ` Tinti 2013-03-14 21:47 ` [Buildroot] [PATCH v3 " Vinicius Tinti @ 2013-03-15 12:33 ` Arnout Vandecappelle 2013-03-18 2:53 ` Tinti 1 sibling, 1 reply; 9+ messages in thread From: Arnout Vandecappelle @ 2013-03-15 12:33 UTC (permalink / raw) To: buildroot On 03/14/13 17:15, Tinti wrote: > On Wed, Mar 13, 2013 at 5:35 PM, Arnout Vandecappelle <arnout@mind.be > <mailto:arnout@mind.be>> wrote: > > On 03/13/13 15:43, Vinicius Tinti wrote: [snip] > b/package/python-thrift/python__-thrift.mk <http://python-thrift.mk> > new file mode 100644 > index 0000000..40ae57b > --- /dev/null > +++ b/package/python-thrift/python__-thrift.mk > <http://python-thrift.mk> > @@ -0,0 +1,23 @@ > +#############################__##############################__## > +# > +# python-thrift > +# > +#############################__##############################__## > + > +PYTHON_THRIFT_VERSION = 0.9.0 > +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz > > > This is the default, so can be removed. > > > Can I keep it? I think it makes more clear. Although I agree, the rule in buildroot is that it is removed when it is the default. So no, you cannot keep it. > > +PYTHON_THRIFT_SITE = > https://pypi.python.org/__packages/source/t/thrift/ > <https://pypi.python.org/packages/source/t/thrift/> > +PYTHON_THRIFT_LICENSE = Apache v2.0 > > > We currently have Apache-v2 (ImageMagick), Apache-2.0 (lua-msgpack) > and Apache v2.0 (zxing). I personally prefer Apache-2.0. > > > Changed to Apache-2.0. Apache-2.0 is just my personal preference, so wait a bit until some others have voiced their opinion. > +PYTHON_THRIFT_LICENSE_FILES = README > + > +PYTHON_THRIFT_DEPENDENCIES = python > + > +define PYTHON_THRIFT_BUILD_CMDS > + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build) > +endef > + > +define PYTHON_THRIFT_INSTALL_TARGET___CMDS > + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install > --prefix=$(TARGET_DIR)/usr) > +endef > > > Unfortunately, installation fails when host-python-distutilscross > has been installed already (by python-protobuf or python-netifaces). > > ------ > running install > Checking .pth file support in > $(TARGET_DIR)/usr/lib/python2.__7/site-packages/ > $(HOST_DIR)/usr/bin/python -E -c pass > TEST FAILED: $(TARGET_DIR)/usr/lib/python2.__7/site-packages/ does > NOT support .pth files > error: bad install directory or PYTHONPATH > > You are attempting to install a package to a directory that is not > on PYTHONPATH and which Python does not read ".pth" files from. The > installation directory you specified (via --install-dir, --prefix, or > the distutils default setting) was: > > $(TARGET_DIR)/usr/lib/python2.__7/site-packages/ > ------ > > What happens is very clear: we're installing using the host-python, > which doesn't look at TARGET_DIR to load packages. I would expect > that distutilscross knows how to deal with that, but haven't found how... > > > > I have used the code from python-netifaces. It builds without generating > an error at least. Do you think it is ok? Strange... Can you check that if you first build host-python-distutilscross and then python-thrift, it still works for you? So: make python-distutilscross make python-thrift-dirclean make python-thrift And a sanity check: do you use current git master as a base? > > +define PYTHON_THRIFT_BUILD_CMDS > + (cd $(@D); \ > + PYTHONXCPREFIX="$(STAGING_DIR)/usr/" \ > + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ > + $(HOST_DIR)/usr/bin/python setup.py build -x) > +endef > + > +define PYTHON_THRIFT_INSTALL_TARGET_CMDS > + (cd $(@D); > PYTHONPATH=$(TARGET_DIR)/usr/lib/python$(PYTHON_VERSION_MAJOR)/site-packages > \ > + $(HOST_DIR)/usr/bin/python setup.py install > --prefix=$(TARGET_DIR)/usr) > +endef I have no problem with this workaround, even though it is a bit ugly. You should add a comment to explain why this is needed though (before the define, otherwise the comment is interrupting the backslashified region). When you send a new patch with this change, I'll test it in my environment. Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH v2 1/1] python-thrift: new package 2013-03-15 12:33 ` [Buildroot] [PATCH v2 " Arnout Vandecappelle @ 2013-03-18 2:53 ` Tinti 0 siblings, 0 replies; 9+ messages in thread From: Tinti @ 2013-03-18 2:53 UTC (permalink / raw) To: buildroot On Fri, Mar 15, 2013 at 9:33 AM, Arnout Vandecappelle <arnout@mind.be>wrote: > On 03/14/13 17:15, Tinti wrote: > >> On Wed, Mar 13, 2013 at 5:35 PM, Arnout Vandecappelle <arnout@mind.be >> <mailto:arnout@mind.be>> wrote: >> >> On 03/13/13 15:43, Vinicius Tinti wrote: >> > [snip] > >> b/package/python-thrift/python**__-thrift.mk<http://python__-thrift.mk>< >> http://python-thrift.mk> >> >> new file mode 100644 >> index 0000000..40ae57b >> --- /dev/null >> +++ b/package/python-thrift/python**__-thrift.mk<http://python__-thrift.mk> >> <http://python-thrift.mk> >> @@ -0,0 +1,23 @@ >> +#############################**__############################** >> ##__## >> +# >> +# python-thrift >> +# >> +#############################**__############################** >> ##__## >> >> + >> +PYTHON_THRIFT_VERSION = 0.9.0 >> +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_**VERSION).tar.gz >> >> >> This is the default, so can be removed. >> >> >> Can I keep it? I think it makes more clear. >> > > Although I agree, the rule in buildroot is that it is removed when it is > the default. So no, you cannot keep it. > Ok. > > >> +PYTHON_THRIFT_SITE = >> https://pypi.python.org/__**packages/source/t/thrift/<https://pypi.python.org/__packages/source/t/thrift/> >> >> <https://pypi.python.org/**packages/source/t/thrift/<https://pypi.python.org/packages/source/t/thrift/> >> > >> +PYTHON_THRIFT_LICENSE = Apache v2.0 >> >> >> We currently have Apache-v2 (ImageMagick), Apache-2.0 (lua-msgpack) >> and Apache v2.0 (zxing). I personally prefer Apache-2.0. >> >> >> Changed to Apache-2.0. >> > > Apache-2.0 is just my personal preference, so wait a bit until some > others have voiced their opinion. > > Right. > +PYTHON_THRIFT_LICENSE_FILES = README >> + >> +PYTHON_THRIFT_DEPENDENCIES = python >> + >> +define PYTHON_THRIFT_BUILD_CMDS >> + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build) >> +endef >> + >> +define PYTHON_THRIFT_INSTALL_TARGET__**_CMDS >> >> + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install >> --prefix=$(TARGET_DIR)/usr) >> +endef >> >> >> Unfortunately, installation fails when host-python-distutilscross >> has been installed already (by python-protobuf or python-netifaces). >> >> ------ >> running install >> Checking .pth file support in >> $(TARGET_DIR)/usr/lib/python2.**__7/site-packages/ >> $(HOST_DIR)/usr/bin/python -E -c pass >> TEST FAILED: $(TARGET_DIR)/usr/lib/python2.**__7/site-packages/ does >> >> NOT support .pth files >> error: bad install directory or PYTHONPATH >> >> You are attempting to install a package to a directory that is not >> on PYTHONPATH and which Python does not read ".pth" files from. The >> installation directory you specified (via --install-dir, --prefix, or >> the distutils default setting) was: >> >> $(TARGET_DIR)/usr/lib/python2.**__7/site-packages/ >> >> ------ >> >> What happens is very clear: we're installing using the host-python, >> which doesn't look at TARGET_DIR to load packages. I would expect >> that distutilscross knows how to deal with that, but haven't found >> how... >> >> >> >> I have used the code from python-netifaces. It builds without generating >> an error at least. Do you think it is ok? >> > > Strange... Can you check that if you first build > host-python-distutilscross and then python-thrift, it still works for you? > So: > > make python-distutilscross > make python-thrift-dirclean > make python-thrift > > And a sanity check: do you use current git master as a base? > > Yes, I am using git://git.buildroot.net/buildroot. But I dont have the python-distutilscross target available. I have tried even to enable all python modules. Am I doing something wrong? > >> +define PYTHON_THRIFT_BUILD_CMDS >> + (cd $(@D); \ >> + PYTHONXCPREFIX="$(STAGING_DIR)**/usr/" \ >> + LDFLAGS="-L$(STAGING_DIR)/lib -L$(STAGING_DIR)/usr/lib" \ >> + $(HOST_DIR)/usr/bin/python setup.py build -x) >> +endef >> + >> +define PYTHON_THRIFT_INSTALL_TARGET_**CMDS >> + (cd $(@D); >> PYTHONPATH=$(TARGET_DIR)/usr/**lib/python$(PYTHON_VERSION_** >> MAJOR)/site-packages >> \ >> + $(HOST_DIR)/usr/bin/python setup.py install >> --prefix=$(TARGET_DIR)/usr) >> +endef >> > > > I have no problem with this workaround, even though it is a bit ugly. You > should add a comment to explain why this is needed though (before the > define, otherwise the comment is interrupting the backslashified region). > > I have simply copy how python-protocolbuf and python-netifaces are doing the installation. But the truth is that I don't really know why it must be done this way. By the code we can see that it uses an intermediate directory. Do you think that /* Avoid directory conflicts by using an intermediate install directory. Needed to work with python-protocolbuf and python-netifaces. */ is enough? > When you send a new patch with this change, I'll test it in my > environment. > > > Regards, > Arnout > > -- > Arnout Vandecappelle arnout at mind be > Senior Embedded Software Architect +32-16-286500 > Essensium/Mind http://www.mind.be > G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven > LinkedIn profile: http://www.linkedin.com/in/**arnoutvandecappelle<http://www.linkedin.com/in/arnoutvandecappelle> > GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F > Best regards. Tinti -- Simplicity is the ultimate sophistication -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130317/53a73dbd/attachment-0001.html> ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-05-06 22:38 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-03-13 14:43 [Buildroot] [PATCH v2 1/1] python-thrift: new package Vinicius Tinti 2013-03-13 20:35 ` Arnout Vandecappelle 2013-03-14 16:15 ` Tinti 2013-03-14 21:47 ` [Buildroot] [PATCH v3 " Vinicius Tinti 2013-03-18 6:57 ` Arnout Vandecappelle 2013-03-21 9:59 ` [Buildroot] [PATCH v4 " Vinicius Tinti 2013-05-06 22:38 ` Peter Korsgaard 2013-03-15 12:33 ` [Buildroot] [PATCH v2 " Arnout Vandecappelle 2013-03-18 2:53 ` Tinti
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox