* [Buildroot] [PATCH] quota: util-linux libmount is needed to build mount
@ 2013-03-20 4:22 Gilles Talis
2013-03-20 10:14 ` Gustavo Zacarias
0 siblings, 1 reply; 3+ messages in thread
From: Gilles Talis @ 2013-03-20 4:22 UTC (permalink / raw)
To: buildroot
quota configuration explicitly selects util-linux mount package,
but mount requires libmount to build.
Explicitly select libmount to fix this.
Fixes autobuild errors like:
http://autobuild.buildroot.org/results/2d2f37c292178f746a9a397146719e94f18c022b
Signed-off-by: Gilles Talis <gilles.talis@gmail.com>
---
package/quota/Config.in | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/quota/Config.in b/package/quota/Config.in
index f6341d3..25614f8 100644
--- a/package/quota/Config.in
+++ b/package/quota/Config.in
@@ -3,8 +3,11 @@ config BR2_PACKAGE_QUOTA
depends on BR2_LARGEFILE
depends on BR2_USE_WCHAR
depends on BR2_USE_MMU # fork()
+ # libc lacks UTIME_NOW & UTIME_COMMIT for libmount
+ depends on !(BR2_microblazeel || BR2_microblazebe)
select BR2_PACKAGE_UTIL_LINUX
select BR2_PACKAGE_UTIL_LINUX_MOUNT
+ select BR2_PACKAGE_UTIL_LINUX_LIBMOUNT
select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
select BR2_PACKAGE_LIBTIRPC if !BR2_TOOLCHAIN_HAS_NATIVE_RPC
help
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] quota: util-linux libmount is needed to build mount
2013-03-20 4:22 [Buildroot] [PATCH] quota: util-linux libmount is needed to build mount Gilles Talis
@ 2013-03-20 10:14 ` Gustavo Zacarias
2013-03-20 16:16 ` Gilles Talis
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo Zacarias @ 2013-03-20 10:14 UTC (permalink / raw)
To: buildroot
On 03/20/2013 01:22 AM, Gilles Talis wrote:
> quota configuration explicitly selects util-linux mount package,
> but mount requires libmount to build.
>
> Explicitly select libmount to fix this.
But it's not the proper fix realy, see line 92 of util-linux.mk - it
won't build ANY util-linux binary unless BR2_PACKAGE_UTIL_LINUX_BINARIES
is set, hence it may pass in the autobuilders but you'll never get
util-linux mount (and quota will cry when used).
The proper fix is the one i've sent before.
Regards.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] quota: util-linux libmount is needed to build mount
2013-03-20 10:14 ` Gustavo Zacarias
@ 2013-03-20 16:16 ` Gilles Talis
0 siblings, 0 replies; 3+ messages in thread
From: Gilles Talis @ 2013-03-20 16:16 UTC (permalink / raw)
To: buildroot
Hi Gustavo,
2013/3/20 Gustavo Zacarias <gustavo@zacarias.com.ar>:
> On 03/20/2013 01:22 AM, Gilles Talis wrote:
>
>> quota configuration explicitly selects util-linux mount package,
>> but mount requires libmount to build.
>>
>> Explicitly select libmount to fix this.
>
> But it's not the proper fix realy, see line 92 of util-linux.mk - it
> won't build ANY util-linux binary unless BR2_PACKAGE_UTIL_LINUX_BINARIES
> is set, hence it may pass in the autobuilders but you'll never get
> util-linux mount (and quota will cry when used).
> The proper fix is the one i've sent before.
I simply just missed the patch you have sent earlier on this issue.
All apologies.
Thanks for pointing out.
regards
Gilles.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-20 16:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-20 4:22 [Buildroot] [PATCH] quota: util-linux libmount is needed to build mount Gilles Talis
2013-03-20 10:14 ` Gustavo Zacarias
2013-03-20 16:16 ` Gilles Talis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox