* [Buildroot] [PATCH] dosfstools: fix host variant dependencies
@ 2013-03-21 12:12 Gustavo Zacarias
2013-03-21 12:21 ` Yann E. MORIN
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Gustavo Zacarias @ 2013-03-21 12:12 UTC (permalink / raw)
To: buildroot
host-dosfstools shouldn't pull host-libiconv in since that's for
uClibc-based toolchains and we don't have that package anyway.
Fixes:
http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
package/dosfstools/dosfstools.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/dosfstools/dosfstools.mk b/package/dosfstools/dosfstools.mk
index 332f2ee..79d1c7a 100644
--- a/package/dosfstools/dosfstools.mk
+++ b/package/dosfstools/dosfstools.mk
@@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+
DOSFSTOOLS_LICENSE_FILES = COPYING
DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS)
+# Avoid target dosfstools dependencies, no host-libiconv
+HOST_DOSFSTOOLS_DEPENDENCIES =
+
ifneq ($(BR2_ENABLE_LOCALE),y)
DOSFSTOOLS_DEPENDENCIES += libiconv
DOSFSTOOLS_LDFLAGS += -liconv
--
1.8.1.5
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH] dosfstools: fix host variant dependencies
2013-03-21 12:12 [Buildroot] [PATCH] dosfstools: fix host variant dependencies Gustavo Zacarias
@ 2013-03-21 12:21 ` Yann E. MORIN
2013-03-21 12:29 ` Gustavo Zacarias
2013-03-21 23:18 ` Yann E. MORIN
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2013-03-21 12:21 UTC (permalink / raw)
To: buildroot
Gustavo, All,
On Thursday 21 March 2013 13:12:34 Gustavo Zacarias wrote:
> host-dosfstools shouldn't pull host-libiconv in since that's for
> uClibc-based toolchains and we don't have that package anyway.
> Fixes:
> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> package/dosfstools/dosfstools.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/dosfstools/dosfstools.mk b/package/dosfstools/dosfstools.mk
> index 332f2ee..79d1c7a 100644
> --- a/package/dosfstools/dosfstools.mk
> +++ b/package/dosfstools/dosfstools.mk
> @@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+
> DOSFSTOOLS_LICENSE_FILES = COPYING
> DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS)
>
> +# Avoid target dosfstools dependencies, no host-libiconv
> +HOST_DOSFSTOOLS_DEPENDENCIES =
> +
Shouldn't we also do:
HOST_DOSFSTOOLS_LDFLAGS =
> ifneq ($(BR2_ENABLE_LOCALE),y)
> DOSFSTOOLS_DEPENDENCIES += libiconv
> DOSFSTOOLS_LDFLAGS += -liconv
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread* [Buildroot] [PATCH] dosfstools: fix host variant dependencies
2013-03-21 12:21 ` Yann E. MORIN
@ 2013-03-21 12:29 ` Gustavo Zacarias
2013-03-21 12:31 ` Gustavo Zacarias
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo Zacarias @ 2013-03-21 12:29 UTC (permalink / raw)
To: buildroot
On 03/21/2013 09:21 AM, Yann E. MORIN wrote:
>> +# Avoid target dosfstools dependencies, no host-libiconv
>> +HOST_DOSFSTOOLS_DEPENDENCIES =
>> +
>
> Shouldn't we also do:
> HOST_DOSFSTOOLS_LDFLAGS =
>
>> ifneq ($(BR2_ENABLE_LOCALE),y)
>> DOSFSTOOLS_DEPENDENCIES += libiconv
>> DOSFSTOOLS_LDFLAGS += -liconv
Not really, HOST_LDFLAGS doesn't inherit.
Regards.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] dosfstools: fix host variant dependencies
2013-03-21 12:29 ` Gustavo Zacarias
@ 2013-03-21 12:31 ` Gustavo Zacarias
0 siblings, 0 replies; 7+ messages in thread
From: Gustavo Zacarias @ 2013-03-21 12:31 UTC (permalink / raw)
To: buildroot
On 03/21/2013 09:29 AM, Gustavo Zacarias wrote:
> On 03/21/2013 09:21 AM, Yann E. MORIN wrote:
>
>>> +# Avoid target dosfstools dependencies, no host-libiconv
>>> +HOST_DOSFSTOOLS_DEPENDENCIES =
>>> +
>>
>> Shouldn't we also do:
>> HOST_DOSFSTOOLS_LDFLAGS =
>>
>>> ifneq ($(BR2_ENABLE_LOCALE),y)
>>> DOSFSTOOLS_DEPENDENCIES += libiconv
>>> DOSFSTOOLS_LDFLAGS += -liconv
>
> Not really, HOST_LDFLAGS doesn't inherit.
> Regards.
And we explicitly use a clean BUILD_CMDS for the host :)
Regards.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] dosfstools: fix host variant dependencies
2013-03-21 12:12 [Buildroot] [PATCH] dosfstools: fix host variant dependencies Gustavo Zacarias
2013-03-21 12:21 ` Yann E. MORIN
@ 2013-03-21 23:18 ` Yann E. MORIN
2013-03-24 8:51 ` Thomas Petazzoni
2013-03-24 10:54 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2013-03-21 23:18 UTC (permalink / raw)
To: buildroot
Gustavo, All,
On Thursday 21 March 2013 Gustavo Zacarias wrote:
> host-dosfstools shouldn't pull host-libiconv in since that's for
> uClibc-based toolchains and we don't have that package anyway.
> Fixes:
> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Thanks for fixing my breakage! ;-)
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/dosfstools/dosfstools.mk | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/package/dosfstools/dosfstools.mk b/package/dosfstools/dosfstools.mk
> index 332f2ee..79d1c7a 100644
> --- a/package/dosfstools/dosfstools.mk
> +++ b/package/dosfstools/dosfstools.mk
> @@ -10,6 +10,9 @@ DOSFSTOOLS_LICENSE = GPLv3+
> DOSFSTOOLS_LICENSE_FILES = COPYING
> DOSFSTOOLS_LDFLAGS = $(TARGET_LDFLAGS)
>
> +# Avoid target dosfstools dependencies, no host-libiconv
> +HOST_DOSFSTOOLS_DEPENDENCIES =
> +
> ifneq ($(BR2_ENABLE_LOCALE),y)
> DOSFSTOOLS_DEPENDENCIES += libiconv
> DOSFSTOOLS_LDFLAGS += -liconv
> --
> 1.8.1.5
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] dosfstools: fix host variant dependencies
2013-03-21 12:12 [Buildroot] [PATCH] dosfstools: fix host variant dependencies Gustavo Zacarias
2013-03-21 12:21 ` Yann E. MORIN
2013-03-21 23:18 ` Yann E. MORIN
@ 2013-03-24 8:51 ` Thomas Petazzoni
2013-03-24 10:54 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2013-03-24 8:51 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Thu, 21 Mar 2013 09:12:34 -0300, Gustavo Zacarias wrote:
> host-dosfstools shouldn't pull host-libiconv in since that's for
> uClibc-based toolchains and we don't have that package anyway.
> Fixes:
> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] dosfstools: fix host variant dependencies
2013-03-21 12:12 [Buildroot] [PATCH] dosfstools: fix host variant dependencies Gustavo Zacarias
` (2 preceding siblings ...)
2013-03-24 8:51 ` Thomas Petazzoni
@ 2013-03-24 10:54 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2013-03-24 10:54 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
Gustavo> host-dosfstools shouldn't pull host-libiconv in since that's for
Gustavo> uClibc-based toolchains and we don't have that package anyway.
Gustavo> Fixes:
Gustavo> http://autobuild.buildroot.net/results/7637985bfb0afdd9217c297e9b0ac5de797c137d/
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-03-24 10:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-21 12:12 [Buildroot] [PATCH] dosfstools: fix host variant dependencies Gustavo Zacarias
2013-03-21 12:21 ` Yann E. MORIN
2013-03-21 12:29 ` Gustavo Zacarias
2013-03-21 12:31 ` Gustavo Zacarias
2013-03-21 23:18 ` Yann E. MORIN
2013-03-24 8:51 ` Thomas Petazzoni
2013-03-24 10:54 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox