[Buildroot] [PATCH 1/4] Fix typo

[Buildroot] [PATCH 1/4] Fix typo

[arved at arved.at]

From: Tilman Keskin?z <arved@arved.at>


Signed-off-by: Tilman Keskin?z <arved@arved.at>
---
 docs/manual/contribute.txt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
index 9425eff..0106df0 100644
--- a/docs/manual/contribute.txt
+++ b/docs/manual/contribute.txt
@@ -1,7 +1,7 @@
 // -*- mode:doc; -*-
 // vim: set syntax=asciidoc:
 
-Contibuting to Buildroot
+Contributing to Buildroot
 ========================
 
 If you want to contribute to Buildroot, you will need a git view of
-- 
1.7.10.4

[Buildroot] [PATCH 2/4] Support .dotfiles in / being copied to the TARGET

[arved at arved.at]

From: Tilman Keskin?z <arved@arved.at>

An example is .init_enable_core, to enable coredumps in busybox

Signed-off-by: Tilman Keskin?z <arved@arved.at>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index f1c98aa..62311ed 100644
--- a/Makefile
+++ b/Makefile
@@ -431,7 +431,7 @@ $(BUILD_DIR)/.root:
 	mkdir -p $(TARGET_DIR)
 	if ! [ -d "$(TARGET_DIR)/bin" ]; then \
 		if [ -d "$(TARGET_SKELETON)" ]; then \
-			cp -fa $(TARGET_SKELETON)/* $(TARGET_DIR)/; \
+			rsync -au $(TARGET_SKELETON)/ $(TARGET_DIR)/; \
 		fi; \
 	fi
 	cp support/misc/target-dir-warning.txt $(TARGET_DIR_WARNING_FILE)
-- 
1.7.10.4

[Buildroot] [PATCH 2/4] Support .dotfiles in / being copied to the TARGET

[Peter Korsgaard]

>>>>> "arved" == arved  <arved@arved.at> writes:

 arved> From: Tilman Keskin?z <arved@arved.at>
 arved> An example is .init_enable_core, to enable coredumps in busybox
 arved> Signed-off-by: Tilman Keskin?z <arved@arved.at>
 arved> ---
 arved>  Makefile |    2 +-
 arved>  1 file changed, 1 insertion(+), 1 deletion(-)

 arved> diff --git a/Makefile b/Makefile
 arved> index f1c98aa..62311ed 100644
 arved> --- a/Makefile
 arved> +++ b/Makefile
 arved> @@ -431,7 +431,7 @@ $(BUILD_DIR)/.root:
 arved>  	mkdir -p $(TARGET_DIR)
 arved>  	if ! [ -d "$(TARGET_DIR)/bin" ]; then \
 arved>  		if [ -d "$(TARGET_SKELETON)" ]; then \
 arved> -			cp -fa $(TARGET_SKELETON)/* $(TARGET_DIR)/; \
 arved> +			rsync -au $(TARGET_SKELETON)/ $(TARGET_DIR)/; \

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 3/4] Fix path to pidfile

[arved at arved.at]

From: Tilman Keskin?z <arved@arved.at>


Signed-off-by: Tilman Keskin?z <arved@arved.at>
---
 package/busybox/S01logging |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/busybox/S01logging b/package/busybox/S01logging
index edece39..37a2c11 100644
--- a/package/busybox/S01logging
+++ b/package/busybox/S01logging
@@ -6,13 +6,13 @@
 case "$1" in
   start)
 	echo -n "Starting logging: "
-	start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0
+	start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0
 	start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd
 	echo "OK"
 	;;
   stop)
 	echo -n "Stopping logging: "
-	start-stop-daemon -K -q -p /var/run/syslog.pid
+	start-stop-daemon -K -q -p /var/run/syslogd.pid
 	start-stop-daemon -K -q -p /var/run/klogd.pid
 	echo "OK"
 	;;
-- 
1.7.10.4

[Buildroot] [PATCH 3/4] Fix path to pidfile

[Arnout Vandecappelle]

On 25/03/13 15:48, arved at arved.at wrote:
> From: Tilman Keskin?z <arved@arved.at>
>
>
> Signed-off-by: Tilman Keskin?z <arved@arved.at>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

(untested)

  Regards,
  Arnout

> ---
>   package/busybox/S01logging |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/busybox/S01logging b/package/busybox/S01logging
> index edece39..37a2c11 100644
> --- a/package/busybox/S01logging
> +++ b/package/busybox/S01logging
> @@ -6,13 +6,13 @@
>   case "$1" in
>     start)
>   	echo -n "Starting logging: "
> -	start-stop-daemon -S -q -p /var/run/syslog.pid --exec /sbin/syslogd -- -m 0
> +	start-stop-daemon -S -q -p /var/run/syslogd.pid --exec /sbin/syslogd -- -m 0
>   	start-stop-daemon -S -q -p /var/run/klogd.pid --exec /sbin/klogd
>   	echo "OK"
>   	;;
>     stop)
>   	echo -n "Stopping logging: "
> -	start-stop-daemon -K -q -p /var/run/syslog.pid
> +	start-stop-daemon -K -q -p /var/run/syslogd.pid
>   	start-stop-daemon -K -q -p /var/run/klogd.pid
>   	echo "OK"
>   	;;
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 3/4] Fix path to pidfile

[Peter Korsgaard]

>>>>> "arved" == arved  <arved@arved.at> writes:

 arved> From: Tilman Keskin?z <arved@arved.at>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 4/4] Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

[arved at arved.at]

From: Tilman Keskin?z <arved@arved.at>


Signed-off-by: Tilman Keskin?z <arved@arved.at>
---
 package/busybox/busybox-1.20.x.config |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/busybox/busybox-1.20.x.config b/package/busybox/busybox-1.20.x.config
index 5525434..d199996 100644
--- a/package/busybox/busybox-1.20.x.config
+++ b/package/busybox/busybox-1.20.x.config
@@ -41,7 +41,7 @@ CONFIG_FEATURE_DEVPTS=y
 CONFIG_FEATURE_CLEAN_UP=y
 CONFIG_FEATURE_UTMP=y
 CONFIG_FEATURE_WTMP=y
-# CONFIG_FEATURE_PIDFILE is not set
+CONFIG_FEATURE_PIDFILE=y
 CONFIG_FEATURE_SUID=y
 # CONFIG_FEATURE_SUID_CONFIG is not set
 # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set
-- 
1.7.10.4

[Buildroot] [PATCH 4/4] Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

[Arnout Vandecappelle]

  Hi Tilman,


On 25/03/13 15:48, arved at arved.at wrote:
> From: Tilman Keskin?z <arved@arved.at>
>
>
> Signed-off-by: Tilman Keskin?z <arved@arved.at>
> ---
>   package/busybox/busybox-1.20.x.config |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/busybox/busybox-1.20.x.config b/package/busybox/busybox-1.20.x.config
> index 5525434..d199996 100644
> --- a/package/busybox/busybox-1.20.x.config
> +++ b/package/busybox/busybox-1.20.x.config
> @@ -41,7 +41,7 @@ CONFIG_FEATURE_DEVPTS=y
>   CONFIG_FEATURE_CLEAN_UP=y
>   CONFIG_FEATURE_UTMP=y
>   CONFIG_FEATURE_WTMP=y
> -# CONFIG_FEATURE_PIDFILE is not set
> +CONFIG_FEATURE_PIDFILE=y

  Since we care very much about the size of busybox, could you evaluate 
what the size difference is before and after this change?  One smallish 
architecture (e.g. ARM) is enough.

  Could you also make this change to the other busybox versions as well? 
The different busybox configs should only differ because of features 
added/removed in that particular version.


  Regards,
  Arnout

>   CONFIG_FEATURE_SUID=y
>   # CONFIG_FEATURE_SUID_CONFIG is not set
>   # CONFIG_FEATURE_SUID_CONFIG_QUIET is not set
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 4/4] Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

[Tilman Keskinöz]

Hi Arnout,

* Arnout Vandecappelle [Thu, 28 Mar 2013 08:12:38 +0100]:
>> -# CONFIG_FEATURE_PIDFILE is not set
>> +CONFIG_FEATURE_PIDFILE=y
> 
>  Since we care very much about the size of busybox, could you evaluate
> what the size difference is before and after this change?  One smallish
> architecture (e.g. ARM) is enough.
> 
>  Could you also make this change to the other busybox versions as well?
> The different busybox configs should only differ because of features
> added/removed in that particular version.

On ARM the difference is 64 Bytes. (gcc 4.6.x)

If you don't want to enable this feature, another option would be to use
start-stop-daemon -p in the syslog init script.

What do you think?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130328/2b2c60b7/attachment.asc>

[Buildroot] [PATCH 4/4] Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

[Arnout Vandecappelle]

On 28/03/13 15:59, Tilman Keskin?z wrote:
> Hi Arnout,
>
> * Arnout Vandecappelle [Thu, 28 Mar 2013 08:12:38 +0100]:
>>> -# CONFIG_FEATURE_PIDFILE is not set
>>> +CONFIG_FEATURE_PIDFILE=y
>>
>>   Since we care very much about the size of busybox, could you evaluate
>> what the size difference is before and after this change?  One smallish
>> architecture (e.g. ARM) is enough.
>>
>>   Could you also make this change to the other busybox versions as well?
>> The different busybox configs should only differ because of features
>> added/removed in that particular version.
>
> On ARM the difference is 64 Bytes. (gcc 4.6.x)

  Great, then it is a good idea to enable it by default. Can you do it 
for all busybox versions?

  Question to the list: do we really need to keep several busybox 
versions? For U-Boot or kernel it may make some kind of sense, because 
you have custom patches on top of a specific version. But for busybox?


> If you don't want to enable this feature, another option would be to use
> start-stop-daemon -p in the syslog init script.

  It is already using the -p option, no?

  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH 4/4] Enable feature CONFIG_FEATURE_PIDFILE so that the syslog initscript actually works

[Tilman Keskinöz]

* Arnout Vandecappelle [Thu, 28 Mar 2013 16:27:06 +0100]:
>> If you don't want to enable this feature, another option would be to use
>> start-stop-daemon -p in the syslog init script.
> 
>  It is already using the -p option, no?

Sorry, i meant -m, e.g. let start-stop-daemon handle the pidfile creation.



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130328/12366c96/attachment.asc>

[Buildroot] [PATCH 1/4] Fix typo

[Peter Korsgaard]

>>>>> "arved" == arved  <arved@arved.at> writes:

 arved> From: Tilman Keskin?z <arved@arved.at>
 arved> Signed-off-by: Tilman Keskin?z <arved@arved.at>

Committed, thanks.

-- 
Bye, Peter Korsgaard