From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] post-build: reimplement using a for loop and make verbose
Date: Sun, 07 Apr 2013 15:58:00 +0200 [thread overview]
Message-ID: <51617B68.9030706@lucaceresoli.net> (raw)
In-Reply-To: <20130403103226.36c1e0be@skate>
Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Wed, 3 Apr 2013 10:28:48 +0200, Luca Ceresoli wrote:
>> Make the post-build system similar to the rootfs overlay system. This allows to
>> show each script filename before execution.
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> I don't have a strong opinion on whether this is useful or not, but if
> it gets applied, I'd like the same to be done for post-image scripts,
> in order to keep the consistency.
To me it is useful each time multiple post-build scripts are used,
because is
makes it easy to understand what's happening and which scripts you are
running
(and which you are not running).
E.g., I have multiple products with a common base, plus some "optional"
features.
Some features needs a specific post-build script. Each product
implements a subset
of the features, but these subsets overlap between different products.
When a build a product's rootfs it is useful to see if I am running all
and only
the correct post-build scripts: the "common base" script, plus the
scripts for the
wanted features.
Of course I agree this change should be done also in the post-image scripts.
I will submit a patchset that does also this.
Luca
next prev parent reply other threads:[~2013-04-07 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 8:28 [Buildroot] [PATCH] post-build: reimplement using a for loop and make verbose Luca Ceresoli
2013-04-03 8:32 ` Thomas Petazzoni
2013-04-07 13:58 ` Luca Ceresoli [this message]
2013-04-04 1:35 ` Danomi Manchego
2013-04-08 16:47 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51617B68.9030706@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox