From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] post-build: reimplement using a for loop and make verbose
Date: Mon, 08 Apr 2013 18:47:50 +0200 [thread overview]
Message-ID: <5162F4B6.7070107@lucaceresoli.net> (raw)
In-Reply-To: <CANxTyt5nMrA3a7qq3sCmavGmnydBS_h3bCXufGqa8aFE+7xXyg@mail.gmail.com>
Danomi Manchego wrote:
> Alternatively, you could just move the MESSAGE into the loop instead
> of relying on shell loops. That would keep things more in make, if
> that's desired.
>
> @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_BUILD_SCRIPT)), \
> $(call MESSAGE,"Executing $(s)"); \
> $(s) $(TARGET_DIR)$(sep))
It is actually cleanerand should also be more efficient(FWIW).
Sending a v2 patchset with this implementation.
Luca
prev parent reply other threads:[~2013-04-08 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 8:28 [Buildroot] [PATCH] post-build: reimplement using a for loop and make verbose Luca Ceresoli
2013-04-03 8:32 ` Thomas Petazzoni
2013-04-07 13:58 ` Luca Ceresoli
2013-04-04 1:35 ` Danomi Manchego
2013-04-08 16:47 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5162F4B6.7070107@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox