Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] busybox: don't disable static option
@ 2013-04-15  9:09 Patrick Ziegler
  2013-04-17  6:07 ` Arnout Vandecappelle
  2013-04-17 19:51 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Patrick Ziegler @ 2013-04-15  9:09 UTC (permalink / raw)
  To: buildroot

Don't change the busybox STATIC option if buildroots PREFER_STATIC_LIB option
is not set. Not to prefer static linking doesn't imply prefer dynamic linking
for all packages.

Signed-off-by: Patrick Ziegler <patrick.ziegler@fh-kl.de>
---
 package/busybox/busybox.mk |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
index 900896f..985203c 100644
--- a/package/busybox/busybox.mk
+++ b/package/busybox/busybox.mk
@@ -106,10 +106,6 @@ ifeq ($(BR2_PREFER_STATIC_LIB),y)
 define BUSYBOX_PREFER_STATIC
 	$(call KCONFIG_ENABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
 endef
-else
-define BUSYBOX_PREFER_STATIC
-	$(call KCONFIG_DISABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
-endef
 endif
 
 # Disable usage of inetd if netkit-base package is selected
-- 
1.7.10.4



-- 
Dipl.-Inf. (FH) Patrick Ziegler

University Of Applied Sciences
Kaiserslautern

Amerikastrasse 1
D-66482 Zweibruecken
Germany

Phone:  +49 631 3724 5526
Mail:   patrick.ziegler at fh-kl.de
PGP KeyID 0xB4796B8C

http://www.fh-kl.de
http://www.fh-kl.de/fachbereiche/imst/iuk-knowhow.html

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] busybox: don't disable static option
  2013-04-15  9:09 [Buildroot] [PATCH] busybox: don't disable static option Patrick Ziegler
@ 2013-04-17  6:07 ` Arnout Vandecappelle
  2013-04-17 19:51 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2013-04-17  6:07 UTC (permalink / raw)
  To: buildroot

On 15/04/13 11:09, Patrick Ziegler wrote:
> Don't change the busybox STATIC option if buildroots PREFER_STATIC_LIB option
> is not set. Not to prefer static linking doesn't imply prefer dynamic linking
> for all packages.
>
> Signed-off-by: Patrick Ziegler <patrick.ziegler@fh-kl.de>

Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

> ---
>   package/busybox/busybox.mk |    4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/package/busybox/busybox.mk b/package/busybox/busybox.mk
> index 900896f..985203c 100644
> --- a/package/busybox/busybox.mk
> +++ b/package/busybox/busybox.mk
> @@ -106,10 +106,6 @@ ifeq ($(BR2_PREFER_STATIC_LIB),y)
>   define BUSYBOX_PREFER_STATIC
>   	$(call KCONFIG_ENABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
>   endef
> -else
> -define BUSYBOX_PREFER_STATIC
> -	$(call KCONFIG_DISABLE_OPT,CONFIG_STATIC,$(BUSYBOX_BUILD_CONFIG))
> -endef
>   endif
>
>   # Disable usage of inetd if netkit-base package is selected
>


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] busybox: don't disable static option
  2013-04-15  9:09 [Buildroot] [PATCH] busybox: don't disable static option Patrick Ziegler
  2013-04-17  6:07 ` Arnout Vandecappelle
@ 2013-04-17 19:51 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-04-17 19:51 UTC (permalink / raw)
  To: buildroot

>>>>> "Patrick" == Patrick Ziegler <patrick.ziegler@fh-kl.de> writes:

 Patrick> Don't change the busybox STATIC option if buildroots
 Patrick> PREFER_STATIC_LIB option is not set. Not to prefer static
 Patrick> linking doesn't imply prefer dynamic linking for all packages.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-04-17 19:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-15  9:09 [Buildroot] [PATCH] busybox: don't disable static option Patrick Ziegler
2013-04-17  6:07 ` Arnout Vandecappelle
2013-04-17 19:51 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox