* [Buildroot] [PATCH 1/2] glibmm: new package
@ 2013-04-23 14:09 nmenegale
2013-04-23 14:09 ` [Buildroot] [PATCH 2/2] libxml++: " nmenegale
2013-04-23 14:20 ` [Buildroot] [PATCH 1/2] glibmm: " Gustavo Zacarias
0 siblings, 2 replies; 9+ messages in thread
From: nmenegale @ 2013-04-23 14:09 UTC (permalink / raw)
To: buildroot
Signed-off-by: Nicolas M?n?gale <nicolas.menegale@openwide.fr>
---
v0: initial commit
glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
---
package/Config.in | 1 +
package/glibmm/Config.in | 8 ++++++++
package/glibmm/glibmm.mk | 13 +++++++++++++
3 files changed, 22 insertions(+)
create mode 100644 package/glibmm/Config.in
create mode 100644 package/glibmm/glibmm.mk
diff --git a/package/Config.in b/package/Config.in
index 06bcdef..c75c3ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -558,6 +558,7 @@ source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
source "package/boost/Config.in"
+source "package/glibmm/Config.in"
source "package/gmp/Config.in"
source "package/gsl/Config.in"
source "package/gtest/Config.in"
diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
new file mode 100644
index 0000000..16a7a9b
--- /dev/null
+++ b/package/glibmm/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_GLIBMM
+ bool "glibmm"
+ select BR2_PACKAGE_LIBGLIB2
+ select BR2_PACKAGE_LIBSIGC
+ help
+ The GLibmm package is a set of C++ bindings for GLib.
+
+ http://www.gtkmm.org/
diff --git a/package/glibmm/glibmm.mk b/package/glibmm/glibmm.mk
new file mode 100644
index 0000000..f7f49bd
--- /dev/null
+++ b/package/glibmm/glibmm.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# Glibmm
+#
+#############################################################
+GLIBMM_VERSION = 2.30.1
+GLIBMM_LICENSE = LGPLv2.1
+GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
+GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
+GLIBMM_INSTALL_STAGING = YES
+GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
+
+$(eval $(autotools-package))
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 2/2] libxml++: new package
2013-04-23 14:09 [Buildroot] [PATCH 1/2] glibmm: new package nmenegale
@ 2013-04-23 14:09 ` nmenegale
2013-04-23 14:20 ` [Buildroot] [PATCH 1/2] glibmm: " Gustavo Zacarias
1 sibling, 0 replies; 9+ messages in thread
From: nmenegale @ 2013-04-23 14:09 UTC (permalink / raw)
To: buildroot
Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
---
v0: initial commit
libxml++ is a C++ wrapper for libxml2 it has glibmm as dependency
---
package/Config.in | 1 +
package/libxmlpp/Config.in | 8 ++++++++
package/libxmlpp/libxmlpp.mk | 15 +++++++++++++++
3 files changed, 24 insertions(+)
create mode 100644 package/libxmlpp/Config.in
create mode 100644 package/libxmlpp/libxmlpp.mk
diff --git a/package/Config.in b/package/Config.in
index c75c3ec..8ce344b 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -620,6 +620,7 @@ source "package/json-glib/Config.in"
source "package/libroxml/Config.in"
source "package/libxml-parser-perl/Config.in"
source "package/libxml2/Config.in"
+source "package/libxmlpp/Config.in"
source "package/libxslt/Config.in"
source "package/libyaml/Config.in"
source "package/mxml/Config.in"
diff --git a/package/libxmlpp/Config.in b/package/libxmlpp/Config.in
new file mode 100644
index 0000000..e8b2419
--- /dev/null
+++ b/package/libxmlpp/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBXMLPP
+ bool "libxmlpp"
+ select BR2_PACKAGE_LIBXML2
+ select BR2_PACKAGE_GLIBMM
+ help
+ libxml++ is a C++ wrapper for the libxml XML parser library.
+
+ http://libxmlplusplus.sourceforge.net/
diff --git a/package/libxmlpp/libxmlpp.mk b/package/libxmlpp/libxmlpp.mk
new file mode 100644
index 0000000..693a83c
--- /dev/null
+++ b/package/libxmlpp/libxmlpp.mk
@@ -0,0 +1,15 @@
+#############################################################
+#
+# LibXML++
+#
+#############################################################
+LIBXMLPP_VERSION_MAJOR = 2.34
+LIBXMLPP_VERSION_MINOR = 2
+LIBXMLPP_VERSION = $(LIBXMLPP_VERSION_MAJOR).$(LIBXMLPP_VERSION_MINOR)
+LIBXMLPP_LICENSE = LGPLv2+
+LIBXMLPP_SOURCE = libxml++-$(LIBXMLPP_VERSION).tar.bz2
+LIBXMLPP_SITE = http://ftp.gnome.org/pub/GNOME/sources/libxml++/$(LIBXMLPP_VERSION_MAJOR)
+LIBXMLPP_INSTALL_STAGING = YES
+LIBXMLPP_DEPENDENCIES = libxml2 glibmm host-pkgconf
+
+$(eval $(autotools-package))
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] glibmm: new package
2013-04-23 14:09 [Buildroot] [PATCH 1/2] glibmm: new package nmenegale
2013-04-23 14:09 ` [Buildroot] [PATCH 2/2] libxml++: " nmenegale
@ 2013-04-23 14:20 ` Gustavo Zacarias
2013-04-23 14:31 ` Thomas Petazzoni
1 sibling, 1 reply; 9+ messages in thread
From: Gustavo Zacarias @ 2013-04-23 14:20 UTC (permalink / raw)
To: buildroot
On 04/23/2013 11:09 AM, nmenegale wrote:
> +++ b/package/glibmm/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_GLIBMM
> + bool "glibmm"
> + select BR2_PACKAGE_LIBGLIB2
> + select BR2_PACKAGE_LIBSIGC
> + help
> + The GLibmm package is a set of C++ bindings for GLib.
> +
> + http://www.gtkmm.org/
This should depend on BR2_INSTALL_LIBSTDCPP since it requires a
toolchain with C++ support, with a comment otherwise like other packages
do (look at package/protobuf/Config.in for an example).
Same case with libxml++.
> +++ b/package/glibmm/glibmm.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# Glibmm
> +#
> +#############################################################
> +GLIBMM_VERSION = 2.30.1
> +GLIBMM_LICENSE = LGPLv2.1
> +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
> +GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
> +GLIBMM_INSTALL_STAGING = YES
> +GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
> +
> +$(eval $(autotools-package))
You define GLIBMM_LICENSE but no GLIBMM_LICENSE_FILES, could you fix
that since glibmm ships them?
libglib2 depends on BR2_USE_WCHAR, you should add that too as a depend
in Config.in
Otherwise it's looking good, thanks.
Regards.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] glibmm: new package
2013-04-23 14:20 ` [Buildroot] [PATCH 1/2] glibmm: " Gustavo Zacarias
@ 2013-04-23 14:31 ` Thomas Petazzoni
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-04-23 14:31 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Tue, 23 Apr 2013 11:20:39 -0300, Gustavo Zacarias wrote:
> libglib2 depends on BR2_USE_WCHAR, you should add that too as a depend
> in Config.in
And therefore the libxml++ should also carry this dependency as a
consequence.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] glibmm: new package
@ 2013-04-24 8:13 nmenegale
2013-04-24 14:02 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: nmenegale @ 2013-04-24 8:13 UTC (permalink / raw)
To: buildroot
Signed-off-by: Nicolas M?n?gale <nicolas.menegale@openwide.fr>
---
v1: added BR2_INSTALL_LIBSTDCPP and BR2_USE_WCHAR
glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
---
package/Config.in | 1 +
package/glibmm/Config.in | 13 +++++++++++++
package/glibmm/glibmm.mk | 13 +++++++++++++
3 files changed, 27 insertions(+)
create mode 100644 package/glibmm/Config.in
create mode 100644 package/glibmm/glibmm.mk
diff --git a/package/Config.in b/package/Config.in
index 06bcdef..c75c3ec 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -558,6 +558,7 @@ source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
source "package/boost/Config.in"
+source "package/glibmm/Config.in"
source "package/gmp/Config.in"
source "package/gsl/Config.in"
source "package/gtest/Config.in"
diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
new file mode 100644
index 0000000..012b681
--- /dev/null
+++ b/package/glibmm/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_GLIBMM
+ bool "glibmm"
+ select BR2_PACKAGE_LIBGLIB2
+ select BR2_PACKAGE_LIBSIGC
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_USE_WCHAR
+ help
+ The GLibmm package is a set of C++ bindings for GLib.
+
+ http://www.gtkmm.org/
+
+comment "glibmm requires a toolchain with C++ & WCHAR support enabled"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
diff --git a/package/glibmm/glibmm.mk b/package/glibmm/glibmm.mk
new file mode 100644
index 0000000..f7f49bd
--- /dev/null
+++ b/package/glibmm/glibmm.mk
@@ -0,0 +1,13 @@
+#############################################################
+#
+# Glibmm
+#
+#############################################################
+GLIBMM_VERSION = 2.30.1
+GLIBMM_LICENSE = LGPLv2.1
+GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
+GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
+GLIBMM_INSTALL_STAGING = YES
+GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
+
+$(eval $(autotools-package))
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] glibmm: new package
2013-04-24 8:13 nmenegale
@ 2013-04-24 14:02 ` Thomas Petazzoni
2013-04-24 14:03 ` Thomas Petazzoni
2013-04-24 19:43 ` Peter Korsgaard
2 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-04-24 14:02 UTC (permalink / raw)
To: buildroot
Dear nmenegale,
On Wed, 24 Apr 2013 10:13:55 +0200, nmenegale wrote:
> diff --git a/package/glibmm/glibmm.mk b/package/glibmm/glibmm.mk
> new file mode 100644
> index 0000000..f7f49bd
> --- /dev/null
> +++ b/package/glibmm/glibmm.mk
> @@ -0,0 +1,13 @@
> +#############################################################
> +#
> +# Glibmm
> +#
> +#############################################################
> +GLIBMM_VERSION = 2.30.1
> +GLIBMM_LICENSE = LGPLv2.1
> +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
> +GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/2.30
> +GLIBMM_INSTALL_STAGING = YES
> +GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
> +
> +$(eval $(autotools-package))
A few minor comments:
* Please add an empty new line between the header and the the first
variable.
* Maybe you should split the version number in two variables in order
to re-use it for the site:
GLIBMM_VERSION_MAJOR = 2.30
GLIBMM_VERSION_MINOR = 1
GLIBMM_VERSION = $(GLIBMM_VERSION_MAJOR).$(GLIBMM_VERSION_MINOR)
GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/$(GLIBMM_VERSION_MAJOR)
* The licensing informations is not entirely correct. I think it
should be:
GLIBMM_LICENSE = LGPLv2.1+ (library), GPLv2+ (tools)
GLIBMM_LICENSE_FILES = COPYING COPYING.tools
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] glibmm: new package
2013-04-24 8:13 nmenegale
2013-04-24 14:02 ` Thomas Petazzoni
@ 2013-04-24 14:03 ` Thomas Petazzoni
2013-04-24 19:43 ` Peter Korsgaard
2 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-04-24 14:03 UTC (permalink / raw)
To: buildroot
Dear nmenegale,
On Wed, 24 Apr 2013 10:13:55 +0200, nmenegale wrote:
> +GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.bz2
I believe you could use the .tar.xz tarball instead, it's a bit smaller
to download.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] glibmm: new package
@ 2013-04-24 15:11 nmenegale
0 siblings, 0 replies; 9+ messages in thread
From: nmenegale @ 2013-04-24 15:11 UTC (permalink / raw)
To: buildroot
Signed-off-by: Nicolas M?n?gale <nicolas.menegale@openwide.fr>
---
v2: minor modifications: license, tar.xz instead of tar.bz2, version number split
glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
---
package/Config.in | 1 +
package/glibmm/Config.in | 13 +++++++++++++
package/glibmm/glibmm.mk | 17 +++++++++++++++++
3 files changed, 31 insertions(+)
create mode 100644 package/glibmm/Config.in
create mode 100644 package/glibmm/glibmm.mk
diff --git a/package/Config.in b/package/Config.in
index ab514c7..ca947d9 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -561,6 +561,7 @@ source "package/fftw/Config.in"
source "package/libargtable2/Config.in"
source "package/argp-standalone/Config.in"
source "package/boost/Config.in"
+source "package/glibmm/Config.in"
source "package/gmp/Config.in"
source "package/gsl/Config.in"
source "package/gtest/Config.in"
diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
new file mode 100644
index 0000000..012b681
--- /dev/null
+++ b/package/glibmm/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_GLIBMM
+ bool "glibmm"
+ select BR2_PACKAGE_LIBGLIB2
+ select BR2_PACKAGE_LIBSIGC
+ depends on BR2_INSTALL_LIBSTDCPP
+ depends on BR2_USE_WCHAR
+ help
+ The GLibmm package is a set of C++ bindings for GLib.
+
+ http://www.gtkmm.org/
+
+comment "glibmm requires a toolchain with C++ & WCHAR support enabled"
+ depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
diff --git a/package/glibmm/glibmm.mk b/package/glibmm/glibmm.mk
new file mode 100644
index 0000000..abd8b6c
--- /dev/null
+++ b/package/glibmm/glibmm.mk
@@ -0,0 +1,17 @@
+#############################################################
+#
+# Glibmm
+#
+#############################################################
+
+GLIBMM_VERSION_MAJOR = 2.30
+GLIBMM_VERSION_MINOR = 1
+GLIBMM_VERSION = $(GLIBMM_VERSION_MAJOR).$(GLIBMM_VERSION_MINOR)
+GLIBMM_LICENSE = LGPLv2.1+ (library), GPLv2+ (tools)
+GLIBMM_LICENSE_FILES = COPYING COPYING.tools
+GLIBMM_SOURCE = glibmm-$(GLIBMM_VERSION).tar.xz
+GLIBMM_SITE = http://ftp.gnome.org/pub/gnome/sources/glibmm/$(GLIBMM_VERSION_MAJOR)
+GLIBMM_INSTALL_STAGING = YES
+GLIBMM_DEPENDENCIES = libglib2 libsigc host-pkgconf
+
+$(eval $(autotools-package))
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH 1/2] glibmm: new package
2013-04-24 8:13 nmenegale
2013-04-24 14:02 ` Thomas Petazzoni
2013-04-24 14:03 ` Thomas Petazzoni
@ 2013-04-24 19:43 ` Peter Korsgaard
2 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2013-04-24 19:43 UTC (permalink / raw)
To: buildroot
>>>>> "nmenegale" == nmenegale <nicolas.menegale@openwide.fr> writes:
nmenegale> Signed-off-by: Nicolas M?n?gale <nicolas.menegale@openwide.fr>
nmenegale> ---
nmenegale> v1: added BR2_INSTALL_LIBSTDCPP and BR2_USE_WCHAR
nmenegale> glibmm is also a dependency of libxml++ (the libxml2 c++ wrapper)
nmenegale> Signed-off-by: nmenegale <nicolas.menegale@openwide.fr>
nmenegale> ---
nmenegale> package/Config.in | 1 +
nmenegale> package/glibmm/Config.in | 13 +++++++++++++
nmenegale> package/glibmm/glibmm.mk | 13 +++++++++++++
nmenegale> 3 files changed, 27 insertions(+)
nmenegale> create mode 100644 package/glibmm/Config.in
nmenegale> create mode 100644 package/glibmm/glibmm.mk
nmenegale> diff --git a/package/Config.in b/package/Config.in
nmenegale> index 06bcdef..c75c3ec 100644
nmenegale> --- a/package/Config.in
nmenegale> +++ b/package/Config.in
nmenegale> @@ -558,6 +558,7 @@ source "package/fftw/Config.in"
nmenegale> source "package/libargtable2/Config.in"
nmenegale> source "package/argp-standalone/Config.in"
nmenegale> source "package/boost/Config.in"
nmenegale> +source "package/glibmm/Config.in"
nmenegale> source "package/gmp/Config.in"
nmenegale> source "package/gsl/Config.in"
nmenegale> source "package/gtest/Config.in"
nmenegale> diff --git a/package/glibmm/Config.in b/package/glibmm/Config.in
nmenegale> new file mode 100644
nmenegale> index 0000000..012b681
nmenegale> --- /dev/null
nmenegale> +++ b/package/glibmm/Config.in
nmenegale> @@ -0,0 +1,13 @@
nmenegale> +config BR2_PACKAGE_GLIBMM
nmenegale> + bool "glibmm"
nmenegale> + select BR2_PACKAGE_LIBGLIB2
nmenegale> + select BR2_PACKAGE_LIBSIGC
nmenegale> + depends on BR2_INSTALL_LIBSTDCPP
nmenegale> + depends on BR2_USE_WCHAR
nmenegale> + help
nmenegale> + The GLibmm package is a set of C++ bindings for GLib.
nmenegale> +
There's some stray trailing spaces here. Committed with that fixed,
thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-04-24 19:43 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-23 14:09 [Buildroot] [PATCH 1/2] glibmm: new package nmenegale
2013-04-23 14:09 ` [Buildroot] [PATCH 2/2] libxml++: " nmenegale
2013-04-23 14:20 ` [Buildroot] [PATCH 1/2] glibmm: " Gustavo Zacarias
2013-04-23 14:31 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2013-04-24 8:13 nmenegale
2013-04-24 14:02 ` Thomas Petazzoni
2013-04-24 14:03 ` Thomas Petazzoni
2013-04-24 19:43 ` Peter Korsgaard
2013-04-24 15:11 nmenegale
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox