* [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume
@ 2013-05-11 4:38 Anders Darander
2013-05-11 6:36 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Anders Darander @ 2013-05-11 4:38 UTC (permalink / raw)
To: buildroot
(Resend a as I first sent from an unsubcribed email).
Arnout Vandecappelle <arnout@mind.be> wrote:
>On 09/05/13 22:31, Anders Darander wrote:
>> From: Anders Darander <anders@chargestorm.se>
>>
>> Without this firmware, the beaglebone won't be able to reboot
>correctly.
>>
>> Signed-off-by: Anders Darander <anders@chargestorm.se>
>[snip]
>> diff --git a/package/am33x-cm3/am33x-cm3.mk
>b/package/am33x-cm3/am33x-cm3.mk
>> new file mode 100644
>> index 0000000..6180157
>> --- /dev/null
>> +++ b/package/am33x-cm3/am33x-cm3.mk
>> @@ -0,0 +1,26 @@
>> +#############################################################
>> +#
>> +# am33x-cm3
>> +#
>> +#############################################################
>> +
>> +# SHA1 corresponds to tag "AM335xPSP_04.06.00.10-rc1"
>> +AM33X_CM3_VERSION = 27ca4643e422245a95723de1df0247a00eada45b
>
> If it is a tag, then use the tag, not the sha1.
Ok, I'll double check that the tag exists and update the patch.
>> +AM33X_CM3_SITE = git://arago-project.org/git/projects/am33x-cm3.git
>> +AM33X_CM3_METHOD = git
>
> Since the site starts with git://, the method is git by default.
I didn't get the fetcher to actually try git unless I added the method
explicitly. All my previous ?ries ended with wget errors.
>However, if the site supports http, we prefer to use that. Some company
>
>firewalls block git.
Ok I'll lade if I can find out if http is available.
>> +AM33X_CM3_LICENSE = TI-BSD
>
>I don't really like this license name. Either it's BSD (then it should
>specify 2-, 3- or 4-clause), or it is not. In the latter case, it would
>
>be something like "TI Open Source license (BSD-like)".
To be honest, I merely used what TI is using in their own BSP. I'll see
what it reads like.
>> +AM33X_CM3_LICENSE_FILES = License.txt
>> +
>> +define AM33X_CM3_BUILD_CMDS
>> + $(MAKE) CC="$(TARGET_CC)" CROSS_COMPILE="$(TARGET_CROSS)" -C $(@D)
>all
>
>Does it work with $(TARGET_CONFIGURE_OPTS) instead of CC=? If not, then
>
>please also pass the CFLAGS and LDFLAGS - they may be important.
>
>However, now I think about it - this is abusing the cross-compiler for
>the Cortex-A8 to generate code for the Cortex-M3, correct? In that
>case,
>passing CFLAGS and LDFLAGS is probably not a good idea. But it would
>also
>be good to add a note about what is happening here.
I'll add a comment on this. Once again, the technique is taken from the
TI's BSP.
>> +endef
>> +
>> +# Not all of the firmware files are used
>> +define AM33X_CM3_INSTALL_TARGET_CMDS
>> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/
>> + $(INSTALL) -m 0644 $(@D)/bin/am335x-pm-firmware.bin
>$(TARGET_DIR)/lib/firmware
>
> We normally create directories with the -D option to install, so:
>
> $(INSTALL) -m 0644 -D $(@D)/bin/am335x-pm-firmware.bin \
> $(TARGET_DIR)/lib/firmware/am335x-pm-firmware.bin
Ok, I'll fix that.
>> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/init.d
>> + $(INSTALL) -m 0755 package/am33x-cm3/am335x-pm-firmware-load
>$(TARGET_DIR)/etc/init.d/S93-am335x-pm-firwmare-load
>
> init scripts are installed by a separate variable,
>AM33X_CM3_INSTALL_INIT_SYSV. And of course, the same remark about the
>-D
>option applies.
Thanks, I'm fox that too.
Does that make it install when using busybox init also?
Thanks for the feedback!
Cheers,
Anders
--
Anders Darander
ChargeStorm AB Tel: +46 702 44 84 36
Laxholmstorget 3 Email: anders at chargestorm.se
602 21 Norrk?ping Web: www.chargestorm.se
Sent from my Android phone with K-9 Mail. Please excuse my brevity.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130511/aa443ece/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume
2013-05-11 4:38 [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume Anders Darander
@ 2013-05-11 6:36 ` Arnout Vandecappelle
2013-05-11 12:25 ` Anders Darander
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-05-11 6:36 UTC (permalink / raw)
To: buildroot
On 11/05/13 06:38, Anders Darander wrote:
> (Resend a as I first sent from an unsubcribed email).
>
> Arnout Vandecappelle <arnout at mind.be <mailto:arnout@mind.be>> wrote:
>
> >On 09/05/13 22:31, Anders Darander wrote:
> >> From: Anders Darander <anders@chargestorm.se
> >>
> >> Without this firmware, the beaglebone won't be able to reboot
> >correctly.
> >>
> >> Signed-off-by: Anders Darander <anders@chargestorm.se
> >[snip]
> >> diff --git a/package/am33x-cm3/am33x-cm3.mk <http://am33x-cm3.mk>
> >b/package/am33x-cm3/am33x-cm3.mk <http://am33x-cm3.mk>
> >> new file mode 100644
> >> index 0000000..6180157
> >> --- /dev/null
> >> +++ b/package/am33x-cm3/am33x-cm3.mk <http://am33x-cm3.mk>
> >> @@ -0,0 +1,26 @@
> >> +#############################################################
> >> +#
> >> +# am33x-cm3
> >> +#
> >> +#############################################################
> >> +
> >> +# SHA1 corresponds to tag "AM335xPSP_04.06.00.10-rc1"
> >> +AM33X_CM3_VERSION = 27ca4643e422245a95723de1df0247a00eada45b
> >
> > If it is a tag, then use the tag, not the sha1.
>
> Ok, I'll double check that the tag exists and update the patch.
>
> >> +AM33X_CM3_SITE = git://arago-project.org/git/projects/am33x-cm3.git
> >> +AM33X_CM3_METHOD = git
> >
> > Since the site starts with git://, the method is git by default.
>
> I didn't get the fetcher to actually try git unless I added the method
> explicitly. All my previous ?ries ended with wget errors.
Works for me though. But anyway, if you switch to http it's irrelevant.
>
> >However, if the site supports http, we prefer to use that. Some company
> >
> >firewalls block git.
>
> Ok I'll lade if I can find out if http is available.
>
> >> +AM33X_CM3_LICENSE = TI-BSD
> >
> >I don't really like this license name. Either it's BSD (then it should
> >specify 2-, 3- or 4-clause), or it is not. In the latter case, it would
> >
> >be something like "TI Open Source license (BSD-like)".
>
> To be honest, I merely used what TI is using in their own BSP. I'll see
> what it reads like.
OK I checked and there's nothing BSD-like about it. The full title is
Texas Instruments Incorporated Technology and Software Publicly Available
Software License Agreement
I propose we abbreviate that to e.g.
TI Publicly Available Software License
> >> +AM33X_CM3_LICENSE_FILES = License.txt
> >> +
> >> +define AM33X_CM3_BUILD_CMDS
> >> + $(MAKE) CC="$(TARGET_CC)" CROSS_COMPILE="$(TARGET_CROSS)" -C $(@D)
> >all
> >
> >Does it work with $(TARGET_CONFIGURE_OPTS) instead of CC=? If not, then
> >
> >please also pass the CFLAGS and LDFLAGS - they may be important.
> >
> >However, now I think about it - this is abusing the cross-compiler for
> >the Cortex-A8 to generate code for the Cortex-M3, correct? In that
> >case,
> >passing CFLAGS and LDFLAGS is probably not a good idea. But it would
> >also
> >be good to add a note about what is happening here.
>
> I'll add a comment on this. Once again, the technique is taken from the
> TI's BSP.
I get a lot of
warning: switch -mcpu=cortex-m3 conflicts with -march=armv7-a switch
[enabled by default]
but I guess these are harmless.
(the -march=armv7-a is added by the toolchain wrapper).
But I'm not 100% sure if a custom toolchain will actually build for the
correct architecture. Could you try if the result of something built with
the buildroot toolchain works correctly? If you want, I can send you the
.bin file so you don't have to wait an hour for the whole toolchain to
compile. Or, if you have actually tested it with a buildroot toolchain,
could you try if it also works with an external Sourcery and/or Linaro
toolchain?
> >> +endef
> >> +
> >> +# Not all of the firmware files are used
> >> +define AM33X_CM3_INSTALL_TARGET_CMDS
> >> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/
> >> + $(INSTALL) -m 0644 $(@D)/bin/am335x-pm-firmware.bin
> >$(TARGET_DIR)/lib/firmware
> >
> > We normally create directories with the -D option to install, so:
> >
> > $(INSTALL) -m 0644 -D $(@D)/bin/am335x-pm-firmware.bin \
> > $(TARGET_DIR)/lib/firmware/am335x-pm-firmware.bin
>
> Ok, I'll fix that.
>
> >> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/init.d
> >> + $(INSTALL) -m 0755 package/am33x-cm3/am335x-pm-firmware-load
> >$(TARGET_DIR)/etc/init.d/S93-am335x-pm-firwmare-load
> >
> > init scripts are installed by a separate variable,
> >AM33X_CM3_INSTALL_INIT_SYSV. And of course, the same remark about the
> >-D
> >option applies.
>
> Thanks, I'm fox that too.
>
> Does that make it install when using busybox init also?
Yes it does.
Only when systemd is selected, it doesn't install anything. So ideally
you should also add a systemd unit file.
Regards,
Arnout
>
> Thanks for the feedback!
>
> Cheers,
> Anders
>
> --
> Anders Darander
> ChargeStorm AB Tel: +46 702 44 84 36
> Laxholmstorget 3 Email: anders at chargestorm.se
> <mailto:anders@chargestorm.se>
> 602 21 Norrk?ping Web: www.chargestorm.se <http://www.chargestorm.se>
>
> Sent from my Android phone with K-9 Mail. Please excuse my brevity.
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume
2013-05-11 6:36 ` Arnout Vandecappelle
@ 2013-05-11 12:25 ` Anders Darander
2013-05-12 16:59 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Anders Darander @ 2013-05-11 12:25 UTC (permalink / raw)
To: buildroot
On 11 May 2013 08:36, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 11/05/13 06:38, Anders Darander wrote:
>
>> (Resend a as I first sent from an unsubcribed email).
>>
>> Arnout Vandecappelle <arnout at mind.be <mailto:arnout@mind.be>> wrote:
>>
>> >On 09/05/13 22:31, Anders Darander wrote:
>> >> From: Anders Darander <anders@chargestorm.se
>>
>
> >> +AM33X_CM3_LICENSE_FILES = License.txt
>> >> +
>> >> +define AM33X_CM3_BUILD_CMDS
>> >> + $(MAKE) CC="$(TARGET_CC)" CROSS_COMPILE="$(TARGET_CROSS)**" -C
>> $(@D)
>> >all
>> >
>> >Does it work with $(TARGET_CONFIGURE_OPTS) instead of CC=? If not, then
>> >
>> >please also pass the CFLAGS and LDFLAGS - they may be important.
>> >
>> >However, now I think about it - this is abusing the cross-compiler for
>> >the Cortex-A8 to generate code for the Cortex-M3, correct? In that
>> >case,
>> >passing CFLAGS and LDFLAGS is probably not a good idea. But it would
>> >also
>> >be good to add a note about what is happening here.
>>
>> I'll add a comment on this. Once again, the technique is taken from the
>> TI's BSP.
>>
>
> I get a lot of
>
> warning: switch -mcpu=cortex-m3 conflicts with -march=armv7-a switch
> [enabled by default]
>
> but I guess these are harmless.
>
> (the -march=armv7-a is added by the toolchain wrapper).
>
Using what toolchain? I'm not seeing these warning (and neither am I seeing
any -march=armv7-a) in my test builds. I'm using the buildroot toolchain
generated with this patch series applied to the 2013.05-rc1 tag.
> But I'm not 100% sure if a custom toolchain will actually build for the
> correct architecture. Could you try if the result of something built with
> the buildroot toolchain works correctly? If you want, I can send you the
> .bin file so you don't have to wait an hour for the whole toolchain to
> compile. Or, if you have actually tested it with a buildroot toolchain,
> could you try if it also works with an external Sourcery and/or Linaro
> toolchain?
>
>
> > init scripts are installed by a separate variable,
>> >AM33X_CM3_INSTALL_INIT_SYSV. And of course, the same remark about the
>> >-D
>> >option applies.
>>
>> Thanks, I'm fox that too.
>>
>> Does that make it install when using busybox init also?
>>
>
> Yes it does.
>
> Only when systemd is selected, it doesn't install anything. So ideally
> you should also add a systemd unit file.
>
As I'm not building systemd in any buildroot / beaglebone project, I think
I'll wait with adding the systemd unit file until I can test it more. Or if
someone beats me to it.
Version 2 of the patch series on it's way...
Cheers,
Anders
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20130511/95081d5a/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume
2013-05-11 12:25 ` Anders Darander
@ 2013-05-12 16:59 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-05-12 16:59 UTC (permalink / raw)
To: buildroot
On 11/05/13 14:25, Anders Darander wrote:
>
>
>
> On 11 May 2013 08:36, Arnout Vandecappelle <arnout@mind.be
> <mailto:arnout@mind.be>> wrote:
[snip]
> I get a lot of
>
> warning: switch -mcpu=cortex-m3 conflicts with -march=armv7-a switch
> [enabled by default]
>
> but I guess these are harmless.
>
> (the -march=armv7-a is added by the toolchain wrapper).
>
>
> Using what toolchain?
Sourcery external toolchain.
> I'm not seeing these warning (and neither am I
> seeing any -march=armv7-a) in my test builds. I'm using the buildroot
> toolchain generated with this patch series applied to the 2013.05-rc1 tag.
OK, that answers my question if you had tested it with an internal
toolchain :-)
>
> But I'm not 100% sure if a custom toolchain will actually build for
> the correct architecture. Could you try if the result of something
> built with the buildroot toolchain works correctly? If you want, I
> can send you the .bin file so you don't have to wait an hour for the
> whole toolchain to compile. Or, if you have actually tested it with a
> buildroot toolchain, could you try if it also works with an external
> Sourcery and/or Linaro toolchain?
>
> > init scripts are installed by a separate variable,
> >AM33X_CM3_INSTALL_INIT_SYSV. And of course, the same remark
> about the
> >-D
> >option applies.
>
> Thanks, I'm fox that too.
>
> Does that make it install when using busybox init also?
>
>
> Yes it does.
>
> Only when systemd is selected, it doesn't install anything. So
> ideally you should also add a systemd unit file.
>
>
> As I'm not building systemd in any buildroot / beaglebone project, I
> think I'll wait with adding the systemd unit file until I can test it
> more. Or if someone beats me to it.
Fair enough.
Regards,
Arnout
>
> Version 2 of the patch series on it's way...
>
> Cheers,
> Anders
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 0/5] Upgrade BeagleBone kernel to 3.8
@ 2013-05-09 20:31 Anders Darander
2013-05-09 20:31 ` [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume Anders Darander
0 siblings, 1 reply; 6+ messages in thread
From: Anders Darander @ 2013-05-09 20:31 UTC (permalink / raw)
To: buildroot
From: Anders Darander <anders@chargestorm.se>
Hi,
(I'm resending this series from a subscribed address).
This patch series upgrades the kernel for the BeagleBone to 3.8.
The 3.8 kernel is taken from TI's own repo, and the actual branch/commit used
are the same as currently being used in their own BSP (see meta-ti for
OpenEmbedded / Yocto).
As the BB support is being mainlined, the old board-setup has been removed,
thus the 3.8 kernel requires the use of a device tree. (A DTS, am33x-bone.dts
is included in the kernel).
The new package, am33x-cm3, consists of the FW blob for the Cortex M3 on the
BB that handles the power management of the board. Without this firmware
loaded, even a simple `reboot` won't succeed. In the old 3.2 kernel, this was
compiled in as a part of the kernel, however, in the 3.8 kernel, it has to be
loaded during the runtime.
The last patch in the series (0005-beaglebone-enable-NFS-root.patch) is not
necessary; it's only my preferred way of testing.
Cheers,
Anders
Anders Darander (5):
beaglebone: update to linux 3.8
beaglebone: reduce defconfig
am33x-cm3: add FW for suspend/resume
beaglebone: add am33x-cm3
beaglebone: enable NFS root
board/beaglebone/linux-3.2.9.config | 252 -----------------------------
board/beaglebone/linux-3.8.config | 203 +++++++++++++++++++++++
configs/beaglebone_defconfig | 23 +--
package/Config.in | 1 +
package/am33x-cm3/Config.in | 4 +
package/am33x-cm3/am335x-pm-firmware-load | 6 +
package/am33x-cm3/am33x-cm3.mk | 26 +++
7 files changed, 247 insertions(+), 268 deletions(-)
delete mode 100644 board/beaglebone/linux-3.2.9.config
create mode 100644 board/beaglebone/linux-3.8.config
create mode 100644 package/am33x-cm3/Config.in
create mode 100755 package/am33x-cm3/am335x-pm-firmware-load
create mode 100644 package/am33x-cm3/am33x-cm3.mk
--
1.7.10.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume
2013-05-09 20:31 [Buildroot] [PATCH 0/5] Upgrade BeagleBone kernel to 3.8 Anders Darander
@ 2013-05-09 20:31 ` Anders Darander
2013-05-10 22:56 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Anders Darander @ 2013-05-09 20:31 UTC (permalink / raw)
To: buildroot
From: Anders Darander <anders@chargestorm.se>
Without this firmware, the beaglebone won't be able to reboot correctly.
Signed-off-by: Anders Darander <anders@chargestorm.se>
---
package/Config.in | 1 +
package/am33x-cm3/Config.in | 4 ++++
package/am33x-cm3/am335x-pm-firmware-load | 6 ++++++
package/am33x-cm3/am33x-cm3.mk | 26 ++++++++++++++++++++++++++
4 files changed, 37 insertions(+)
create mode 100644 package/am33x-cm3/Config.in
create mode 100755 package/am33x-cm3/am335x-pm-firmware-load
create mode 100644 package/am33x-cm3/am33x-cm3.mk
diff --git a/package/Config.in b/package/Config.in
index d980871..329d734 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -213,6 +213,7 @@ endmenu
menu "Hardware handling"
menu "Misc devices firmwares"
+source "package/am33x-cm3/Config.in"
source "package/b43-firmware/Config.in"
source "package/firmware-imx/Config.in"
source "package/linux-firmware/Config.in"
diff --git a/package/am33x-cm3/Config.in b/package/am33x-cm3/Config.in
new file mode 100644
index 0000000..ee39f7d
--- /dev/null
+++ b/package/am33x-cm3/Config.in
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_AM33X_CM3
+ bool "am33x-cm3"
+ help
+ Cortex-M3 binary blob for suspend-resume
diff --git a/package/am33x-cm3/am335x-pm-firmware-load b/package/am33x-cm3/am335x-pm-firmware-load
new file mode 100755
index 0000000..56c17b3
--- /dev/null
+++ b/package/am33x-cm3/am335x-pm-firmware-load
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+# Load the PM CM3 firmware
+echo 1 > /sys/devices/ocp.2/44d00000.wkup_m3/firmware/am335x-pm-firmware.bin/loading
+cat /lib/firmware/am335x-pm-firmware.bin > /sys/devices/ocp.2/44d00000.wkup_m3/firmware/am335x-pm-firmware.bin/data
+echo 0 > /sys/devices/ocp.2/44d00000.wkup_m3/firmware/am335x-pm-firmware.bin/loading
diff --git a/package/am33x-cm3/am33x-cm3.mk b/package/am33x-cm3/am33x-cm3.mk
new file mode 100644
index 0000000..6180157
--- /dev/null
+++ b/package/am33x-cm3/am33x-cm3.mk
@@ -0,0 +1,26 @@
+#############################################################
+#
+# am33x-cm3
+#
+#############################################################
+
+# SHA1 corresponds to tag "AM335xPSP_04.06.00.10-rc1"
+AM33X_CM3_VERSION = 27ca4643e422245a95723de1df0247a00eada45b
+AM33X_CM3_SITE = git://arago-project.org/git/projects/am33x-cm3.git
+AM33X_CM3_METHOD = git
+AM33X_CM3_LICENSE = TI-BSD
+AM33X_CM3_LICENSE_FILES = License.txt
+
+define AM33X_CM3_BUILD_CMDS
+ $(MAKE) CC="$(TARGET_CC)" CROSS_COMPILE="$(TARGET_CROSS)" -C $(@D) all
+endef
+
+# Not all of the firmware files are used
+define AM33X_CM3_INSTALL_TARGET_CMDS
+ $(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/
+ $(INSTALL) -m 0644 $(@D)/bin/am335x-pm-firmware.bin $(TARGET_DIR)/lib/firmware
+ $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/init.d
+ $(INSTALL) -m 0755 package/am33x-cm3/am335x-pm-firmware-load $(TARGET_DIR)/etc/init.d/S93-am335x-pm-firwmare-load
+endef
+
+$(eval $(generic-package))
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume
2013-05-09 20:31 ` [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume Anders Darander
@ 2013-05-10 22:56 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-05-10 22:56 UTC (permalink / raw)
To: buildroot
On 09/05/13 22:31, Anders Darander wrote:
> From: Anders Darander <anders@chargestorm.se>
>
> Without this firmware, the beaglebone won't be able to reboot correctly.
>
> Signed-off-by: Anders Darander <anders@chargestorm.se>
[snip]
> diff --git a/package/am33x-cm3/am33x-cm3.mk b/package/am33x-cm3/am33x-cm3.mk
> new file mode 100644
> index 0000000..6180157
> --- /dev/null
> +++ b/package/am33x-cm3/am33x-cm3.mk
> @@ -0,0 +1,26 @@
> +#############################################################
> +#
> +# am33x-cm3
> +#
> +#############################################################
> +
> +# SHA1 corresponds to tag "AM335xPSP_04.06.00.10-rc1"
> +AM33X_CM3_VERSION = 27ca4643e422245a95723de1df0247a00eada45b
If it is a tag, then use the tag, not the sha1.
> +AM33X_CM3_SITE = git://arago-project.org/git/projects/am33x-cm3.git
> +AM33X_CM3_METHOD = git
Since the site starts with git://, the method is git by default.
However, if the site supports http, we prefer to use that. Some company
firewalls block git.
> +AM33X_CM3_LICENSE = TI-BSD
I don't really like this license name. Either it's BSD (then it should
specify 2-, 3- or 4-clause), or it is not. In the latter case, it would
be something like "TI Open Source license (BSD-like)".
> +AM33X_CM3_LICENSE_FILES = License.txt
> +
> +define AM33X_CM3_BUILD_CMDS
> + $(MAKE) CC="$(TARGET_CC)" CROSS_COMPILE="$(TARGET_CROSS)" -C $(@D) all
Does it work with $(TARGET_CONFIGURE_OPTS) instead of CC=? If not, then
please also pass the CFLAGS and LDFLAGS - they may be important.
However, now I think about it - this is abusing the cross-compiler for
the Cortex-A8 to generate code for the Cortex-M3, correct? In that case,
passing CFLAGS and LDFLAGS is probably not a good idea. But it would also
be good to add a note about what is happening here.
> +endef
> +
> +# Not all of the firmware files are used
> +define AM33X_CM3_INSTALL_TARGET_CMDS
> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/
> + $(INSTALL) -m 0644 $(@D)/bin/am335x-pm-firmware.bin $(TARGET_DIR)/lib/firmware
We normally create directories with the -D option to install, so:
$(INSTALL) -m 0644 -D $(@D)/bin/am335x-pm-firmware.bin \
$(TARGET_DIR)/lib/firmware/am335x-pm-firmware.bin
> + $(INSTALL) -d -m 0755 $(TARGET_DIR)/etc/init.d
> + $(INSTALL) -m 0755 package/am33x-cm3/am335x-pm-firmware-load $(TARGET_DIR)/etc/init.d/S93-am335x-pm-firwmare-load
init scripts are installed by a separate variable,
AM33X_CM3_INSTALL_INIT_SYSV. And of course, the same remark about the -D
option applies.
Regards,
Arnout
> +endef
> +
> +$(eval $(generic-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-12 16:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-11 4:38 [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume Anders Darander
2013-05-11 6:36 ` Arnout Vandecappelle
2013-05-11 12:25 ` Anders Darander
2013-05-12 16:59 ` Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2013-05-09 20:31 [Buildroot] [PATCH 0/5] Upgrade BeagleBone kernel to 3.8 Anders Darander
2013-05-09 20:31 ` [Buildroot] [PATCH 3/5] am33x-cm3: add FW for suspend/resume Anders Darander
2013-05-10 22:56 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox