* [Buildroot] [PATCH] modplugtools: Added package
@ 2014-10-17 17:10 Maarten ter Huurne
2014-10-18 14:13 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Maarten ter Huurne @ 2014-10-17 17:10 UTC (permalink / raw)
To: buildroot
This installs the 'modplug123' command line tool to play music files
using libmodplug.
http://modplug-xmms.sourceforge.net/
Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
---
The command line tool is about 10 kB in size and is useful to test
libmodplug and/or audio playback in general.
package/Config.in | 1 +
package/modplugtools/Config.in | 9 +++++++++
package/modplugtools/modplugtools.mk | 21 +++++++++++++++++++++
3 files changed, 31 insertions(+)
create mode 100644 package/modplugtools/Config.in
create mode 100644 package/modplugtools/modplugtools.mk
diff --git a/package/Config.in b/package/Config.in
index 76fd1a0..03c7074 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -18,6 +18,7 @@ menu "Audio and video applications"
source "package/lame/Config.in"
source "package/libvpx/Config.in"
source "package/madplay/Config.in"
+ source "package/modplugtools/Config.in"
source "package/mpd/Config.in"
source "package/mpg123/Config.in"
source "package/mplayer/Config.in"
diff --git a/package/modplugtools/Config.in b/package/modplugtools/Config.in
new file mode 100644
index 0000000..53e9672
--- /dev/null
+++ b/package/modplugtools/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_MODPLUGTOOLS
+ bool "modplugtools"
+ select BR2_PACKAGE_LIBAO
+ select BR2_PACKAGE_LIBMODPLUG
+ help
+ This installs the 'modplug123' command line tool to play music files
+ using libmodplug.
+
+ http://modplug-xmms.sourceforge.net/
diff --git a/package/modplugtools/modplugtools.mk b/package/modplugtools/modplugtools.mk
new file mode 100644
index 0000000..392f0f2
--- /dev/null
+++ b/package/modplugtools/modplugtools.mk
@@ -0,0 +1,21 @@
+################################################################################
+#
+# modplugtools
+#
+################################################################################
+
+MODPLUGTOOLS_VERSION = 0.5.3
+MODPLUGTOOLS_SITE = http://downloads.sourceforge.net/project/modplug-xmms/modplug-tools
+MODPLUGTOOLS_LICENSE = GPLv3
+MODPLUGTOOLS_LICENSE_FILES = COPYING
+
+MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
+
+# Only play through libao: some platforms don't have OSS support and for those
+# that do, playing through libao is still going to be sufficient.
+define MODPLUGTOOLS_REMOVE_MODPLUGPLAY
+ rm $(TARGET_DIR)/usr/bin/modplugplay
+endef
+MODPLUGTOOLS_POST_INSTALL_TARGET_HOOKS += MODPLUGTOOLS_REMOVE_MODPLUGPLAY
+
+$(eval $(autotools-package))
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] modplugtools: Added package
2014-10-17 17:10 [Buildroot] [PATCH] modplugtools: Added package Maarten ter Huurne
@ 2014-10-18 14:13 ` Arnout Vandecappelle
2014-10-18 17:19 ` Maarten ter Huurne
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2014-10-18 14:13 UTC (permalink / raw)
To: buildroot
On 17/10/14 19:10, Maarten ter Huurne wrote:
> This installs the 'modplug123' command line tool to play music files
> using libmodplug.
>
> http://modplug-xmms.sourceforge.net/
>
> Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
> ---
> The command line tool is about 10 kB in size and is useful to test
> libmodplug and/or audio playback in general.
>
> package/Config.in | 1 +
> package/modplugtools/Config.in | 9 +++++++++
> package/modplugtools/modplugtools.mk | 21 +++++++++++++++++++++
> 3 files changed, 31 insertions(+)
> create mode 100644 package/modplugtools/Config.in
> create mode 100644 package/modplugtools/modplugtools.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 76fd1a0..03c7074 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -18,6 +18,7 @@ menu "Audio and video applications"
> source "package/lame/Config.in"
> source "package/libvpx/Config.in"
> source "package/madplay/Config.in"
> + source "package/modplugtools/Config.in"
> source "package/mpd/Config.in"
> source "package/mpg123/Config.in"
> source "package/mplayer/Config.in"
> diff --git a/package/modplugtools/Config.in b/package/modplugtools/Config.in
> new file mode 100644
> index 0000000..53e9672
> --- /dev/null
> +++ b/package/modplugtools/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_MODPLUGTOOLS
> + bool "modplugtools"
> + select BR2_PACKAGE_LIBAO
> + select BR2_PACKAGE_LIBMODPLUG
> + help
> + This installs the 'modplug123' command line tool to play music files
> + using libmodplug.
Small nit: I'd say "MOD files" rather than "music files". Or does it play other
formats as well?
> +
> + http://modplug-xmms.sourceforge.net/
> diff --git a/package/modplugtools/modplugtools.mk b/package/modplugtools/modplugtools.mk
> new file mode 100644
> index 0000000..392f0f2
> --- /dev/null
> +++ b/package/modplugtools/modplugtools.mk
> @@ -0,0 +1,21 @@
> +################################################################################
> +#
> +# modplugtools
> +#
> +################################################################################
> +
> +MODPLUGTOOLS_VERSION = 0.5.3
> +MODPLUGTOOLS_SITE = http://downloads.sourceforge.net/project/modplug-xmms/modplug-tools
> +MODPLUGTOOLS_LICENSE = GPLv3
> +MODPLUGTOOLS_LICENSE_FILES = COPYING
It's indeed v3 only (cfr. AUTHORS).
> +
> +MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
> +
> +# Only play through libao: some platforms don't have OSS support and for those
> +# that do, playing through libao is still going to be sufficient.
> +define MODPLUGTOOLS_REMOVE_MODPLUGPLAY
> + rm $(TARGET_DIR)/usr/bin/modplugplay
I don't understand this. The executable is really small, and it builds
correctly (otherwise you wouldn't even get this far), so why bother with
removing it? Someone who cares that much about their rootfs size will have to
remove a bunch of other stuff from the installed system anyway.
Regards,
Arnout
> +endef
> +MODPLUGTOOLS_POST_INSTALL_TARGET_HOOKS += MODPLUGTOOLS_REMOVE_MODPLUGPLAY
> +
> +$(eval $(autotools-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] modplugtools: Added package
2014-10-18 14:13 ` Arnout Vandecappelle
@ 2014-10-18 17:19 ` Maarten ter Huurne
2014-10-18 17:44 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Maarten ter Huurne @ 2014-10-18 17:19 UTC (permalink / raw)
To: buildroot
On Saturday 18 October 2014 16:13:24 Arnout Vandecappelle wrote:
> On 17/10/14 19:10, Maarten ter Huurne wrote:
> > diff --git a/package/modplugtools/Config.in
> > b/package/modplugtools/Config.in new file mode 100644
> > index 0000000..53e9672
> > --- /dev/null
> > +++ b/package/modplugtools/Config.in
> > @@ -0,0 +1,9 @@
> > +config BR2_PACKAGE_MODPLUGTOOLS
> > + bool "modplugtools"
> > + select BR2_PACKAGE_LIBAO
> > + select BR2_PACKAGE_LIBMODPLUG
> > + help
> > + This installs the 'modplug123' command line tool to play music
files
> > + using libmodplug.
>
> Small nit: I'd say "MOD files" rather than "music files". Or does it play
> other formats as well?
It plays various tracker formats. I tested it with S3M files, for example. I
considered "tracker songs" instead of "music files", but I wasn't sure
whether "tracker" is still a commonly understood term.
> > +
> > +MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
> > +
> > +# Only play through libao: some platforms don't have OSS support and
> > for those +# that do, playing through libao is still going to be
> > sufficient. +define MODPLUGTOOLS_REMOVE_MODPLUGPLAY
> > + rm $(TARGET_DIR)/usr/bin/modplugplay
>
> I don't understand this. The executable is really small, and it builds
> correctly (otherwise you wouldn't even get this far), so why bother with
> removing it? Someone who cares that much about their rootfs size will have
> to remove a bunch of other stuff from the installed system anyway.
It wouldn't execute correctly on target systems that don't have OSS support.
Since OSS has been deprecated in the kernel for many years (*), my hope is
that most embedded kernels today don't have OSS support.
(*) I tried to look up how long, but it predates the move to Git in 2005.
Bye,
Maarten
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] modplugtools: Added package
2014-10-18 17:19 ` Maarten ter Huurne
@ 2014-10-18 17:44 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2014-10-18 17:44 UTC (permalink / raw)
To: buildroot
Maarten, All,
On 2014-10-18 19:19 +0200, Maarten ter Huurne spake thusly:
> On Saturday 18 October 2014 16:13:24 Arnout Vandecappelle wrote:
> > On 17/10/14 19:10, Maarten ter Huurne wrote:
> > > diff --git a/package/modplugtools/Config.in
> > > b/package/modplugtools/Config.in new file mode 100644
> > > index 0000000..53e9672
> > > --- /dev/null
> > > +++ b/package/modplugtools/Config.in
> > > @@ -0,0 +1,9 @@
> > > +config BR2_PACKAGE_MODPLUGTOOLS
> > > + bool "modplugtools"
> > > + select BR2_PACKAGE_LIBAO
> > > + select BR2_PACKAGE_LIBMODPLUG
> > > + help
> > > + This installs the 'modplug123' command line tool to play music
> files
> > > + using libmodplug.
> >
> > Small nit: I'd say "MOD files" rather than "music files". Or does it play
> > other formats as well?
>
> It plays various tracker formats. I tested it with S3M files, for example. I
> considered "tracker songs" instead of "music files", but I wasn't sure
> whether "tracker" is still a commonly understood term.
Eh! I do! :-)
Wikipedia considers them to be "module files", and are to be played with
a "music tracker":
https://en.wikipedia.org/wiki/Module_file
https://en.wikipedia.org/wiki/Music_tracker
So, "MOD files" is OK, maybe something like:
MOD files (eg. .mod, .s3m...)
> > > +MODPLUGTOOLS_DEPENDENCIES = libao libmodplug
> > > +
> > > +# Only play through libao: some platforms don't have OSS support and
> > > for those +# that do, playing through libao is still going to be
> > > sufficient. +define MODPLUGTOOLS_REMOVE_MODPLUGPLAY
> > > + rm $(TARGET_DIR)/usr/bin/modplugplay
> >
> > I don't understand this. The executable is really small, and it builds
> > correctly (otherwise you wouldn't even get this far), so why bother with
> > removing it? Someone who cares that much about their rootfs size will have
> > to remove a bunch of other stuff from the installed system anyway.
>
> It wouldn't execute correctly on target systems that don't have OSS support.
> Since OSS has been deprecated in the kernel for many years (*), my hope is
> that most embedded kernels today don't have OSS support.
>
> (*) I tried to look up how long, but it predates the move to Git in 2005.
Yeah, I wouldn't bother with OSS.
But then, be more explicit in the comment, and/or make it configurable.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-18 17:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-17 17:10 [Buildroot] [PATCH] modplugtools: Added package Maarten ter Huurne
2014-10-18 14:13 ` Arnout Vandecappelle
2014-10-18 17:19 ` Maarten ter Huurne
2014-10-18 17:44 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox