* [Buildroot] build error since a change in apply-patches.sh
@ 2013-09-16 9:34 Sagaert Johan
2013-09-16 9:51 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Sagaert Johan @ 2013-09-16 9:34 UTC (permalink / raw)
To: buildroot
Build error
........
>>> liblockfile 1.08 Extracting
gzip -d -c /home/johan/dl/liblockfile_1.08.orig.tar.gz | tar --strip-components=1 -C
/home/buildroot12git/output/build/liblockfile-1.08 -xf -
>>> liblockfile 1.08 Patching package//liblockfile
support/scripts/apply-patches.sh /home/buildroot12git/output/build/liblockfile-1.08 /home/johan/dl liblockfile_1.08-4.debian.tar.bz2
Unsupported format file for
/home/buildroot12git/output/build/liblockfile-1.08/.patches-liblockfile_1.08-4.debian.tar.bz2-unpacked/debian/changelog
make: *** [/home/buildroot12git/output/build/liblockfile-1.08/.stamp_patched] Error 1
I think something is not right in commit d245fbb41dc148a956df59658cc0dc1262612e09
( apply-patches.sh: detect missing patches)
Sagaert Johan
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] build error since a change in apply-patches.sh
2013-09-16 9:34 [Buildroot] build error since a change in apply-patches.sh Sagaert Johan
@ 2013-09-16 9:51 ` Peter Korsgaard
2013-09-16 10:40 ` Gustavo Zacarias
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2013-09-16 9:51 UTC (permalink / raw)
To: buildroot
>>>>> "Sagaert" == Sagaert Johan <sagaert.johan@skynet.be> writes:
Sagaert> Build error
Sagaert> ........
>>>> liblockfile 1.08 Extracting
Sagaert> gzip -d -c /home/johan/dl/liblockfile_1.08.orig.tar.gz | tar --strip-components=1 -C
Sagaert> /home/buildroot12git/output/build/liblockfile-1.08 -xf -
>>>> liblockfile 1.08 Patching package//liblockfile
Sagaert> support/scripts/apply-patches.sh /home/buildroot12git/output/build/liblockfile-1.08 /home/johan/dl liblockfile_1.08-4.debian.tar.bz2
Sagaert> Unsupported format file for
Sagaert> /home/buildroot12git/output/build/liblockfile-1.08/.patches-liblockfile_1.08-4.debian.tar.bz2-unpacked/debian/changelog
Sagaert> make: *** [/home/buildroot12git/output/build/liblockfile-1.08/.stamp_patched] Error 1
Sagaert> I think something is not right in commit d245fbb41dc148a956df59658cc0dc1262612e09
Sagaert> ( apply-patches.sh: detect missing patches)
Yes, I already brough this up here:
http://lists.busybox.net/pipermail/buildroot/2013-September/078292.html
I guess the best option is just to go back to warn on non-patches.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] build error since a change in apply-patches.sh
2013-09-16 9:51 ` Peter Korsgaard
@ 2013-09-16 10:40 ` Gustavo Zacarias
2013-09-16 10:48 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Gustavo Zacarias @ 2013-09-16 10:40 UTC (permalink / raw)
To: buildroot
On 09/16/2013 06:51 AM, Peter Korsgaard wrote:
> Yes, I already brough this up here:
>
> http://lists.busybox.net/pipermail/buildroot/2013-September/078292.html
>
> I guess the best option is just to go back to warn on non-patches.
Another headsup with apply-patches.sh:
There's an unintented side-effect of
5871b791995ebe295db7dca608afe3f293ce8953 too, it may apply patches that
are no longer necessary automatically via reverse (-R).
We may see unintended unfixing of things with this, i've seen it happen
to me with some yet unreleased fixes (the big automake bump).
Maybe adding a -N to patch would be in order?
Regards.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] build error since a change in apply-patches.sh
2013-09-16 10:40 ` Gustavo Zacarias
@ 2013-09-16 10:48 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2013-09-16 10:48 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
Gustavo> On 09/16/2013 06:51 AM, Peter Korsgaard wrote:
>> Yes, I already brough this up here:
>>
>> http://lists.busybox.net/pipermail/buildroot/2013-September/078292.html
>>
>> I guess the best option is just to go back to warn on non-patches.
Gustavo> Another headsup with apply-patches.sh:
Gustavo> There's an unintented side-effect of
Gustavo> 5871b791995ebe295db7dca608afe3f293ce8953 too, it may apply patches that
Gustavo> are no longer necessary automatically via reverse (-R).
Gustavo> We may see unintended unfixing of things with this, i've seen it happen
Gustavo> to me with some yet unreleased fixes (the big automake bump).
Gustavo> Maybe adding a -N to patch would be in order?
Yes, -N or -f would be good.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-09-16 10:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-16 9:34 [Buildroot] build error since a change in apply-patches.sh Sagaert Johan
2013-09-16 9:51 ` Peter Korsgaard
2013-09-16 10:40 ` Gustavo Zacarias
2013-09-16 10:48 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox