From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package: remove the trailing slash sign from the URL address
Date: Thu, 19 Sep 2013 00:48:39 +0200 [thread overview]
Message-ID: <523A2DC7.7010202@mind.be> (raw)
In-Reply-To: <CAAXf6LU8GCW7vwVvoBrSeTaongix761F=DT1Tbh=qJ_3m32CMw@mail.gmail.com>
On 18/09/13 17:34, Thomas De Schampheleire wrote:
> Hi Jerzy,
>
> Op 18-sep.-2013 17:25 schreef "Jerzy Grzegorek"
> <jerzy.grzegorek at trzebnica.net <mailto:jerzy.grzegorek@trzebnica.net>>
> het volgende:
> >
> > Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net
> <mailto:jerzy.grzegorek@trzebnica.net>>
> > ---
>
> Could you clarify why this is desirable? Note that urls with our without
> trailing slash are not identical: the web server needs to properly
> support this. For example, the autobuild website does not properly do it
> (something very annoying ;) )
>
> So, with a change like this, every changed url needs to be tested.
Well, with the trailing slash is stripped by pkg-generic.mk:
$(call DOWNLOAD,$($(PKG)_SITE:/=)/$($(PKG)_SOURCE))
So functionally it doesn't matter if the / is there or not.
I'm pretty much in favour of removing the /.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2013-09-18 22:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 15:24 [Buildroot] [PATCH 1/1] package: remove the trailing slash sign from the URL address Jerzy Grzegorek
2013-09-18 15:34 ` Thomas De Schampheleire
2013-09-18 15:44 ` Jerzy Grzegorek
2013-09-18 17:56 ` Michael Rommel
2013-09-18 20:48 ` Jerzy Grzegorek
2013-09-18 22:31 ` Michael Rommel
2013-09-18 16:51 ` Thomas Petazzoni
2013-09-19 7:06 ` Thomas De Schampheleire
2013-09-19 19:43 ` Thomas Petazzoni
2013-09-18 22:48 ` Arnout Vandecappelle [this message]
2013-09-19 13:56 ` Michael Rommel
2013-09-20 6:23 ` Jerzy Grzegorek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523A2DC7.7010202@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox