[Buildroot] [PATCH V3 0/2] i.MX updates

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH V3 0/2] i.MX updates
@ 2013-10-06 19:47 Eric Nelson
  2013-10-06 19:47 ` [Buildroot] [PATCH 1/2] i.MX: Use FREESCALE_IMX_SITE for Freescale packages Eric Nelson
  2013-10-06 19:47 ` [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release Eric Nelson
  0 siblings, 2 replies; 7+ messages in thread
From: Eric Nelson @ 2013-10-06 19:47 UTC (permalink / raw)
  To: buildroot

This patch series updates Freescale packages for i.MX processors
to use the Freescale MAD/YOCTO repository and updates the versions
to match the latest release.

V2 skipped moving libfslx packages into packages/freescale-imx
V3 incorporates gstreamer plugin patch from
	http://patchwork.ozlabs.org/patch/279625/
   and re-works the patch into two steps as suggested by 
   Thomas Petazzoni:
	- rename and use FREESCALE_IMX_SITE
	- bump revisions and change site to freescale.com

Eric Nelson (2):
  i.MX: Use FREESCALE_IMX_SITE for Freescale packages
  i.MX: Update versions to match latest Freescale release

 package/freescale-imx/firmware-imx/firmware-imx.mk |  2 +-
 package/freescale-imx/freescale-imx.mk             |  6 ++----
 .../gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk           |  8 ++++++--
 package/freescale-imx/imx-lib/imx-lib.mk           | 18 ++++++++++++++---
 .../gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk   |  5 ++---
 package/libfslcodec/libfslcodec.mk                 |  5 ++---
 package/libfslparser/libfslparser.mk               |  7 ++++---
 package/libfslvpuwrap/libfslvpuwrap.mk             | 23 +++++++++++++++++++---
 8 files changed, 52 insertions(+), 22 deletions(-)

-- 
1.8.1.2

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/2] i.MX: Use FREESCALE_IMX_SITE for Freescale packages
  2013-10-06 19:47 [Buildroot] [PATCH V3 0/2] i.MX updates Eric Nelson
@ 2013-10-06 19:47 ` Eric Nelson
  2013-10-06 21:26   ` Thomas Petazzoni
  2013-10-06 19:47 ` [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release Eric Nelson
  1 sibling, 1 reply; 7+ messages in thread
From: Eric Nelson @ 2013-10-06 19:47 UTC (permalink / raw)
  To: buildroot

This patch consolidates the URLs for various Freescale-supplied
packages to use FREESCALE_IMX_SITE.

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 package/freescale-imx/firmware-imx/firmware-imx.mk         | 2 +-
 package/freescale-imx/freescale-imx.mk                     | 2 +-
 package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk | 2 +-
 package/freescale-imx/imx-lib/imx-lib.mk                   | 2 +-
 package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk       | 3 +--
 package/libfslcodec/libfslcodec.mk                         | 3 +--
 package/libfslparser/libfslparser.mk                       | 3 +--
 package/libfslvpuwrap/libfslvpuwrap.mk                     | 3 +--
 8 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/package/freescale-imx/firmware-imx/firmware-imx.mk b/package/freescale-imx/firmware-imx/firmware-imx.mk
index d9fcb89..d26b31c 100644
--- a/package/freescale-imx/firmware-imx/firmware-imx.mk
+++ b/package/freescale-imx/firmware-imx/firmware-imx.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 FIRMWARE_IMX_VERSION = $(FREESCALE_IMX_VERSION)
-FIRMWARE_IMX_SITE = $(FREESCALE_IMX_MIRROR_SITE)
+FIRMWARE_IMX_SITE = $(FREESCALE_IMX_SITE)
 FIRMWARE_IMX_SOURCE = firmware-imx-$(FIRMWARE_IMX_VERSION).bin
 FIRMWARE_IMX_LICENSE = Freescale Semiconductor Software License Agreement, \
 	Atheros license (ath6k)
diff --git a/package/freescale-imx/freescale-imx.mk b/package/freescale-imx/freescale-imx.mk
index d35a62e..0dd5629 100644
--- a/package/freescale-imx/freescale-imx.mk
+++ b/package/freescale-imx/freescale-imx.mk
@@ -7,6 +7,6 @@
 FREESCALE_IMX_VERSION = 1.1.0
 
 # No official download site from freescale, just this mirror
-FREESCALE_IMX_MIRROR_SITE   = http://download.ossystems.com.br/bsp/freescale/source
+FREESCALE_IMX_SITE   = http://download.ossystems.com.br/bsp/freescale/source
 
 include $(sort $(wildcard package/freescale-imx/*/*.mk))
diff --git a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
index c48d108..8e979ee 100644
--- a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
+++ b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 GPU_VIV_BIN_MX6Q_VERSION = $(FREESCALE_IMX_VERSION)
-GPU_VIV_BIN_MX6Q_SITE    = $(FREESCALE_IMX_MIRROR_SITE)
+GPU_VIV_BIN_MX6Q_SITE    = $(FREESCALE_IMX_SITE)
 GPU_VIV_BIN_MX6Q_SOURCE  = gpu-viv-bin-mx6q-$(GPU_VIV_BIN_MX6Q_VERSION).bin
 
 GPU_VIV_BIN_MX6Q_INSTALL_STAGING = YES
diff --git a/package/freescale-imx/imx-lib/imx-lib.mk b/package/freescale-imx/imx-lib/imx-lib.mk
index bd7e174..e1a68ef 100644
--- a/package/freescale-imx/imx-lib/imx-lib.mk
+++ b/package/freescale-imx/imx-lib/imx-lib.mk
@@ -5,7 +5,7 @@
 ################################################################################
 
 IMX_LIB_VERSION = $(FREESCALE_IMX_VERSION)
-IMX_LIB_SITE    = $(FREESCALE_IMX_MIRROR_SITE)
+IMX_LIB_SITE    = $(FREESCALE_IMX_SITE)
 IMX_LIB_LICENSE = LGPLv2.1+
 # No license file included
 
diff --git a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
index ccdb521..4437875 100644
--- a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
+++ b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
@@ -5,8 +5,7 @@
 ################################################################################
 
 GST_FSL_PLUGINS_VERSION = 3.0.1
-# No official download site from freescale, just this mirror
-GST_FSL_PLUGINS_SITE = http://download.ossystems.com.br/bsp/freescale/source
+GST_FSL_PLUGINS_SITE = $(FREESCALE_IMX_SITE)
 
 # Most is LGPLv2+, but some sources are copied from upstream and are
 # LGPLv2.1+, which essentially makes it LGPLv2.1+
diff --git a/package/libfslcodec/libfslcodec.mk b/package/libfslcodec/libfslcodec.mk
index c18332a..ad1cc63 100644
--- a/package/libfslcodec/libfslcodec.mk
+++ b/package/libfslcodec/libfslcodec.mk
@@ -5,8 +5,7 @@
 ################################################################################
 
 LIBFSLCODEC_VERSION = 3.0.1
-# No official download site from freescale, just this mirror
-LIBFSLCODEC_SITE = http://download.ossystems.com.br/bsp/freescale/source
+LIBFSLCODEC_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLCODEC_SOURCE = libfslcodec-$(LIBFSLCODEC_VERSION).bin
 LIBFSLCODEC_LICENSE = Freescale Semiconductor Software License Agreement, BSD-3c (flac, ogg headers)
 LIBFSLCODEC_LICENSE_FILES = EULA EULA.txt
diff --git a/package/libfslparser/libfslparser.mk b/package/libfslparser/libfslparser.mk
index 3e27a6a..3aab3a7 100644
--- a/package/libfslparser/libfslparser.mk
+++ b/package/libfslparser/libfslparser.mk
@@ -5,8 +5,7 @@
 ################################################################################
 
 LIBFSLPARSER_VERSION = 3.0.1
-# No official download site from freescale, just this mirror
-LIBFSLPARSER_SITE = http://download.ossystems.com.br/bsp/freescale/source
+LIBFSLPARSER_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLPARSER_SOURCE = libfslparser-$(LIBFSLPARSER_VERSION).bin
 LIBFSLPARSER_LICENSE = Freescale Semiconductor Software License Agreement
 LIBFSLPARSER_LICENSE_FILES = EULA EULA.txt
diff --git a/package/libfslvpuwrap/libfslvpuwrap.mk b/package/libfslvpuwrap/libfslvpuwrap.mk
index 1bc7129..346a20a 100644
--- a/package/libfslvpuwrap/libfslvpuwrap.mk
+++ b/package/libfslvpuwrap/libfslvpuwrap.mk
@@ -5,8 +5,7 @@
 ################################################################################
 
 LIBFSLVPUWRAP_VERSION = 1.0.17
-# No official download site from freescale, just this mirror
-LIBFSLVPUWRAP_SITE = http://download.ossystems.com.br/bsp/freescale/source
+LIBFSLVPUWRAP_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLVPUWRAP_LICENSE = Freescale Semiconductor Software License Agreement
 LIBFSLVPUWRAP_LICENSE_FILES = EULA.txt
 LIBFSLVPUWRAP_REDISTRIBUTE = NO
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 1/2] i.MX: Use FREESCALE_IMX_SITE for Freescale packages
  2013-10-06 19:47 ` [Buildroot] [PATCH 1/2] i.MX: Use FREESCALE_IMX_SITE for Freescale packages Eric Nelson
@ 2013-10-06 21:26   ` Thomas Petazzoni
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2013-10-06 21:26 UTC (permalink / raw)
  To: buildroot

Dear Eric Nelson,

On Sun,  6 Oct 2013 12:47:47 -0700, Eric Nelson wrote:
> This patch consolidates the URLs for various Freescale-supplied
> packages to use FREESCALE_IMX_SITE.
> 
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  package/freescale-imx/firmware-imx/firmware-imx.mk         | 2 +-
>  package/freescale-imx/freescale-imx.mk                     | 2 +-
>  package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk | 2 +-
>  package/freescale-imx/imx-lib/imx-lib.mk                   | 2 +-
>  package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk       | 3 +--
>  package/libfslcodec/libfslcodec.mk                         | 3 +--
>  package/libfslparser/libfslparser.mk                       | 3 +--
>  package/libfslvpuwrap/libfslvpuwrap.mk                     | 3 +--
>  8 files changed, 8 insertions(+), 12 deletions(-)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release
  2013-10-06 19:47 [Buildroot] [PATCH V3 0/2] i.MX updates Eric Nelson
  2013-10-06 19:47 ` [Buildroot] [PATCH 1/2] i.MX: Use FREESCALE_IMX_SITE for Freescale packages Eric Nelson
@ 2013-10-06 19:47 ` Eric Nelson
  2013-10-06 21:27   ` Thomas Petazzoni
  2013-10-07 22:31   ` Arnout Vandecappelle
  1 sibling, 2 replies; 7+ messages in thread
From: Eric Nelson @ 2013-10-06 19:47 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
---
 package/freescale-imx/freescale-imx.mk               |  6 ++----
 .../gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk             |  6 +++++-
 package/freescale-imx/imx-lib/imx-lib.mk             | 16 ++++++++++++++--
 package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk |  2 +-
 package/libfslcodec/libfslcodec.mk                   |  2 +-
 package/libfslparser/libfslparser.mk                 |  4 +++-
 package/libfslvpuwrap/libfslvpuwrap.mk               | 20 +++++++++++++++++++-
 7 files changed, 45 insertions(+), 11 deletions(-)

diff --git a/package/freescale-imx/freescale-imx.mk b/package/freescale-imx/freescale-imx.mk
index 0dd5629..39ffa8a 100644
--- a/package/freescale-imx/freescale-imx.mk
+++ b/package/freescale-imx/freescale-imx.mk
@@ -4,9 +4,7 @@
 #
 ################################################################################
 
-FREESCALE_IMX_VERSION = 1.1.0
-
-# No official download site from freescale, just this mirror
-FREESCALE_IMX_SITE   = http://download.ossystems.com.br/bsp/freescale/source
+FREESCALE_IMX_VERSION = 3.5.7-1.0.0
+FREESCALE_IMX_SITE    = http://www.freescale.com/lgfiles/NMG/MAD/YOCTO/
 
 include $(sort $(wildcard package/freescale-imx/*/*.mk))
diff --git a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
index 8e979ee..e799fd2 100644
--- a/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
+++ b/package/freescale-imx/gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk
@@ -4,7 +4,11 @@
 #
 ################################################################################
 
-GPU_VIV_BIN_MX6Q_VERSION = $(FREESCALE_IMX_VERSION)
+ifeq ($(BR2_ARM_EABIHF),y)
+GPU_VIV_BIN_MX6Q_VERSION = $(FREESCALE_IMX_VERSION)-hfp
+else
+GPU_VIV_BIN_MX6Q_VERSION = $(FREESCALE_IMX_VERSION)-sfp
+endif
 GPU_VIV_BIN_MX6Q_SITE    = $(FREESCALE_IMX_SITE)
 GPU_VIV_BIN_MX6Q_SOURCE  = gpu-viv-bin-mx6q-$(GPU_VIV_BIN_MX6Q_VERSION).bin
 
diff --git a/package/freescale-imx/imx-lib/imx-lib.mk b/package/freescale-imx/imx-lib/imx-lib.mk
index e1a68ef..416bb1b 100644
--- a/package/freescale-imx/imx-lib/imx-lib.mk
+++ b/package/freescale-imx/imx-lib/imx-lib.mk
@@ -6,8 +6,8 @@
 
 IMX_LIB_VERSION = $(FREESCALE_IMX_VERSION)
 IMX_LIB_SITE    = $(FREESCALE_IMX_SITE)
-IMX_LIB_LICENSE = LGPLv2.1+
-# No license file included
+IMX_LIB_LICENSE = Freescale Semiconductor Software License Agreement
+IMX_LIB_SOURCE = imx-lib-$(IMX_LIB_VERSION).bin
 
 IMX_LIB_INSTALL_STAGING = YES
 
@@ -25,6 +25,18 @@ IMX_LIB_MAKE_ENV = \
 	PLATFORM=$(BR2_PACKAGE_IMX_LIB_PLATFORM) \
 	INCLUDE="$(IMX_LIB_INCLUDE)"
 
+# The archive is a shell-self-extractor of a bzipped tar. It happens
+# to extract in the correct directory (imx-lib-x.y.z)
+# The --force makes sure it doesn't fail if the source dir already exists.
+# The --auto-accept skips the license check - not needed for us
+# because we have legal-info
+# Since the EULA in the bin file differs from the one in the tar file,
+# extract the one from the bin file as well.
+define IMX_LIB_EXTRACT_CMDS
+	(cd $(BUILD_DIR); \
+		sh $(DL_DIR)/$(IMX_LIB_SOURCE) --force --auto-accept)
+endef
+
 define IMX_LIB_BUILD_CMDS
 	$(IMX_LIB_MAKE_ENV) $(MAKE1) -C $(@D)
 endef
diff --git a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
index 4437875..9ec92d8 100644
--- a/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
+++ b/package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-GST_FSL_PLUGINS_VERSION = 3.0.1
+GST_FSL_PLUGINS_VERSION = $(FREESCALE_IMX_VERSION)
 GST_FSL_PLUGINS_SITE = $(FREESCALE_IMX_SITE)
 
 # Most is LGPLv2+, but some sources are copied from upstream and are
diff --git a/package/libfslcodec/libfslcodec.mk b/package/libfslcodec/libfslcodec.mk
index ad1cc63..d52158c 100644
--- a/package/libfslcodec/libfslcodec.mk
+++ b/package/libfslcodec/libfslcodec.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBFSLCODEC_VERSION = 3.0.1
+LIBFSLCODEC_VERSION = $(FREESCALE_IMX_VERSION)
 LIBFSLCODEC_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLCODEC_SOURCE = libfslcodec-$(LIBFSLCODEC_VERSION).bin
 LIBFSLCODEC_LICENSE = Freescale Semiconductor Software License Agreement, BSD-3c (flac, ogg headers)
diff --git a/package/libfslparser/libfslparser.mk b/package/libfslparser/libfslparser.mk
index 3aab3a7..1aa975b 100644
--- a/package/libfslparser/libfslparser.mk
+++ b/package/libfslparser/libfslparser.mk
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-LIBFSLPARSER_VERSION = 3.0.1
+LIBFSLPARSER_VERSION = $(FREESCALE_IMX_VERSION)
 LIBFSLPARSER_SITE = $(FREESCALE_IMX_SITE)
 LIBFSLPARSER_SOURCE = libfslparser-$(LIBFSLPARSER_VERSION).bin
 LIBFSLPARSER_LICENSE = Freescale Semiconductor Software License Agreement
@@ -36,4 +36,6 @@ endef
 # The Makefile installs several versions of the libraries, but we only
 # need one of them, depending on the platform.
 
+LIBFSLPARSER_AUTORECONF = YES
+
 $(eval $(autotools-package))
diff --git a/package/libfslvpuwrap/libfslvpuwrap.mk b/package/libfslvpuwrap/libfslvpuwrap.mk
index 346a20a..45193c4 100644
--- a/package/libfslvpuwrap/libfslvpuwrap.mk
+++ b/package/libfslvpuwrap/libfslvpuwrap.mk
@@ -4,8 +4,9 @@
 #
 ################################################################################
 
-LIBFSLVPUWRAP_VERSION = 1.0.17
+LIBFSLVPUWRAP_VERSION = $(FREESCALE_IMX_VERSION)
 LIBFSLVPUWRAP_SITE = $(FREESCALE_IMX_SITE)
+LIBFSLVPUWRAP_SOURCE = libfslvpuwrap-$(LIBFSLVPUWRAP_VERSION).bin
 LIBFSLVPUWRAP_LICENSE = Freescale Semiconductor Software License Agreement
 LIBFSLVPUWRAP_LICENSE_FILES = EULA.txt
 LIBFSLVPUWRAP_REDISTRIBUTE = NO
@@ -14,4 +15,21 @@ LIBFSLVPUWRAP_INSTALL_STAGING = YES
 
 LIBFSLVPUWRAP_DEPENDENCIES += imx-lib
 
+# The archive is a shell-self-extractor of a bzipped tar. It happens
+# to extract in the correct directory (libfslvpuwrap-x.y.z)
+# The --force makes sure it doesn't fail if the source dir already exists.
+# The --auto-accept skips the license check - not needed for us
+# because we have legal-info
+# Since the EULA in the bin file differs from the one in the tar file,
+# extract the one from the bin file as well.
+define LIBFSLVPUWRAP_EXTRACT_CMDS
+	awk 'BEGIN      { start=0; } \
+	     /^EOEULA/  { start = 0; } \
+	                { if (start) print; } \
+	     /<<EOEULA/ { start=1; }'\
+	    $(DL_DIR)/$(LIBFSLVPUWRAP_SOURCE) > $(@D)/EULA
+	cd $(BUILD_DIR); \
+	sh $(DL_DIR)/$(LIBFSLVPUWRAP_SOURCE) --force --auto-accept
+endef
+
 $(eval $(autotools-package))
-- 
1.8.1.2

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release
  2013-10-06 19:47 ` [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release Eric Nelson
@ 2013-10-06 21:27   ` Thomas Petazzoni
  2013-10-07 22:31   ` Arnout Vandecappelle
  1 sibling, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2013-10-06 21:27 UTC (permalink / raw)
  To: buildroot

Dear Eric Nelson,

On Sun,  6 Oct 2013 12:47:48 -0700, Eric Nelson wrote:
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>  package/freescale-imx/freescale-imx.mk               |  6 ++----
>  .../gpu-viv-bin-mx6q/gpu-viv-bin-mx6q.mk             |  6 +++++-
>  package/freescale-imx/imx-lib/imx-lib.mk             | 16 ++++++++++++++--
>  package/gstreamer/gst-fsl-plugins/gst-fsl-plugins.mk |  2 +-
>  package/libfslcodec/libfslcodec.mk                   |  2 +-
>  package/libfslparser/libfslparser.mk                 |  4 +++-
>  package/libfslvpuwrap/libfslvpuwrap.mk               | 20 +++++++++++++++++++-
>  7 files changed, 45 insertions(+), 11 deletions(-)

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release
  2013-10-06 19:47 ` [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release Eric Nelson
  2013-10-06 21:27   ` Thomas Petazzoni
@ 2013-10-07 22:31   ` Arnout Vandecappelle
  2013-10-07 22:55     ` Eric Nelson
  1 sibling, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2013-10-07 22:31 UTC (permalink / raw)
  To: buildroot

On 10/06/13 21:47, Eric Nelson wrote:
[snip]
> diff --git a/package/freescale-imx/imx-lib/imx-lib.mk b/package/freescale-imx/imx-lib/imx-lib.mk
> index e1a68ef..416bb1b 100644
> --- a/package/freescale-imx/imx-lib/imx-lib.mk
> +++ b/package/freescale-imx/imx-lib/imx-lib.mk
> @@ -6,8 +6,8 @@
>   
>   IMX_LIB_VERSION = $(FREESCALE_IMX_VERSION)
>   IMX_LIB_SITE    = $(FREESCALE_IMX_SITE)
> -IMX_LIB_LICENSE = LGPLv2.1+
> -# No license file included
> +IMX_LIB_LICENSE = Freescale Semiconductor Software License Agreement

 Most of it is still LGPLv2.1+, only the vpu library is FSSLA. So I think
it should be:

IMX_LIB_LICENSE = Freescale Semiconductor Software License Agreement (vpu), LGPLv2.1+ (the rest)

> +IMX_LIB_SOURCE = imx-lib-$(IMX_LIB_VERSION).bin
>   
>   IMX_LIB_INSTALL_STAGING = YES
>   
> @@ -25,6 +25,18 @@ IMX_LIB_MAKE_ENV = \
>   	PLATFORM=$(BR2_PACKAGE_IMX_LIB_PLATFORM) \
>   	INCLUDE="$(IMX_LIB_INCLUDE)"
>   
> +# The archive is a shell-self-extractor of a bzipped tar. It happens
> +# to extract in the correct directory (imx-lib-x.y.z)
> +# The --force makes sure it doesn't fail if the source dir already exists.
> +# The --auto-accept skips the license check - not needed for us
> +# because we have legal-info
> +# Since the EULA in the bin file differs from the one in the tar file,
> +# extract the one from the bin file as well.

 This comment doesn't seem to be correct.

 Can you add the awk trick to extract the license file, and add an 
IMX_LIB_LICENSE_FILES variable?

> +define IMX_LIB_EXTRACT_CMDS
> +	(cd $(BUILD_DIR); \
> +		sh $(DL_DIR)/$(IMX_LIB_SOURCE) --force --auto-accept)
> +endef
> +
>   define IMX_LIB_BUILD_CMDS
>   	$(IMX_LIB_MAKE_ENV) $(MAKE1) -C $(@D)
>   endef

[snip]
> diff --git a/package/libfslparser/libfslparser.mk b/package/libfslparser/libfslparser.mk
> index 3aab3a7..1aa975b 100644
> --- a/package/libfslparser/libfslparser.mk
> +++ b/package/libfslparser/libfslparser.mk
> @@ -4,7 +4,7 @@
>   #
>   ################################################################################
>   
> -LIBFSLPARSER_VERSION = 3.0.1
> +LIBFSLPARSER_VERSION = $(FREESCALE_IMX_VERSION)
>   LIBFSLPARSER_SITE = $(FREESCALE_IMX_SITE)
>   LIBFSLPARSER_SOURCE = libfslparser-$(LIBFSLPARSER_VERSION).bin
>   LIBFSLPARSER_LICENSE = Freescale Semiconductor Software License Agreement
> @@ -36,4 +36,6 @@ endef
>   # The Makefile installs several versions of the libraries, but we only
>   # need one of them, depending on the platform.
>   
> +LIBFSLPARSER_AUTORECONF = YES

 Please add a comment why autoreconf is needed.

> +
>   $(eval $(autotools-package))
> diff --git a/package/libfslvpuwrap/libfslvpuwrap.mk b/package/libfslvpuwrap/libfslvpuwrap.mk
> index 346a20a..45193c4 100644
> --- a/package/libfslvpuwrap/libfslvpuwrap.mk
> +++ b/package/libfslvpuwrap/libfslvpuwrap.mk
> @@ -4,8 +4,9 @@
>   #
>   ################################################################################
>   
> -LIBFSLVPUWRAP_VERSION = 1.0.17
> +LIBFSLVPUWRAP_VERSION = $(FREESCALE_IMX_VERSION)
>   LIBFSLVPUWRAP_SITE = $(FREESCALE_IMX_SITE)
> +LIBFSLVPUWRAP_SOURCE = libfslvpuwrap-$(LIBFSLVPUWRAP_VERSION).bin
>   LIBFSLVPUWRAP_LICENSE = Freescale Semiconductor Software License Agreement
>   LIBFSLVPUWRAP_LICENSE_FILES = EULA.txt
>   LIBFSLVPUWRAP_REDISTRIBUTE = NO
> @@ -14,4 +15,21 @@ LIBFSLVPUWRAP_INSTALL_STAGING = YES
>   
>   LIBFSLVPUWRAP_DEPENDENCIES += imx-lib
>   
> +# The archive is a shell-self-extractor of a bzipped tar. It happens
> +# to extract in the correct directory (libfslvpuwrap-x.y.z)
> +# The --force makes sure it doesn't fail if the source dir already exists.
> +# The --auto-accept skips the license check - not needed for us
> +# because we have legal-info
> +# Since the EULA in the bin file differs from the one in the tar file,
> +# extract the one from the bin file as well.
> +define LIBFSLVPUWRAP_EXTRACT_CMDS
> +	awk 'BEGIN      { start=0; } \
> +	     /^EOEULA/  { start = 0; } \
> +	                { if (start) print; } \
> +	     /<<EOEULA/ { start=1; }'\
> +	    $(DL_DIR)/$(LIBFSLVPUWRAP_SOURCE) > $(@D)/EULA

 You should add this to LIBFSLVPUWRAP_LICENSE_FILES.


 Regards,
 Arnout

> +	cd $(BUILD_DIR); \
> +	sh $(DL_DIR)/$(LIBFSLVPUWRAP_SOURCE) --force --auto-accept
> +endef
> +
>   $(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release
  2013-10-07 22:31   ` Arnout Vandecappelle
@ 2013-10-07 22:55     ` Eric Nelson
  0 siblings, 0 replies; 7+ messages in thread
From: Eric Nelson @ 2013-10-07 22:55 UTC (permalink / raw)
  To: buildroot

Thanks for the review, Arnout,

On 10/07/2013 03:31 PM, Arnout Vandecappelle wrote:
> On 10/06/13 21:47, Eric Nelson wrote:
> [snip]
>> diff --git a/package/freescale-imx/imx-lib/imx-lib.mk b/package/freescale-imx/imx-lib/imx-lib.mk
>> index e1a68ef..416bb1b 100644
>> --- a/package/freescale-imx/imx-lib/imx-lib.mk
>> +++ b/package/freescale-imx/imx-lib/imx-lib.mk
>> @@ -6,8 +6,8 @@
>>
>>    IMX_LIB_VERSION = $(FREESCALE_IMX_VERSION)
>>    IMX_LIB_SITE    = $(FREESCALE_IMX_SITE)
>> -IMX_LIB_LICENSE = LGPLv2.1+
>> -# No license file included
>> +IMX_LIB_LICENSE = Freescale Semiconductor Software License Agreement
>
>   Most of it is still LGPLv2.1+, only the vpu library is FSSLA. So I think
> it should be:
>
> IMX_LIB_LICENSE = Freescale Semiconductor Software License Agreement (vpu), LGPLv2.1+ (the rest)
>

Thanks.

>> +IMX_LIB_SOURCE = imx-lib-$(IMX_LIB_VERSION).bin
>>
>>    IMX_LIB_INSTALL_STAGING = YES
>>
>> @@ -25,6 +25,18 @@ IMX_LIB_MAKE_ENV = \
>>    	PLATFORM=$(BR2_PACKAGE_IMX_LIB_PLATFORM) \
>>    	INCLUDE="$(IMX_LIB_INCLUDE)"
>>
>> +# The archive is a shell-self-extractor of a bzipped tar. It happens
>> +# to extract in the correct directory (imx-lib-x.y.z)
>> +# The --force makes sure it doesn't fail if the source dir already exists.
>> +# The --auto-accept skips the license check - not needed for us
>> +# because we have legal-info
>> +# Since the EULA in the bin file differs from the one in the tar file,
>> +# extract the one from the bin file as well.
>
>   This comment doesn't seem to be correct.
>
>   Can you add the awk trick to extract the license file, and add an
> IMX_LIB_LICENSE_FILES variable?
>

Will do.

> [snip]

>>    LIBFSLPARSER_LICENSE = Freescale Semiconductor Software License Agreement
>> @@ -36,4 +36,6 @@ endef
>>    # The Makefile installs several versions of the libraries, but we only
>>    # need one of them, depending on the platform.
>>
>> +LIBFSLPARSER_AUTORECONF = YES
>
>   Please add a comment why autoreconf is needed.
>

I'm not sure I know why...

Does it suffice to say that without 'autoreconf', the configure
step fails with message "unable to create executables"?

I originally copied the process from LTIB and executed 'autogen.sh'
by hand. Then Peter pointed out the _AUTORECONF flag.

 > <snip>
>> +define LIBFSLVPUWRAP_EXTRACT_CMDS
>> +	awk 'BEGIN      { start=0; } \
>> +	     /^EOEULA/  { start = 0; } \
>> +	                { if (start) print; } \
>> +	     /<<EOEULA/ { start=1; }'\
>> +	    $(DL_DIR)/$(LIBFSLVPUWRAP_SOURCE) > $(@D)/EULA
>
>   You should add this to LIBFSLVPUWRAP_LICENSE_FILES.
>

Can do.

Regards,


Eric

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2013-10-07 22:55 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-06 19:47 [Buildroot] [PATCH V3 0/2] i.MX updates Eric Nelson
2013-10-06 19:47 ` [Buildroot] [PATCH 1/2] i.MX: Use FREESCALE_IMX_SITE for Freescale packages Eric Nelson
2013-10-06 21:26   ` Thomas Petazzoni
2013-10-06 19:47 ` [Buildroot] [PATCH 2/2] i.MX: Update versions to match latest Freescale release Eric Nelson
2013-10-06 21:27   ` Thomas Petazzoni
2013-10-07 22:31   ` Arnout Vandecappelle
2013-10-07 22:55     ` Eric Nelson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox