Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6
@ 2013-10-07 21:02 Gustavo Zacarias
  2013-10-08  8:21 ` Markos Chandras
  2013-10-08 14:55 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Gustavo Zacarias @ 2013-10-07 21:02 UTC (permalink / raw)
  To: buildroot

Reported in https://bugs.gentoo.org/show_bug.cgi?id=486426
and http://redmine.lighttpd.net/issues/2515
Autobuilders didn't hit it yet, but i did.

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 ...ile.patch => lighttpd-01-Fix-default-config-file.patch} |  0
 package/lighttpd/lighttpd-02-mod_extforward.patch          | 14 ++++++++++++++
 2 files changed, 14 insertions(+)
 rename package/lighttpd/{lighttpd-Fix-default-config-file.patch => lighttpd-01-Fix-default-config-file.patch} (100%)
 create mode 100644 package/lighttpd/lighttpd-02-mod_extforward.patch

diff --git a/package/lighttpd/lighttpd-Fix-default-config-file.patch b/package/lighttpd/lighttpd-01-Fix-default-config-file.patch
similarity index 100%
rename from package/lighttpd/lighttpd-Fix-default-config-file.patch
rename to package/lighttpd/lighttpd-01-Fix-default-config-file.patch
diff --git a/package/lighttpd/lighttpd-02-mod_extforward.patch b/package/lighttpd/lighttpd-02-mod_extforward.patch
new file mode 100644
index 0000000..3efd2b1
--- /dev/null
+++ b/package/lighttpd/lighttpd-02-mod_extforward.patch
@@ -0,0 +1,14 @@
+From http://redmine.lighttpd.net/issues/2515
+
+Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
+
+--- a/src/mod_extforward.c	(revision 2909)
++++ b/src/mod_extforward.c	(working copy)
+@@ -439,7 +439,6 @@
+ #ifdef HAVE_IPV6
+ 		ipstr_to_sockaddr(srv, real_remote_addr, &sock);
+ #else
+-		UNUSED(addrs_left);
+ 		sock.ipv4.sin_addr.s_addr = inet_addr(real_remote_addr);
+ 		sock.plain.sa_family = (sock.ipv4.sin_addr.s_addr == 0xFFFFFFFF) ? AF_UNSPEC : AF_INET;
+ #endif
-- 
1.8.1.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6
  2013-10-07 21:02 [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6 Gustavo Zacarias
@ 2013-10-08  8:21 ` Markos Chandras
  2013-10-08 14:55 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2013-10-08  8:21 UTC (permalink / raw)
  To: buildroot

On 10/07/13 22:02, Gustavo Zacarias wrote:
> Reported in https://bugs.gentoo.org/show_bug.cgi?id=486426
> and http://redmine.lighttpd.net/issues/2515
> Autobuilders didn't hit it yet, but i did.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
>   ...ile.patch => lighttpd-01-Fix-default-config-file.patch} |  0
>   package/lighttpd/lighttpd-02-mod_extforward.patch          | 14 ++++++++++++++
>   2 files changed, 14 insertions(+)
>   rename package/lighttpd/{lighttpd-Fix-default-config-file.patch => lighttpd-01-Fix-default-config-file.patch} (100%)
>   create mode 100644 package/lighttpd/lighttpd-02-mod_extforward.patch
>
> diff --git a/package/lighttpd/lighttpd-Fix-default-config-file.patch b/package/lighttpd/lighttpd-01-Fix-default-config-file.patch
> similarity index 100%
> rename from package/lighttpd/lighttpd-Fix-default-config-file.patch
> rename to package/lighttpd/lighttpd-01-Fix-default-config-file.patch
> diff --git a/package/lighttpd/lighttpd-02-mod_extforward.patch b/package/lighttpd/lighttpd-02-mod_extforward.patch
> new file mode 100644
> index 0000000..3efd2b1
> --- /dev/null
> +++ b/package/lighttpd/lighttpd-02-mod_extforward.patch
> @@ -0,0 +1,14 @@
> +From http://redmine.lighttpd.net/issues/2515
> +
> +Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> +
> +--- a/src/mod_extforward.c	(revision 2909)
> ++++ b/src/mod_extforward.c	(working copy)
> +@@ -439,7 +439,6 @@
> + #ifdef HAVE_IPV6
> + 		ipstr_to_sockaddr(srv, real_remote_addr, &sock);
> + #else
> +-		UNUSED(addrs_left);
> + 		sock.ipv4.sin_addr.s_addr = inet_addr(real_remote_addr);
> + 		sock.plain.sa_family = (sock.ipv4.sin_addr.s_addr == 0xFFFFFFFF) ? AF_UNSPEC : AF_INET;
> + #endif
>

oh this is rather embarrasing. I am taking care of the Gentoo bug myself 
:/ I assumed the ipv6 is disabled by default since i didn't see it in 
the lighttpd.mk makefile but reading the configure.ac it appears to 
always be enabled :( Sorry about that.

Thanks for the patch!

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6
  2013-10-07 21:02 [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6 Gustavo Zacarias
  2013-10-08  8:21 ` Markos Chandras
@ 2013-10-08 14:55 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2013-10-08 14:55 UTC (permalink / raw)
  To: buildroot

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 Gustavo> Reported in https://bugs.gentoo.org/show_bug.cgi?id=486426
 Gustavo> and http://redmine.lighttpd.net/issues/2515
 Gustavo> Autobuilders didn't hit it yet, but i did.

 Gustavo> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-10-08 14:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-07 21:02 [Buildroot] [PATCHv2] lighttpd: fix build failure without ipv6 Gustavo Zacarias
2013-10-08  8:21 ` Markos Chandras
2013-10-08 14:55 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox