* [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS
@ 2013-10-27 23:16 Romain Naour
2013-10-29 17:05 ` Arnout Vandecappelle
2013-10-30 21:45 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Romain Naour @ 2013-10-27 23:16 UTC (permalink / raw)
To: buildroot
Ptrace support detection is ignored when CFLAGS is set by buildroot.
Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
if ptrace is not available.
Fixes:
http://autobuild.buildroot.net/results/60e/60ed317d52d93ba2c087aa6ff4f422d760806d89//
Signed-off-by: Romain <romain.naour@openwide.fr>
---
.../trace-cmd-0002-Makefile-overwrite-CFLAGS.patch | 33
++++++++++++++++++++++
1 file changed, 33 insertions(+)
create mode 100644
package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
diff --git
a/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
b/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
new file mode 100644
index 0000000..f4afa53
--- /dev/null
+++ b/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
@@ -0,0 +1,33 @@
+
+Ptrace support detection is ignored when CFLAGS is set in command
arguments.
+
+Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
+if ptrace is not available.
+
+Signed-off-by: Romain <romain.naour@openwide.fr>
+---
+ Makefile | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/Makefile b/Makefile
+index 2f862ec..51b0df3 100644
+--- a/Makefile
++++ b/Makefile
+@@ -229,12 +229,12 @@ CFLAGS += -D_GNU_SOURCE
+ ifndef NO_PTRACE
+ ifneq ($(call try-cc,$(SOURCE_PTRACE),),y)
+ NO_PTRACE = 1
+- CFLAGS += -DWARN_NO_PTRACE
++ override CFLAGS += -DWARN_NO_PTRACE
+ endif
+ endif
+
+ ifdef NO_PTRACE
+-CFLAGS += -DNO_PTRACE
++override CFLAGS += -DNO_PTRACE
+ endif
+
+ # Append required CFLAGS
+--
+1.8.1.4
+
--
1.8.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS
2013-10-27 23:16 [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS Romain Naour
@ 2013-10-29 17:05 ` Arnout Vandecappelle
2013-10-30 8:08 ` Thomas Petazzoni
2013-10-30 21:45 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-10-29 17:05 UTC (permalink / raw)
To: buildroot
On 28/10/13 00:16, Romain Naour wrote:
>
> Ptrace support detection is ignored when CFLAGS is set by buildroot.
>
> Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
> if ptrace is not available.
>
> Fixes:
> http://autobuild.buildroot.net/results/60e/60ed317d52d93ba2c087aa6ff4f422d760806d89//
>
>
> Signed-off-by: Romain <romain.naour@openwide.fr>
Looks good, but I didn't test it.
However, we should also add NO_PTRACE to TRACE_CMD_MAKE_OPTS if
BR2_PACKAGE_PTRACE is not selected, and add ptrace to the dependencies if
it is.
Regards,
Arnout
> ---
> .../trace-cmd-0002-Makefile-overwrite-CFLAGS.patch | 33
> ++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
> create mode 100644
> package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
>
> diff --git
> a/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
> b/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
> new file mode 100644
> index 0000000..f4afa53
> --- /dev/null
> +++ b/package/trace-cmd/trace-cmd-0002-Makefile-overwrite-CFLAGS.patch
> @@ -0,0 +1,33 @@
> +
> +Ptrace support detection is ignored when CFLAGS is set in command
> arguments.
> +
> +Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
> +if ptrace is not available.
> +
> +Signed-off-by: Romain <romain.naour@openwide.fr>
> +---
> + Makefile | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +diff --git a/Makefile b/Makefile
> +index 2f862ec..51b0df3 100644
> +--- a/Makefile
> ++++ b/Makefile
> +@@ -229,12 +229,12 @@ CFLAGS += -D_GNU_SOURCE
> + ifndef NO_PTRACE
> + ifneq ($(call try-cc,$(SOURCE_PTRACE),),y)
> + NO_PTRACE = 1
> +- CFLAGS += -DWARN_NO_PTRACE
> ++ override CFLAGS += -DWARN_NO_PTRACE
> + endif
> + endif
> +
> + ifdef NO_PTRACE
> +-CFLAGS += -DNO_PTRACE
> ++override CFLAGS += -DNO_PTRACE
> + endif
> +
> + # Append required CFLAGS
> +--
> +1.8.1.4
> +
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS
2013-10-29 17:05 ` Arnout Vandecappelle
@ 2013-10-30 8:08 ` Thomas Petazzoni
2013-10-30 12:07 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2013-10-30 8:08 UTC (permalink / raw)
To: buildroot
Dear Arnout Vandecappelle,
On Tue, 29 Oct 2013 18:05:20 +0100, Arnout Vandecappelle wrote:
> However, we should also add NO_PTRACE to TRACE_CMD_MAKE_OPTS if
> BR2_PACKAGE_PTRACE is not selected, and add ptrace to the dependencies if
> it is.
Huh? ptrace is not a package, it's a libc function. See man ptrace(2).
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS
2013-10-30 8:08 ` Thomas Petazzoni
@ 2013-10-30 12:07 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2013-10-30 12:07 UTC (permalink / raw)
To: buildroot
On 30/10/13 09:08, Thomas Petazzoni wrote:
> Dear Arnout Vandecappelle,
>
> On Tue, 29 Oct 2013 18:05:20 +0100, Arnout Vandecappelle wrote:
>
>> However, we should also add NO_PTRACE to TRACE_CMD_MAKE_OPTS if
>> BR2_PACKAGE_PTRACE is not selected, and add ptrace to the dependencies if
>> it is.
>
> Huh? ptrace is not a package, it's a libc function. See man ptrace(2).
D'oh!
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS
2013-10-27 23:16 [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS Romain Naour
2013-10-29 17:05 ` Arnout Vandecappelle
@ 2013-10-30 21:45 ` Thomas Petazzoni
2013-10-31 17:26 ` Romain Naour
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2013-10-30 21:45 UTC (permalink / raw)
To: buildroot
Dear Romain Naour,
On Mon, 28 Oct 2013 00:16:35 +0100, Romain Naour wrote:
>
> Ptrace support detection is ignored when CFLAGS is set by buildroot.
>
> Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
> if ptrace is not available.
>
> Fixes:
> http://autobuild.buildroot.net/results/60e/60ed317d52d93ba2c087aa6ff4f422d760806d89//
>
> Signed-off-by: Romain <romain.naour@openwide.fr>
Applied to for-peter-2013.11, thanks. However, your patch was badly
line-wrapped. Could you use 'git send-email' for your next patches,
instead of Thunderbird?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS
2013-10-30 21:45 ` Thomas Petazzoni
@ 2013-10-31 17:26 ` Romain Naour
0 siblings, 0 replies; 6+ messages in thread
From: Romain Naour @ 2013-10-31 17:26 UTC (permalink / raw)
To: buildroot
Hi,
Le 30/10/2013 22:45, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Mon, 28 Oct 2013 00:16:35 +0100, Romain Naour wrote:
>> Ptrace support detection is ignored when CFLAGS is set by buildroot.
>>
>> Use override in Makefile to add -DWARN_NO_PTRACE and -DNO_PTRACE in CFLAGS
>> if ptrace is not available.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/60e/60ed317d52d93ba2c087aa6ff4f422d760806d89//
>>
>> Signed-off-by: Romain <romain.naour@openwide.fr>
> Applied to for-peter-2013.11, thanks. However, your patch was badly
> line-wrapped. Could you use 'git send-email' for your next patches,
> instead of Thunderbird?
>
Sorry for that, I will use git send-email for my next patch :)
Thanks !
Romain
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-31 17:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-27 23:16 [Buildroot] [PATCH 1/1] trace-cmd: overwrite CFLAGS Romain Naour
2013-10-29 17:05 ` Arnout Vandecappelle
2013-10-30 8:08 ` Thomas Petazzoni
2013-10-30 12:07 ` Arnout Vandecappelle
2013-10-30 21:45 ` Thomas Petazzoni
2013-10-31 17:26 ` Romain Naour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox