* [Buildroot] [PATCH] audiofile: needs dynamic library
@ 2013-11-12 8:28 spdawson at gmail.com
2013-11-12 11:42 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: spdawson at gmail.com @ 2013-11-12 8:28 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
Fixes build failures such as the following.
http://autobuild.buildroot.net/results/c00/c002711ef82fb29f1765df251bd0006caeccc508/
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
package/audiofile/Config.in | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/audiofile/Config.in b/package/audiofile/Config.in
index 4aa8d69..9752648 100644
--- a/package/audiofile/Config.in
+++ b/package/audiofile/Config.in
@@ -1,11 +1,12 @@
config BR2_PACKAGE_AUDIOFILE
bool "audiofile"
depends on BR2_INSTALL_LIBSTDCPP
+ depends on !BR2_PREFER_STATIC_LIB
help
The Audio File Library handles reading and writing audio files
in many common formats.
http://www.68k.org/~michael/audiofile/
-comment "audiofile needs a toolchain w/ C++"
- depends on !BR2_INSTALL_LIBSTDCPP
+comment "audiofile needs a toolchain w/ C++, dynamic library"
+ depends on !BR2_INSTALL_LIBSTDCPP || BR2_PREFER_STATIC_LIB
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] audiofile: needs dynamic library
2013-11-12 8:28 [Buildroot] [PATCH] audiofile: needs dynamic library spdawson at gmail.com
@ 2013-11-12 11:42 ` Peter Korsgaard
2013-11-12 11:56 ` Gustavo Zacarias
0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2013-11-12 11:42 UTC (permalink / raw)
To: buildroot
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes:
> From: Simon Dawson <spdawson@gmail.com>
> Fixes build failures such as the following.
> http://autobuild.buildroot.net/results/c00/c002711ef82fb29f1765df251bd0006caeccc508/
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
> package/audiofile/Config.in | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> diff --git a/package/audiofile/Config.in b/package/audiofile/Config.in
> index 4aa8d69..9752648 100644
> --- a/package/audiofile/Config.in
> +++ b/package/audiofile/Config.in
> @@ -1,11 +1,12 @@
> config BR2_PACKAGE_AUDIOFILE
> bool "audiofile"
> depends on BR2_INSTALL_LIBSTDCPP
> + depends on !BR2_PREFER_STATIC_LIB
> help
> The Audio File Library handles reading and writing audio files
> in many common formats.
> http://www.68k.org/~michael/audiofile/
> -comment "audiofile needs a toolchain w/ C++"
> - depends on !BR2_INSTALL_LIBSTDCPP
> +comment "audiofile needs a toolchain w/ C++, dynamic library"
> + depends on !BR2_INSTALL_LIBSTDCPP || BR2_PREFER_STATIC_LIB
Thanks, but you forgot the reverse dependencies:
git grep -l 'select BR2_PACKAGE_AUDIOFILE'
package/mpd/Config.in
Looking at the build log, the only reason why it fails is that libtool
is acting up. It wants to link with libstdc++.so instead of libstdc++.a.
A quick test shows that you can fix it by passing -static instead of
--static in LDFLAGS, but that effectively reverts 0a4bd19f4a136930c:
http://git.buildroot.net/buildroot/commit/?id=0a4bd19f4a136930c
Does anybody know what the right solution is?
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] audiofile: needs dynamic library
2013-11-12 11:42 ` Peter Korsgaard
@ 2013-11-12 11:56 ` Gustavo Zacarias
2013-11-12 12:17 ` Thomas Petazzoni
2013-11-12 12:23 ` Peter Korsgaard
0 siblings, 2 replies; 6+ messages in thread
From: Gustavo Zacarias @ 2013-11-12 11:56 UTC (permalink / raw)
To: buildroot
On 11/12/2013 08:42 AM, Peter Korsgaard wrote:
> Looking at the build log, the only reason why it fails is that libtool
> is acting up. It wants to link with libstdc++.so instead of libstdc++.a.
>
> A quick test shows that you can fix it by passing -static instead of
> --static in LDFLAGS, but that effectively reverts 0a4bd19f4a136930c:
>
> http://git.buildroot.net/buildroot/commit/?id=0a4bd19f4a136930c
>
> Does anybody know what the right solution is?
I think this is related to the nettle failure i've mentioned, after the
gcc conversion host-gcc-final isn't installing libstdc++.a, and after an
extra look it isn't even building it because of --disable-static in the
default CONFIGURE_CMDS.
So it'll never find a libstdc++.a for the internal toolchain in staging.
Regards.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] audiofile: needs dynamic library
2013-11-12 11:56 ` Gustavo Zacarias
@ 2013-11-12 12:17 ` Thomas Petazzoni
2013-11-12 12:23 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2013-11-12 12:17 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Tue, 12 Nov 2013 08:56:20 -0300, Gustavo Zacarias wrote:
> On 11/12/2013 08:42 AM, Peter Korsgaard wrote:
> > Looking at the build log, the only reason why it fails is that
> > libtool is acting up. It wants to link with libstdc++.so instead of
> > libstdc++.a.
> >
> > A quick test shows that you can fix it by passing -static instead of
> > --static in LDFLAGS, but that effectively reverts 0a4bd19f4a136930c:
> >
> > http://git.buildroot.net/buildroot/commit/?id=0a4bd19f4a136930c
> >
> > Does anybody know what the right solution is?
>
> I think this is related to the nettle failure i've mentioned, after
> the gcc conversion host-gcc-final isn't installing libstdc++.a, and
> after an extra look it isn't even building it because of
> --disable-static in the default CONFIGURE_CMDS.
> So it'll never find a libstdc++.a for the internal toolchain in
> staging. Regards.
I'll try to have a look at this issue tonight.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] audiofile: needs dynamic library
2013-11-12 11:56 ` Gustavo Zacarias
2013-11-12 12:17 ` Thomas Petazzoni
@ 2013-11-12 12:23 ` Peter Korsgaard
2013-11-12 12:25 ` Gustavo Zacarias
1 sibling, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2013-11-12 12:23 UTC (permalink / raw)
To: buildroot
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> I think this is related to the nettle failure i've mentioned, after the
> gcc conversion host-gcc-final isn't installing libstdc++.a, and after an
> extra look it isn't even building it because of --disable-static in the
> default CONFIGURE_CMDS.
> So it'll never find a libstdc++.a for the internal toolchain in staging.
> Regards.
Yes, but I've just tested with an external toolchain where libstdc++.a
IS copied to staging, and same problem.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-11-12 12:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-12 8:28 [Buildroot] [PATCH] audiofile: needs dynamic library spdawson at gmail.com
2013-11-12 11:42 ` Peter Korsgaard
2013-11-12 11:56 ` Gustavo Zacarias
2013-11-12 12:17 ` Thomas Petazzoni
2013-11-12 12:23 ` Peter Korsgaard
2013-11-12 12:25 ` Gustavo Zacarias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox