From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.
Date: Mon, 16 Dec 2013 15:46:25 +0000 [thread overview]
Message-ID: <52AF2051.7080806@imgtec.com> (raw)
In-Reply-To: <87bo0gsu9g.fsf@dell.be.48ers.dk>
On 12/16/2013 03:14 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> Hi,
>
> >> > Yes, I sent a pull request upstream and they merged it. If you have
> >> > updated the knock.mk to use the latest git, then we don't need any
> >> > patch because it's already applied upstream :-)
> >>
> >> True, but the same applies with the current version we're using as that
> >> is from before the README -> README.md rename.
>
> > Oh, I understand now... You changed the git version of this package to
> > downgrade it just to the point before the README -> README.md was
> > made.
>
> Well, that's one way of seeing it - I fixed it to use the version
> specified (7666f2e86e18d4), which was presumably what was the submitter
> had desired. Before that fix it used the current head (first time the
> package was built, afterwards the local tarball in dl/ is used).
>
>
> >> If you have tested the latest git then you are welcome to send a patch
> >> bumping the version.
>
> > Yes, I have tested it, but it's easier for you to just change the
> > version to the last git commit number.
>
> Do you mind sending a patch changing KNOCK_VERSION so you can sign off
> on it? Thanks.
>
But you need to mirror it first. The version we have right know works
because you have this tarball in the buildroot mirrors:
http://sources.buildroot.net//knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
If you try to get that file from git, it fails with:
>>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Downloading
--2013-12-16 15:40:52--
https://github.com/jvinet/7666f2e86e18d482eaad5fe1fea46d87d80b0555/tarball/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
Resolving github.com... 192.30.252.130
Connecting to github.com|192.30.252.130|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2013-12-16 15:40:53 ERROR 404: Not Found.
So, in order to bump the version you need to put the new tarball in the
mirrors first.
--
Vincent
next prev parent reply other threads:[~2013-12-16 15:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 12:26 [Buildroot] [PATCH v3] knock: Fix build failure due to missing README file Vicente Olivert Riera
2013-12-12 14:27 ` Peter Korsgaard
2013-12-12 22:29 ` Arnout Vandecappelle
2013-12-12 22:50 ` Peter Korsgaard
2013-12-13 9:33 ` Vicente Olivert Riera
2013-12-13 9:58 ` Peter Korsgaard
2013-12-16 14:39 ` Vicente Olivert Riera
2013-12-16 15:14 ` Peter Korsgaard
2013-12-16 15:46 ` Vicente Olivert Riera [this message]
2013-12-16 15:50 ` Vicente Olivert Riera
2013-12-16 15:55 ` Peter Korsgaard
2013-12-16 16:38 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF2051.7080806@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox