[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Vicente Olivert Riera]

Apply upstream patch: 306a696c0882f28a5cd2e41d392c3a6ed14d45f4

The build process fails because Makefile.am includes README as part of
the documentation files, but actually it doesn't exist:

make[2]: *** No rule to make target `README', needed by `all-am'. Stop.

The right file is README.md, so making that replacement to Makefile.am
fixes the problem.

Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 .../knock/knock-001-Fix-missing-README-file.patch  |   34 ++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 package/knock/knock-001-Fix-missing-README-file.patch

diff --git a/package/knock/knock-001-Fix-missing-README-file.patch b/package/knock/knock-001-Fix-missing-README-file.patch
new file mode 100644
index 0000000..8af7405
--- /dev/null
+++ b/package/knock/knock-001-Fix-missing-README-file.patch
@@ -0,0 +1,34 @@
+From 306a696c0882f28a5cd2e41d392c3a6ed14d45f4 Mon Sep 17 00:00:00 2001
+From: vriera <Vincent.Riera@imgtec.com>
+Date: Tue, 10 Dec 2013 12:40:13 +0000
+Subject: [PATCH] Update Makefile.am
+
+Fix build failure due to missing README file.
+
+The build process fails because Makefile.am includes README as part of the documentation files, but actually it doesn't exist:
+
+make[2]: *** No rule to make target `README', needed by `all-am'. Stop.
+
+The right file is README.md, so making that replacement to Makefile.am fixes the problem.
+
+Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
+---
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/Makefile.am b/Makefile.am
+index b46e8c4..1a95e90 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -10,7 +10,7 @@ man_MANS += doc/knockd.1
+ sysconf_DATA = knockd.conf
+ endif
+ 
+-dist_doc_DATA = README TODO ChangeLog COPYING
++dist_doc_DATA = README.md TODO ChangeLog COPYING
+ 
+ knock_SOURCES = src/knock.c
+ knockd_SOURCES = src/knockd.c src/list.c src/list.h
+-- 
+1.8.5.1
+
-- 
1.7.1

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > Apply upstream patch: 306a696c0882f28a5cd2e41d392c3a6ed14d45f4
 > The build process fails because Makefile.am includes README as part of
 > the documentation files, but actually it doesn't exist:

 > make[2]: *** No rule to make target `README', needed by `all-am'. Stop.

 > The right file is README.md, so making that replacement to Makefile.am
 > fixes the problem.

Ups, houston we have a problem:

>>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Downloading
--2013-12-12 15:09:21--  https://github.com/jvinet/knock/tarball/master/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
Resolving github.com (github.com)... 192.30.252.129
Connecting to github.com (github.com)|192.30.252.129|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://codeload.github.com/jvinet/knock/legacy.tar.gz/master [following]
--2013-12-12 15:09:22--  https://codeload.github.com/jvinet/knock/legacy.tar.gz/master
Resolving codeload.github.com (codeload.github.com)... 192.30.252.144
Connecting to codeload.github.com (codeload.github.com)|192.30.252.144|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: unspecified [application/x-gzip]
Saving to: `/var/lib/downloads/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz.tmp'

    [ <=>                                   ] 27,846      --.-K/s   in 0.001s  

2013-12-12 15:09:23 (41.6 MB/s) - `/var/lib/downloads/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz.tmp' saved [27846]

>>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Extracting
gzip -d -c /var/lib/downloads/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz | tar --strip-components=1 -C /home/peko/source/buildroot/output/build/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555  -xf -
>>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Patching

Applying knock-001-Fix-missing-README-file.patch using patch: 
patching file Makefile.am
Reversed (or previously applied) patch detected!  Skipping patch.

The github URL was wrong, so it always downloaded the latest version
from master.

With that fixed the patch is not needed (as the README -> README.md
rename only happeneded after 7666f2):

https://github.com/jvinet/knock/commit/4faa1daa4f8ab6825a2becf106f43220af395132

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Arnout Vandecappelle]

  Hi Vicente,

On 12/12/13 15:27, Peter Korsgaard wrote:
> With that fixed the patch is not needed (as the README -> README.md
> rename only happeneded after 7666f2):

  But of course, your patch is still relevant to send upstream!

  Regards,
  Arnout

>
> https://github.com/jvinet/knock/commit/4faa1daa4f8ab6825a2becf106f43220af395132

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Peter Korsgaard]

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

 >  Hi Vicente,
 > On 12/12/13 15:27, Peter Korsgaard wrote:
 >> With that fixed the patch is not needed (as the README -> README.md
 >> rename only happeneded after 7666f2):

 >  But of course, your patch is still relevant to send upstream!

It afaik is already included upstream, which is why the patch no longer
applied.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Vicente Olivert Riera]

On 12/12/2013 10:50 PM, Peter Korsgaard wrote:
>>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
>
>   >  Hi Vicente,
>   > On 12/12/13 15:27, Peter Korsgaard wrote:
>   >> With that fixed the patch is not needed (as the README -> README.md
>   >> rename only happeneded after 7666f2):
>
>   >  But of course, your patch is still relevant to send upstream!
>
> It afaik is already included upstream, which is why the patch no longer
> applied.
>

Yes, I sent a pull request upstream and they merged it. If you have 
updated the knock.mk to use the latest git, then we don't need any patch 
because it's already applied upstream :-)

-- 
Vincent

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

Hi,

 >> >  But of course, your patch is still relevant to send upstream!
 >> 
 >> It afaik is already included upstream, which is why the patch no longer
 >> applied.
 >> 

 > Yes, I sent a pull request upstream and they merged it. If you have
 > updated the knock.mk to use the latest git, then we don't need any
 > patch because it's already applied upstream :-)

True, but the same applies with the current version we're using as that
is from before the README -> README.md rename.

If you have tested the latest git then you are welcome to send a patch
bumping the version.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Vicente Olivert Riera]

On 12/13/2013 09:58 AM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> Hi,
>
>   >> >  But of course, your patch is still relevant to send upstream!
>   >>
>   >> It afaik is already included upstream, which is why the patch no longer
>   >> applied.
>   >>
>
>   > Yes, I sent a pull request upstream and they merged it. If you have
>   > updated the knock.mk to use the latest git, then we don't need any
>   > patch because it's already applied upstream :-)
>
> True, but the same applies with the current version we're using as that
> is from before the README -> README.md rename.

Oh, I understand now... You changed the git version of this package to 
downgrade it just to the point before the README -> README.md was made.

> If you have tested the latest git then you are welcome to send a patch
> bumping the version.
>

Yes, I have tested it, but it's easier for you to just change the 
version to the last git commit number.

-- 
Vincent

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

Hi,

 >> > Yes, I sent a pull request upstream and they merged it. If you have
 >> > updated the knock.mk to use the latest git, then we don't need any
 >> > patch because it's already applied upstream :-)
 >> 
 >> True, but the same applies with the current version we're using as that
 >> is from before the README -> README.md rename.

 > Oh, I understand now... You changed the git version of this package to
 > downgrade it just to the point before the README -> README.md was
 > made.

Well, that's one way of seeing it - I fixed it to use the version
specified (7666f2e86e18d4), which was presumably what was the submitter
had desired. Before that fix it used the current head (first time the
package was built, afterwards the local tarball in dl/ is used).


 >> If you have tested the latest git then you are welcome to send a patch
 >> bumping the version.

 > Yes, I have tested it, but it's easier for you to just change the
 > version to the last git commit number.

Do you mind sending a patch changing KNOCK_VERSION so you can sign off
on it? Thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Vicente Olivert Riera]

On 12/16/2013 03:14 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> Hi,
>
>   >> > Yes, I sent a pull request upstream and they merged it. If you have
>   >> > updated the knock.mk to use the latest git, then we don't need any
>   >> > patch because it's already applied upstream :-)
>   >>
>   >> True, but the same applies with the current version we're using as that
>   >> is from before the README -> README.md rename.
>
>   > Oh, I understand now... You changed the git version of this package to
>   > downgrade it just to the point before the README -> README.md was
>   > made.
>
> Well, that's one way of seeing it - I fixed it to use the version
> specified (7666f2e86e18d4), which was presumably what was the submitter
> had desired. Before that fix it used the current head (first time the
> package was built, afterwards the local tarball in dl/ is used).
>
>
>   >> If you have tested the latest git then you are welcome to send a patch
>   >> bumping the version.
>
>   > Yes, I have tested it, but it's easier for you to just change the
>   > version to the last git commit number.
>
> Do you mind sending a patch changing KNOCK_VERSION so you can sign off
> on it? Thanks.
>

But you need to mirror it first. The version we have right know works 
because you have this tarball in the buildroot mirrors:
http://sources.buildroot.net//knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz

If you try to get that file from git, it fails with:
 >>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Downloading
--2013-12-16 15:40:52-- 
https://github.com/jvinet/7666f2e86e18d482eaad5fe1fea46d87d80b0555/tarball/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
Resolving github.com... 192.30.252.130
Connecting to github.com|192.30.252.130|:443... connected.
HTTP request sent, awaiting response... 404 Not Found
2013-12-16 15:40:53 ERROR 404: Not Found.

So, in order to bump the version you need to put the new tarball in the 
mirrors first.

-- 
Vincent

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Vicente Olivert Riera]

On 12/16/2013 03:46 PM, Vicente Olivert Riera wrote:
> On 12/16/2013 03:14 PM, Peter Korsgaard wrote:
>>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>>>>>> writes:
>>
>> Hi,
>>
>>   >> > Yes, I sent a pull request upstream and they merged it. If you
>> have
>>   >> > updated the knock.mk to use the latest git, then we don't need any
>>   >> > patch because it's already applied upstream :-)
>>   >>
>>   >> True, but the same applies with the current version we're using
>> as that
>>   >> is from before the README -> README.md rename.
>>
>>   > Oh, I understand now... You changed the git version of this
>> package to
>>   > downgrade it just to the point before the README -> README.md was
>>   > made.
>>
>> Well, that's one way of seeing it - I fixed it to use the version
>> specified (7666f2e86e18d4), which was presumably what was the submitter
>> had desired. Before that fix it used the current head (first time the
>> package was built, afterwards the local tarball in dl/ is used).
>>
>>
>>   >> If you have tested the latest git then you are welcome to send a
>> patch
>>   >> bumping the version.
>>
>>   > Yes, I have tested it, but it's easier for you to just change the
>>   > version to the last git commit number.
>>
>> Do you mind sending a patch changing KNOCK_VERSION so you can sign off
>> on it? Thanks.
>>
>
> But you need to mirror it first. The version we have right know works
> because you have this tarball in the buildroot mirrors:
> http://sources.buildroot.net//knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
>
>
> If you try to get that file from git, it fails with:
>  >>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Downloading
> --2013-12-16 15:40:52--
> https://github.com/jvinet/7666f2e86e18d482eaad5fe1fea46d87d80b0555/tarball/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
>
> Resolving github.com... 192.30.252.130
> Connecting to github.com|192.30.252.130|:443... connected.
> HTTP request sent, awaiting response... 404 Not Found
> 2013-12-16 15:40:53 ERROR 404: Not Found.
>
> So, in order to bump the version you need to put the new tarball in the
> mirrors first.
>

Or fix the function and fetch the source from here:
https://github.com/jvinet/<package-name>/archive/<version>.zip

and not from here:
https://github.com/jvinet/<version>/tarball/<package-name>-<version>.tar.gz
-- 
Vincent

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Peter Korsgaard]

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

Hi,

 > But you need to mirror it first. The version we have right know works
 > because you have this tarball in the buildroot mirrors:
 > http://sources.buildroot.net//knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz

 > If you try to get that file from git, it fails with:
 >>>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Downloading
 > --2013-12-16 15:40:52-- 
 > https://github.com/jvinet/7666f2e86e18d482eaad5fe1fea46d87d80b0555/tarball/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
 > Resolving github.com... 192.30.252.130
 > Connecting to github.com|192.30.252.130|:443... connected.
 > HTTP request sent, awaiting response... 404 Not Found
 > 2013-12-16 15:40:53 ERROR 404: Not Found.

 > So, in order to bump the version you need to put the new tarball in
 > the mirrors first.

Ahh, I somehow dropped the project name ('knock') from the github macro
when I fixed the revision.

Sorry about that, fixed in git.

 > -- 
 > Vincent



-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v3] knock: Fix build failure due to missing README file.

[Vicente Olivert Riera]

On 12/16/2013 03:55 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> Hi,
>
>   > But you need to mirror it first. The version we have right know works
>   > because you have this tarball in the buildroot mirrors:
>   > http://sources.buildroot.net//knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
>
>   > If you try to get that file from git, it fails with:
>   >>>> knock 7666f2e86e18d482eaad5fe1fea46d87d80b0555 Downloading
>   > --2013-12-16 15:40:52--
>   > https://github.com/jvinet/7666f2e86e18d482eaad5fe1fea46d87d80b0555/tarball/knock-7666f2e86e18d482eaad5fe1fea46d87d80b0555.tar.gz
>   > Resolving github.com... 192.30.252.130
>   > Connecting to github.com|192.30.252.130|:443... connected.
>   > HTTP request sent, awaiting response... 404 Not Found
>   > 2013-12-16 15:40:53 ERROR 404: Not Found.
>
>   > So, in order to bump the version you need to put the new tarball in
>   > the mirrors first.
>
> Ahh, I somehow dropped the project name ('knock') from the github macro
> when I fixed the revision.
>
> Sorry about that, fixed in git.
>
>   > --
>   > Vincent
>
>
>
Very good, we have found and fixed a bug before autobuilds start to 
complain :-P

Here you have the patch: http://patchwork.ozlabs.org/patch/301759/

Thanks!
-- 
Vincent