* [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
@ 2014-01-29 21:48 Yann E. MORIN
2014-01-30 7:05 ` Arnout Vandecappelle
2014-02-21 22:11 ` Yann E. MORIN
0 siblings, 2 replies; 7+ messages in thread
From: Yann E. MORIN @ 2014-01-29 21:48 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
$(TOPDIR)/local.mk
This works well for in-tree builds, but is not very useful for
out-of-tree builds, when the Buildroot source tree may be shared for
different concurrent builds.
Also, it seems to be more sensible to have local.mk alognside
the .config file.
Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
$(CONFIG_DIR)/local.mk
Note that this does not change the current behaviour for in-tree
builds, since in that case $(CONFIG_DIR) == $(TOPDIR).
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
---
Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Config.in b/Config.in
index 7ec7c2a..f8d6e23 100644
--- a/Config.in
+++ b/Config.in
@@ -488,7 +488,7 @@ config BR2_HAVE_DOCUMENTATION
config BR2_PACKAGE_OVERRIDE_FILE
string "location of a package override file"
- default "$(TOPDIR)/local.mk"
+ default "$(CONFIG_DIR)/local.mk"
help
A package override file is a short makefile that contains
variable definitions of the form <pkg>_OVERRIDE_SRCDIR,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
2014-01-29 21:48 [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk Yann E. MORIN
@ 2014-01-30 7:05 ` Arnout Vandecappelle
2014-02-21 22:11 ` Yann E. MORIN
1 sibling, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2014-01-30 7:05 UTC (permalink / raw)
To: buildroot
On 29/01/14 22:48, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
> $(TOPDIR)/local.mk
>
> This works well for in-tree builds, but is not very useful for
> out-of-tree builds, when the Buildroot source tree may be shared for
> different concurrent builds.
>
> Also, it seems to be more sensible to have local.mk alognside
> the .config file.
>
> Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
> $(CONFIG_DIR)/local.mk
>
> Note that this does not change the current behaviour for in-tree
> builds, since in that case $(CONFIG_DIR) == $(TOPDIR).
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
I was doubtful about this one at first, because the output directory is
something that should be easily thrown away. But then, so is the override
file - especially now we have BR2_EXTERNAL for overrides that are
persistent. Therefore:
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> ---
> Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Config.in b/Config.in
> index 7ec7c2a..f8d6e23 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -488,7 +488,7 @@ config BR2_HAVE_DOCUMENTATION
>
> config BR2_PACKAGE_OVERRIDE_FILE
> string "location of a package override file"
> - default "$(TOPDIR)/local.mk"
> + default "$(CONFIG_DIR)/local.mk"
> help
> A package override file is a short makefile that contains
> variable definitions of the form <pkg>_OVERRIDE_SRCDIR,
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
2014-01-29 21:48 [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk Yann E. MORIN
2014-01-30 7:05 ` Arnout Vandecappelle
@ 2014-02-21 22:11 ` Yann E. MORIN
2014-02-21 22:31 ` Peter Korsgaard
1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2014-02-21 22:11 UTC (permalink / raw)
To: buildroot
All,
On 2014-01-29 22:48 +0100, Yann E. MORIN spake thusly:
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
> $(TOPDIR)/local.mk
>
> This works well for in-tree builds, but is not very useful for
> out-of-tree builds, when the Buildroot source tree may be shared for
> different concurrent builds.
>
> Also, it seems to be more sensible to have local.mk alognside
> the .config file.
>
> Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
> $(CONFIG_DIR)/local.mk
>
> Note that this does not change the current behaviour for in-tree
> builds, since in that case $(CONFIG_DIR) == $(TOPDIR).
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
Ping? For -next?
Note that it was acked by Arnout.
> ---
> Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Config.in b/Config.in
> index 7ec7c2a..f8d6e23 100644
> --- a/Config.in
> +++ b/Config.in
> @@ -488,7 +488,7 @@ config BR2_HAVE_DOCUMENTATION
>
> config BR2_PACKAGE_OVERRIDE_FILE
> string "location of a package override file"
> - default "$(TOPDIR)/local.mk"
> + default "$(CONFIG_DIR)/local.mk"
> help
> A package override file is a short makefile that contains
> variable definitions of the form <pkg>_OVERRIDE_SRCDIR,
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
2014-02-21 22:11 ` Yann E. MORIN
@ 2014-02-21 22:31 ` Peter Korsgaard
0 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2014-02-21 22:31 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> All,
> On 2014-01-29 22:48 +0100, Yann E. MORIN spake thusly:
>> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>
>> The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
>> $(TOPDIR)/local.mk
>>
>> This works well for in-tree builds, but is not very useful for
>> out-of-tree builds, when the Buildroot source tree may be shared for
>> different concurrent builds.
>>
>> Also, it seems to be more sensible to have local.mk alognside
>> the .config file.
>>
>> Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
>> $(CONFIG_DIR)/local.mk
>>
>> Note that this does not change the current behaviour for in-tree
>> builds, since in that case $(CONFIG_DIR) == $(TOPDIR).
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
> Ping? For -next?
Sorry, I must have missed it.
Committed to next, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
@ 2014-01-29 18:42 Yann E. MORIN
2014-01-29 20:45 ` Thomas De Schampheleire
0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2014-01-29 18:42 UTC (permalink / raw)
To: buildroot
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
$(TOPDIR)/local.mk
This works well for in-tree builds, but is not very useful for
out-of-tree builds, when the Buildroot source tree may be shared for
different concurrent builds.
Also, it seems to be more sensible to have local.mk alognside
the .config file.
Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
$(CONFIG_DIR)/local.mk
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
---
Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Config.in b/Config.in
index 7ec7c2a..f8d6e23 100644
--- a/Config.in
+++ b/Config.in
@@ -488,7 +488,7 @@ config BR2_HAVE_DOCUMENTATION
config BR2_PACKAGE_OVERRIDE_FILE
string "location of a package override file"
- default "$(TOPDIR)/local.mk"
+ default "$(CONFIG_DIR)/local.mk"
help
A package override file is a short makefile that contains
variable definitions of the form <pkg>_OVERRIDE_SRCDIR,
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
2014-01-29 18:42 Yann E. MORIN
@ 2014-01-29 20:45 ` Thomas De Schampheleire
2014-01-29 20:59 ` Yann E. MORIN
0 siblings, 1 reply; 7+ messages in thread
From: Thomas De Schampheleire @ 2014-01-29 20:45 UTC (permalink / raw)
To: buildroot
Op 29-jan.-2014 19:43 schreef "Yann E. MORIN" <yann.morin.1998@free.fr>:
>
> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
> $(TOPDIR)/local.mk
>
> This works well for in-tree builds, but is not very useful for
> out-of-tree builds, when the Buildroot source tree may be shared for
> different concurrent builds.
>
> Also, it seems to be more sensible to have local.mk alognside
> the .config file.
>
> Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
> $(CONFIG_DIR)/local.mk
... which in the default case equals TOPDIR, right? (Would be nice to
clarify in the commit message)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20140129/80ac9d1a/attachment.html>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk
2014-01-29 20:45 ` Thomas De Schampheleire
@ 2014-01-29 20:59 ` Yann E. MORIN
0 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2014-01-29 20:59 UTC (permalink / raw)
To: buildroot
Thomas, All,
On 2014-01-29 21:45 +0100, Thomas De Schampheleire spake thusly:
> Op 29-jan.-2014 19:43 schreef "Yann E. MORIN" <yann.morin.1998@free.fr>:
> >
> > From: "Yann E. MORIN" <yann.morin.1998@free.fr>
> >
> > The current default for BR2_PACKAGE_OVERRIDE_FILE points to:
> > $(TOPDIR)/local.mk
> >
> > This works well for in-tree builds, but is not very useful for
> > out-of-tree builds, when the Buildroot source tree may be shared for
> > different concurrent builds.
> >
> > Also, it seems to be more sensible to have local.mk alognside
> > the .config file.
> >
> > Hence, change the default for BR2_PACKAGE_OVERRIDE_FILE to point to:
> > $(CONFIG_DIR)/local.mk
>
> ... which in the default case equals TOPDIR, right? (Would be nice to
> clarify in the commit message)
Oh, yes. I intended to write that part, but was absorbed by the very
nice fumet of the dinner being cooked at the time I wrote the commit
log.
I plead guilty for having been disturbed by my nostrils, and my stomach!
I'll respin with that added. Thank you! :-)
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-02-21 22:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-29 21:48 [Buildroot] [PATCH] Config: default BR2_PACKAGE_OVERRIDE_FILE to $(CONFIG_DIR)/local.mk Yann E. MORIN
2014-01-30 7:05 ` Arnout Vandecappelle
2014-02-21 22:11 ` Yann E. MORIN
2014-02-21 22:31 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2014-01-29 18:42 Yann E. MORIN
2014-01-29 20:45 ` Thomas De Schampheleire
2014-01-29 20:59 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox