* [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate
@ 2013-12-30 17:57 Bernd Kuhls
2014-02-02 16:51 ` Bernd Kuhls
2014-02-04 9:59 ` Arnout Vandecappelle
0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2013-12-30 17:57 UTC (permalink / raw)
To: buildroot
Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com>
---
package/gnupg/gnupg.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/gnupg/gnupg.mk b/package/gnupg/gnupg.mk
index 39a37d0..c334ac6 100644
--- a/package/gnupg/gnupg.mk
+++ b/package/gnupg/gnupg.mk
@@ -9,7 +9,7 @@ GNUPG_SOURCE = gnupg-$(GNUPG_VERSION).tar.bz2
GNUPG_SITE = ftp://ftp.gnupg.org/gcrypt/gnupg
GNUPG_LICENSE = GPLv3+
GNUPG_LICENSE_FILES = COPYING
-GNUPG_DEPENDENCIES = zlib ncurses
+GNUPG_DEPENDENCIES = zlib ncurses $(if $(BR2_PACKAGE_LIBICONV),libiconv)
GNUPG_CONF_ENV = ac_cv_sys_symbol_underscore=no
GNUPG_CONF_OPT = --disable-rpath --enable-minimal --disable-regex
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate
2013-12-30 17:57 [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate Bernd Kuhls
@ 2014-02-02 16:51 ` Bernd Kuhls
2014-02-04 9:59 ` Arnout Vandecappelle
1 sibling, 0 replies; 6+ messages in thread
From: Bernd Kuhls @ 2014-02-02 16:51 UTC (permalink / raw)
To: buildroot
Bernd Kuhls <berndkuhls@hotmail.com> wrote in
news:BLU0-SMTP112B1A733C43DA19ABF8DF9D9CE0 at phx.gbl:
> -GNUPG_DEPENDENCIES = zlib ncurses
> +GNUPG_DEPENDENCIES = zlib ncurses $(if
> $(BR2_PACKAGE_LIBICONV),libiconv)
Hi,
this a follow-up for Thomas? question:
http://article.gmane.org/gmane.comp.lib.uclibc.buildroot/75233
Today I tested the necessity of my patch without a custom uClibc
configuration file, only with this defconfig applied to a current git
checkout:
BR2_JLEVEL=8
BR2_ENABLE_DEBUG=y
BR2_OPTIMIZE_2=y
BR2_TOOLCHAIN_BUILDROOT_LARGEFILE=y
BR2_TOOLCHAIN_BUILDROOT_INET_IPV6=y
BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
BR2_PTHREAD_DEBUG=y
# BR2_UCLIBC_INSTALL_UTILS is not set
BR2_BINUTILS_VERSION_2_23_2=y
BR2_GCC_VERSION_4_8_X=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PACKAGE_HOST_GDB=y
BR2_PACKAGE_GETTEXT=y
BR2_PACKAGE_LIBICONV=y
BR2_PACKAGE_GNUPG=y
Building these targets in the following order
- toolchain
- libiconv
- gnupg
results in a gpg binary linked to libiconv
$ /home/fli4l/buildroot/output/host/usr/bin/i586-buildroot-linux-uclibc-
readelf -a /home/fli4l/buildroot/output/target/usr/bin/gpg | grep NEEDED
0x00000001 (NEEDED) Shared library: [libiconv.so.2]
0x00000001 (NEEDED) Shared library: [libz.so.1]
0x00000001 (NEEDED) Shared library: [libgcc_s.so.1]
0x00000001 (NEEDED) Shared library: [libc.so.0]
Removing
BR2_PACKAGE_GETTEXT=y
BR2_PACKAGE_LIBICONV=y
from defconfig results in this gpg binary:
/home/fli4l/buildroot/output/host/usr/bin/i586-buildroot-linux-uclibc-
readelf -a /home/fli4l/buildroot/output/target/usr/bin/gpg | grep NEEDED
0x00000001 (NEEDED) Shared library: [libz.so.1]
0x00000001 (NEEDED) Shared library: [libgcc_s.so.1]
0x00000001 (NEEDED) Shared library: [libc.so.0]
I hope this proves why my patches are necessary.
Regards, Bernd
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate
2013-12-30 17:57 [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate Bernd Kuhls
2014-02-02 16:51 ` Bernd Kuhls
@ 2014-02-04 9:59 ` Arnout Vandecappelle
2014-02-04 10:11 ` Arnout Vandecappelle
2014-02-04 10:24 ` Peter Korsgaard
1 sibling, 2 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2014-02-04 9:59 UTC (permalink / raw)
To: buildroot
On 30/12/13 18:57, Bernd Kuhls wrote:
>
> Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Ideally, the explanation that you put in the follow-up message should be
in the commit log, but OK.
Regards,
Arnout
> ---
> package/gnupg/gnupg.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/gnupg/gnupg.mk b/package/gnupg/gnupg.mk
> index 39a37d0..c334ac6 100644
> --- a/package/gnupg/gnupg.mk
> +++ b/package/gnupg/gnupg.mk
> @@ -9,7 +9,7 @@ GNUPG_SOURCE = gnupg-$(GNUPG_VERSION).tar.bz2
> GNUPG_SITE = ftp://ftp.gnupg.org/gcrypt/gnupg
> GNUPG_LICENSE = GPLv3+
> GNUPG_LICENSE_FILES = COPYING
> -GNUPG_DEPENDENCIES = zlib ncurses
> +GNUPG_DEPENDENCIES = zlib ncurses $(if $(BR2_PACKAGE_LIBICONV),libiconv)
> GNUPG_CONF_ENV = ac_cv_sys_symbol_underscore=no
> GNUPG_CONF_OPT = --disable-rpath --enable-minimal --disable-regex
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate
2014-02-04 9:59 ` Arnout Vandecappelle
@ 2014-02-04 10:11 ` Arnout Vandecappelle
2014-02-04 10:25 ` Peter Korsgaard
2014-02-04 10:24 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2014-02-04 10:11 UTC (permalink / raw)
To: buildroot
On 04/02/14 10:59, Arnout Vandecappelle wrote:
> On 30/12/13 18:57, Bernd Kuhls wrote:
>>
>> Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Ideally, the explanation that you put in the follow-up message should be
> in the commit log, but OK.
Actually, Bernd, to make our life easier, could you repost your
iconv-related patches (including the one in xorg) with the following inj
the commit message:
If iconv is built before this package, this package will link against it;
if it is built after this package, it will not be linked against it. To
make the build reproducible, make sure that iconv is always built before
this package.
(You can replace "this package" with "gnupg" etc. as appropriate, of
course.)
Thanks a lot!
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate
2014-02-04 10:11 ` Arnout Vandecappelle
@ 2014-02-04 10:25 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2014-02-04 10:25 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 04/02/14 10:59, Arnout Vandecappelle wrote:
>> On 30/12/13 18:57, Bernd Kuhls wrote:
>>>
>>> Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com>
>>
>> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>>
>> Ideally, the explanation that you put in the follow-up message should be
>> in the commit log, but OK.
> Actually, Bernd, to make our life easier, could you repost your
> iconv-related patches (including the one in xorg) with the following inj
> the commit message:
> If iconv is built before this package, this package will link against it;
> if it is built after this package, it will not be linked against it. To
> make the build reproducible, make sure that iconv is always built before
> this package.
True. I already applied the gnupg patch (but didn't push it), so I've
adjusted the commit message to match.
Bernd, could you resend the other patches with that commit message -
Thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate
2014-02-04 9:59 ` Arnout Vandecappelle
2014-02-04 10:11 ` Arnout Vandecappelle
@ 2014-02-04 10:24 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2014-02-04 10:24 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 30/12/13 18:57, Bernd Kuhls wrote:
>>
>> Signed-off-by: Bernd Kuhls <berndkuhls@hotmail.com>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Ideally, the explanation that you put in the follow-up message should be
> in the commit log, but OK.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-04 10:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-30 17:57 [Buildroot] [PATCH 1/3] gnupg: depend on libiconv if appropriate Bernd Kuhls
2014-02-02 16:51 ` Bernd Kuhls
2014-02-04 9:59 ` Arnout Vandecappelle
2014-02-04 10:11 ` Arnout Vandecappelle
2014-02-04 10:25 ` Peter Korsgaard
2014-02-04 10:24 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox