From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dependencies.sh: cleanup dependencies.sh
Date: Tue, 04 Feb 2014 17:19:59 +0100 [thread overview]
Message-ID: <52F1132F.1050008@lucaceresoli.net> (raw)
In-Reply-To: <1391459047-23665-1-git-send-email-maxime.hadjinlian@gmail.com>
Hi Maxime,
Maxime Hadjinlian wrote:
> Cleanup mixed indents and remove commented lines.
>
> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
> ---
> support/dependencies/dependencies.sh | 214 +++++++++++++++++------------------
> 1 file changed, 107 insertions(+), 107 deletions(-)
>
> diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh
> index 47d4d10..06386e6 100755
> --- a/support/dependencies/dependencies.sh
> +++ b/support/dependencies/dependencies.sh
> @@ -1,199 +1,199 @@
> #!/bin/sh
> # vi: set sw=4 ts=4:
> -#set -x
>
> export LC_ALL=C
>
> # Verify that grep works
> echo "WORKS" | grep "WORKS" >/dev/null 2>&1
> if test $? != 0 ; then
> - echo
> - echo "grep doesn't work"
> - exit 1
> +echo
> +echo "grep doesn't work"
> +exit 1
> fi
Are you really suggesting we should remove all nesting? Well, I guess
there's been a problem with the e-mail or something...
--
Luca
next prev parent reply other threads:[~2014-02-04 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 20:24 [Buildroot] [PATCH] dependencies.sh: cleanup dependencies.sh Maxime Hadjinlian
2014-02-04 16:19 ` Luca Ceresoli [this message]
2014-02-04 22:35 ` Maxime Hadjinlian
2014-02-05 11:47 ` Thomas De Schampheleire
2014-02-05 21:03 ` Arnout Vandecappelle
2014-02-05 23:00 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F1132F.1050008@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox