From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dependencies.sh: cleanup dependencies.sh
Date: Thu, 06 Feb 2014 00:00:22 +0100 [thread overview]
Message-ID: <87vbwtyxkp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAGduivzutuoD1mhfg6Oxo1DYKz+C+kak62Q0c=g_v7TehC3vuA@mail.gmail.com> (Maxime Hadjinlian's message of "Tue, 4 Feb 2014 23:35:23 +0100")
>>>>> "Maxime" == Maxime Hadjinlian <maxime.hadjinlian@gmail.com> writes:
>> Are you really suggesting we should remove all nesting? Well, I guess
>> there's been a problem with the e-mail or something...
> Well, I asked Peter before doing this, the file contained mixed indents. We
> thought it would be nice to have a consistent indent with the Mk files.
> But if we find we don't want that because it removes clarity in the code. I can
> perfectly resend with only the space/tab fixed.
> I really don't have a strong opinion on this one. Thomas Petazzoni and Yann E.
> Morin also found it disturbing.
> Peter what is your decision ?
Sorry, I think I misunderstood you when you asked. I thought you
referred to indentation with a tab like make, not to drop all
indentation.
I would prefer to keep it like it is now, just with consistent indentation.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2014-02-05 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 20:24 [Buildroot] [PATCH] dependencies.sh: cleanup dependencies.sh Maxime Hadjinlian
2014-02-04 16:19 ` Luca Ceresoli
2014-02-04 22:35 ` Maxime Hadjinlian
2014-02-05 11:47 ` Thomas De Schampheleire
2014-02-05 21:03 ` Arnout Vandecappelle
2014-02-05 23:00 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vbwtyxkp.fsf@dell.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox