* [Buildroot] [PATCH] qemu: add host/target Linux version check
@ 2014-02-08 21:54 Frank Hunleth
2014-02-10 17:06 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Frank Hunleth @ 2014-02-08 21:54 UTC (permalink / raw)
To: buildroot
Raise an error if the host is using an older kernel than the target.
Since qemu-user passes emulated system calls to the host kernel,
this prevents usage of qemu-user in situations where those system
calls will fail.
Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
---
package/qemu/qemu.mk | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index 093ae64..bd6f555 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -74,6 +74,24 @@ define HOST_QEMU_CONFIGURE_CMDS
)
endef
+define HOST_QEMU_LINUX_VERSION_CHECK
+ host_version_parts=`uname -r | sed 's/\-.*//g' | sed 's/\./ /g'` ;\
+ host_version_code=0 ;\
+ multiplier=65536 ;\
+ for host_version_part in $$host_version_parts; do \
+ host_version_code=`echo "$$host_version_code + $$host_version_part * $$multiplier" | bc` ;\
+ multiplier=`echo "$$multiplier / 256" | bc` ;\
+ done ;\
+ target_version_code=`grep LINUX_VERSION_CODE $(STAGING_DIR)/usr/include/linux/version.h | awk '{print $$3}'` ;\
+ if test $$host_version_code -lt $$target_version_code ; then \
+ echo "Refusing to install qemu-user since the target Linux version is newer" ;\
+ echo "than the host's. Missing system calls will fail." ;\
+ exit 1 ;\
+ fi
+endef
+
+HOST_QEMU_POST_BUILD_HOOKS += HOST_QEMU_LINUX_VERSION_CHECK
+
$(eval $(host-autotools-package))
# variable used by other packages
--
1.8.3.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] qemu: add host/target Linux version check
2014-02-08 21:54 [Buildroot] [PATCH] qemu: add host/target Linux version check Frank Hunleth
@ 2014-02-10 17:06 ` Arnout Vandecappelle
2014-02-10 20:46 ` Yann E. MORIN
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2014-02-10 17:06 UTC (permalink / raw)
To: buildroot
On 02/08/14 22:54, Frank Hunleth wrote:
> Raise an error if the host is using an older kernel than the target.
> Since qemu-user passes emulated system calls to the host kernel,
> this prevents usage of qemu-user in situations where those system
> calls will fail.
>
> Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com>
Thanks Frank!
> ---
> package/qemu/qemu.mk | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 093ae64..bd6f555 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -74,6 +74,24 @@ define HOST_QEMU_CONFIGURE_CMDS
> )
> endef
>
> +define HOST_QEMU_LINUX_VERSION_CHECK
Just to be sure, I'd start with a
test `uname -s` = Linux
(some people try to run buildroot on *BSDs, with varying degrees of success).
> + host_version_parts=`uname -r | sed 's/\-.*//g' | sed 's/\./ /g'` ;\
> + host_version_code=0 ;\
> + multiplier=65536 ;\
> + for host_version_part in $$host_version_parts; do \
> + host_version_code=`echo "$$host_version_code + $$host_version_part * $$multiplier" | bc` ;\
> + multiplier=`echo "$$multiplier / 256" | bc` ;\
Even though we do put bc in our dependencies, I'd prefer to avoid
relying on it - not many people know it. Instead, I'd use either bash's
let builtin, or POSIX-compliant expr.
> + done ;\
> + target_version_code=`grep LINUX_VERSION_CODE $(STAGING_DIR)/usr/include/linux/version.h | awk '{print $$3}'` ;\
You can do the grep inside the awk:
awk '/LINUX_VERSION_CODE/ {print $$3}' .../version.h
Since it is possible to build host-qemu without building anything for
the target, you can't rely on version.h being present already. To make
sure it is there, add toolchain to the HOST_QEMU_DEPENDENCIES.
> + if test $$host_version_code -lt $$target_version_code ; then \
> + echo "Refusing to install qemu-user since the target Linux version is newer" ;\
> + echo "than the host's. Missing system calls will fail." ;\
> + exit 1 ;\
> + fi
> +endef
> +
> +HOST_QEMU_POST_BUILD_HOOKS += HOST_QEMU_LINUX_VERSION_CHECK
I think a pre-configure hook is more appropriate.
Regards,
Arnout
> +
> $(eval $(host-autotools-package))
>
> # variable used by other packages
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] qemu: add host/target Linux version check
2014-02-10 17:06 ` Arnout Vandecappelle
@ 2014-02-10 20:46 ` Yann E. MORIN
2014-02-11 3:02 ` Frank Hunleth
0 siblings, 1 reply; 4+ messages in thread
From: Yann E. MORIN @ 2014-02-10 20:46 UTC (permalink / raw)
To: buildroot
Arnout, Frank, All,
On 2014-02-10 18:06 +0100, Arnout Vandecappelle spake thusly:
> On 02/08/14 22:54, Frank Hunleth wrote:
[--SNIP--]
> > + host_version_parts=`uname -r | sed 's/\-.*//g' | sed 's/\./ /g'` ;\
> > + host_version_code=0 ;\
> > + multiplier=65536 ;\
> > + for host_version_part in $$host_version_parts; do \
> > + host_version_code=`echo "$$host_version_code + $$host_version_part * $$multiplier" | bc` ;\
> > + multiplier=`echo "$$multiplier / 256" | bc` ;\
>
> Even though we do put bc in our dependencies, I'd prefer to avoid
> relying on it - not many people know it. Instead, I'd use either bash's
> let builtin, or POSIX-compliant expr.
POSIX defines (basic) mathematical expressions, eg:
multiplier=$((multiplier/256))
See: The Open Group Base Specifications Issue 7, Shell Command Language:
http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_04
> > + if test $$host_version_code -lt $$target_version_code ; then \
> > + echo "Refusing to install qemu-user since the target Linux version is newer" ;\
> > + echo "than the host's. Missing system calls will fail." ;\
> > + exit 1 ;\
> > + fi
> > +endef
> > +
> > +HOST_QEMU_POST_BUILD_HOOKS += HOST_QEMU_LINUX_VERSION_CHECK
>
> I think a pre-configure hook is more appropriate.
Indeed.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] qemu: add host/target Linux version check
2014-02-10 20:46 ` Yann E. MORIN
@ 2014-02-11 3:02 ` Frank Hunleth
0 siblings, 0 replies; 4+ messages in thread
From: Frank Hunleth @ 2014-02-11 3:02 UTC (permalink / raw)
To: buildroot
On Mon, Feb 10, 2014 at 3:46 PM, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Arnout, Frank, All,
>
> On 2014-02-10 18:06 +0100, Arnout Vandecappelle spake thusly:
>> On 02/08/14 22:54, Frank Hunleth wrote:
> [--SNIP--]
>> > + host_version_parts=`uname -r | sed 's/\-.*//g' | sed 's/\./ /g'` ;\
>> > + host_version_code=0 ;\
>> > + multiplier=65536 ;\
>> > + for host_version_part in $$host_version_parts; do \
>> > + host_version_code=`echo "$$host_version_code + $$host_version_part * $$multiplier" | bc` ;\
>> > + multiplier=`echo "$$multiplier / 256" | bc` ;\
>>
>> Even though we do put bc in our dependencies, I'd prefer to avoid
>> relying on it - not many people know it. Instead, I'd use either bash's
>> let builtin, or POSIX-compliant expr.
>
> POSIX defines (basic) mathematical expressions, eg:
> multiplier=$((multiplier/256))
>
> See: The Open Group Base Specifications Issue 7, Shell Command Language:
> http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_04
Thanks Arnout and Yann - I always learn something when I submit a
patch to this project.
Revised patch coming shortly...
>
>> > + if test $$host_version_code -lt $$target_version_code ; then \
>> > + echo "Refusing to install qemu-user since the target Linux version is newer" ;\
>> > + echo "than the host's. Missing system calls will fail." ;\
>> > + exit 1 ;\
>> > + fi
>> > +endef
>> > +
>> > +HOST_QEMU_POST_BUILD_HOOKS += HOST_QEMU_LINUX_VERSION_CHECK
>>
>> I think a pre-configure hook is more appropriate.
>
> Indeed.
>
> Regards,
> Yann E. MORIN.
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
--
Frank Hunleth
Troodon Software LLC
Embedded Software Development
http://troodon-software.com/
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-11 3:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-08 21:54 [Buildroot] [PATCH] qemu: add host/target Linux version check Frank Hunleth
2014-02-10 17:06 ` Arnout Vandecappelle
2014-02-10 20:46 ` Yann E. MORIN
2014-02-11 3:02 ` Frank Hunleth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox