Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 04/10] toolchain/external: add choice to select 'AT_LEAST_XXX' header version
Date: Mon, 17 Feb 2014 23:45:08 +0100	[thread overview]
Message-ID: <530290F4.1060507@mind.be> (raw)
In-Reply-To: <8fdcf8b3-c275-4250-be9c-11bcf4feaa11@email.android.com>

On 16/02/14 21:08, Thomas De Schampheleire wrote:
> "Yann E. MORIN" <yann.morin.1998@free.fr> schreef:
>> From: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>
>> Select the appropriate BR2_TOOLCHAIN_HEADERS_AT_LEAST_XXX options for the
>> external, custom toolchain backend.
>>
>> We try to be conservative here, and default to kernel headers 2.6.x.
>>
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Cc: Arnout Vandecappelle <arnout@mind.be>
>> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com>
>> ---
>> toolchain/toolchain-external/Config-headers.in | 65 ++++++++++++++++++++++++++
>> toolchain/toolchain-external/Config.in         |  2 +
>> 2 files changed, 67 insertions(+)
>> create mode 100644 toolchain/toolchain-external/Config-headers.in
>>
>> diff --git a/toolchain/toolchain-external/Config-headers.in b/toolchain/toolchain-external/Config-headers.in
>> new file mode 100644
>> index 0000000..60ac384
>> --- /dev/null
>> +++ b/toolchain/toolchain-external/Config-headers.in
>> @@ -0,0 +1,65 @@
>> +choice
>> +	bool "External toolchain kernel headers"
>> +	depends on BR2_TOOLCHAIN_EXTERNAL_CUSTOM
>> +	default BR2_TOOLCHAIN_EXTERNAL_HEADERS_REALLY_OLD
>> +
> 
> Shouldn't there be a help text explaining what this is used for, so as to remove confusion about the fact that the kernel header version was already chosen when the toolchain was built?

 Note, however, that you can't add help text to a choice. So the only
option is to add the text to every choice option.

 Ah, the limitations of Kconfig...


 Regards,
 Arnout


> 
> Best regards,
> Thomas
> 
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2014-02-17 22:45 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-16 17:27 [Buildroot] [PATCH 0/10] Add dependency on kernel headers Yann E. MORIN
2014-02-16 17:27 ` [Buildroot] [PATCH 01/10] toolchain/common: add minimum kernel headers options Yann E. MORIN
2014-02-17 22:33   ` Arnout Vandecappelle
2014-02-16 17:27 ` [Buildroot] [PATCH 02/10] manual: document minimal kernel headers dependency Yann E. MORIN
2014-02-16 17:41   ` Samuel Martin
2014-02-16 17:52     ` Yann E. MORIN
2014-02-16 20:03   ` Thomas De Schampheleire
2014-02-16 20:42     ` Yann E. MORIN
2014-02-16 20:45       ` Thomas De Schampheleire
2014-02-16 20:55         ` Yann E. MORIN
2014-02-16 17:27 ` [Buildroot] [PATCH 03/10] package/linux-headers: select appropriate 'AT_LEAST_XXX' header version Yann E. MORIN
2014-02-17 22:41   ` Arnout Vandecappelle
2014-02-20 18:16     ` Yann E. MORIN
2014-02-20 20:17       ` Thomas Petazzoni
2014-02-20 21:06         ` Thomas De Schampheleire
2014-02-20 21:11           ` Yann E. MORIN
2014-02-16 17:27 ` [Buildroot] [PATCH 04/10] toolchain/external: add choice to select " Yann E. MORIN
2014-02-16 20:08   ` Thomas De Schampheleire
2014-02-16 20:47     ` Yann E. MORIN
2014-02-17  8:07       ` Thomas De Schampheleire
2014-02-17 10:30         ` Thomas Petazzoni
2014-02-17 10:32           ` Thomas De Schampheleire
2014-02-17 10:44             ` Thomas Petazzoni
2014-02-17 18:04           ` Yann E. MORIN
2014-02-17 22:49             ` Thomas Petazzoni
2014-02-17 23:10               ` Arnout Vandecappelle
2014-02-17 18:02         ` Yann E. MORIN
2014-02-17 22:45     ` Arnout Vandecappelle [this message]
2014-02-17 23:00       ` Yann E. MORIN
2014-02-17 23:14         ` Arnout Vandecappelle
2014-02-16 17:27 ` [Buildroot] [PATCH 05/10] " Yann E. MORIN
2014-02-17 22:47   ` Arnout Vandecappelle
2014-02-16 17:27 ` [Buildroot] [PATCH 06/10] package/dvb-apps: requires kernel headers >= 3.3 Yann E. MORIN
2014-02-17 22:51   ` Arnout Vandecappelle
2014-02-17 23:24     ` Yann E. MORIN
2014-02-16 17:27 ` [Buildroot] [PATCH 07/10] package/w_scan: requires kernel headers >= 3.0 Yann E. MORIN
2014-02-16 17:27 ` [Buildroot] [PATCH 08/10] package/weston: " Yann E. MORIN
2014-02-16 17:27 ` [Buildroot] [PATCH 09/10] package/tvheadend: requires kernel headers >= 3.2 Yann E. MORIN
2014-02-16 17:27 ` [Buildroot] [PATCH 10/10] package/mmc-utils: requires kernel headers >= 3.0 Yann E. MORIN
2014-02-16 17:36 ` [Buildroot] [PATCH 0/10] Add dependency on kernel headers Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530290F4.1060507@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox