[Buildroot] [PATCH 1/2] tvheadend: fix error compiling with ccache

[Buildroot] [PATCH 1/2] tvheadend: fix error compiling with ccache

[Martin Bark]

The tvheadend configure script fails to correctly handle spaces in any of
the options passed to it.  If ccache is used the configure script fails to
handle the space in the --cc option and errors.  Also the --cflags option
fails to handle multiple entries and only uses the first one.  This patch
simple removes setting the --cc and --cflags options as the configure
script will correctly use the CC and CFLAGS variables already passed in
TARGET_CONFIGURE_OPTS.

Signed-off-by: Martin Bark <martin@barkynet.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
---
 package/tvheadend/tvheadend.mk |    2 --
 1 file changed, 2 deletions(-)

diff --git a/package/tvheadend/tvheadend.mk b/package/tvheadend/tvheadend.mk
index 43bc382..85240a0 100644
--- a/package/tvheadend/tvheadend.mk
+++ b/package/tvheadend/tvheadend.mk
@@ -28,8 +28,6 @@ define TVHEADEND_CONFIGURE_CMDS
 	 $(TARGET_CONFIGURE_ARGS)		\
 	 ./configure				\
 	 --prefix=/usr				\
-	 --cc="$(TARGET_CC)"			\
-	 --cflags="$(TARGET_CFLAGS)"		\
 	 --arch="$(ARCH)"			\
 	 --cpu="$(BR2_GCC_TARGET_CPU)"		\
 	 --python="$(HOST_DIR)/usr/bin/python"	\
-- 
1.7.9.5

[Buildroot] [PATCH 1/2] tvheadend: fix error compiling with ccache

[Peter Korsgaard]

>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:

 > The tvheadend configure script fails to correctly handle spaces in any of
 > the options passed to it.  If ccache is used the configure script fails to
 > handle the space in the --cc option and errors.  Also the --cflags option
 > fails to handle multiple entries and only uses the first one.  This patch
 > simple removes setting the --cc and --cflags options as the configure
 > script will correctly use the CC and CFLAGS variables already passed in
 > TARGET_CONFIGURE_OPTS.

 > Signed-off-by: Martin Bark <martin@barkynet.com>
 > Cc: Yann E. MORIN <yann.morin.1998@free.fr>

Committed, thanks.

Is there supposed to be a patch 2/2 somewhere?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 1/2] tvheadend: fix error compiling with ccache

[Martin Bark]

Peter,

On 21/02/14 21:07, Peter Korsgaard wrote:
>>>>>> "Martin" == Martin Bark <martin@barkynet.com> writes:
>
>   > The tvheadend configure script fails to correctly handle spaces in any of
>   > the options passed to it.  If ccache is used the configure script fails to
>   > handle the space in the --cc option and errors.  Also the --cflags option
>   > fails to handle multiple entries and only uses the first one.  This patch
>   > simple removes setting the --cc and --cflags options as the configure
>   > script will correctly use the CC and CFLAGS variables already passed in
>   > TARGET_CONFIGURE_OPTS.
>
>   > Signed-off-by: Martin Bark <martin@barkynet.com>
>   > Cc: Yann E. MORIN <yann.morin.1998@free.fr>
>
> Committed, thanks.
>
> Is there supposed to be a patch 2/2 somewhere?
>

Thanks.  I was going to submit a 2nd patch to bump the version but then 
decided against it because i got confused.  The tvheadend version 
numbers seem a mess.

Martin