Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test
Date: Sun, 23 Feb 2014 23:52:07 +0100	[thread overview]
Message-ID: <530A7B97.3090701@openwide.fr> (raw)
In-Reply-To: <530A74F4.8030906@mind.be>

Hi Arnout,
Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :
> On 02/21/14 22:00, Romain Naour wrote:
>> The cross-compilation test is based on the ability to run
>> a test program on the host, which is wrong.
>>
>> If it runs, then the configure script concludes
>> that we're doing native compilation,
>> if it doesn't run, we're doing cross-compilation.
>>
>> The configure script needs to be regenerated to fix the
>> cross-compilation test.
>>
>> Fixes
>> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>>   package/ncftp/ncftp.mk | 8 ++++++++
>   Looks like the patch file itself got lost in this revision...

Thanks to the advice of ThomasP, the patch file is no longer necessary 
since the configure script is regenerated correctly by autoconf.
I tested this patch in the same conditions as for ncftp build errors 
(with a chrootwhere ncurses was not installed on the host)

Best regards,
Romain

>
>
>   Regards,
>   Arnout
>
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
>> index ff6c70a..841c82b 100644
>> --- a/package/ncftp/ncftp.mk
>> +++ b/package/ncftp/ncftp.mk
>> @@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
>>   NCFTP_LICENSE = Clarified Artistic License
>>   NCFTP_LICENSE_FILES = doc/LICENSE.txt
>>   
>> +NCFTP_DEPENDENCIES = host-autoconf
>> +
>> +define NCFTP_RUN_AUTOCONF
>> +       (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
>> +endef
>> +
>> +NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
>> +
>>   ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
>>   	NCFTP_TARGET_BINS += ncftpget
>>   endif
>>
>

  reply	other threads:[~2014-02-23 22:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21 21:00 [Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test Romain Naour
2014-02-21 22:57 ` Thomas Petazzoni
2014-02-21 23:41 ` Peter Korsgaard
2014-02-23 22:23 ` Arnout Vandecappelle
2014-02-23 22:52   ` Romain Naour [this message]
2014-02-25 17:13     ` Arnout Vandecappelle
2014-02-26 21:05       ` Romain Naour
2014-02-26 21:23         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530A7B97.3090701@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox