[Buildroot] [PATCH v3 1/1] ncftp: fix cross-compilation test

[Romain Naour <romain.naour@openwide.fr>]

Hi Arnout, All
Le 25/02/2014 18:13, Arnout Vandecappelle a ?crit :
> On 23/02/14 23:52, Romain Naour wrote:
>> Hi Arnout,
>> Le 23/02/2014 23:23, Arnout Vandecappelle a ?crit :
>>> On 02/21/14 22:00, Romain Naour wrote:
>>>> The cross-compilation test is based on the ability to run
>>>> a test program on the host, which is wrong.
>>>>
>>>> If it runs, then the configure script concludes
>>>> that we're doing native compilation,
>>>> if it doesn't run, we're doing cross-compilation.
>>>>
>>>> The configure script needs to be regenerated to fix the
>>>> cross-compilation test.
>>>>
>>>> Fixes
>>>> http://autobuild.buildroot.net/results/969/969a49ae97a50634ea846a82b9c360e4fb020ace/build-end.log
>>>>
>>>>
>>>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>>>> ---
>>>>    package/ncftp/ncftp.mk | 8 ++++++++
>>>    Looks like the patch file itself got lost in this revision...
>> Thanks to the advice of ThomasP, the patch file is no longer necessary
>> since the configure script is regenerated correctly by autoconf.
>> I tested this patch in the same conditions as for ncftp build errors
>> (with a chrootwhere ncurses was not installed on the host)
>   OK, now I understand.
>
>   I'm going to send a follow-up patch to clarify this. Otherwise, an
> eventual version bumper will have a hard time understanding what is going on.
>
You are right, the problem is not obvious and
I should have written a comment in addition to the commit log.

I wonder if any other packages can be affected by this issue ?
At least we know that autoconf 2.13 is not safe for cross-compilation...

Thank you for clarifying this issue :)

Best regards,
Romain

>>>>    1 file changed, 8 insertions(+)
>>>>
>>>> diff --git a/package/ncftp/ncftp.mk b/package/ncftp/ncftp.mk
>>>> index ff6c70a..841c82b 100644
>>>> --- a/package/ncftp/ncftp.mk
>>>> +++ b/package/ncftp/ncftp.mk
>>>> @@ -11,6 +11,14 @@ NCFTP_TARGET_BINS = ncftp
>>>>    NCFTP_LICENSE = Clarified Artistic License
>>>>    NCFTP_LICENSE_FILES = doc/LICENSE.txt
>>>>    +NCFTP_DEPENDENCIES = host-autoconf
>>>> +
>>>> +define NCFTP_RUN_AUTOCONF
>>>> +       (cd $(@D); $(HOST_DIR)/usr/bin/autoconf -I$(@D)/autoconf_local/)
>>>> +endef
>>>> +
>>>> +NCFTP_PRE_CONFIGURE_HOOKS += NCFTP_RUN_AUTOCONF
>>>> +
>>>>    ifeq ($(BR2_PACKAGE_NCFTP_GET),y)
>>>>        NCFTP_TARGET_BINS += ncftpget
>>>>    endif
>>>>
>>
>