* [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing
@ 2014-02-24 9:25 Eric Le Bihan
2014-02-24 9:25 ` [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra Eric Le Bihan
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Eric Le Bihan @ 2014-02-24 9:25 UTC (permalink / raw)
To: buildroot
This patch series contains enhancements for systemd, udev and eudev, intended
for next branch:
- use of proper virtual package infrastructure (suggested by Arnout).
- enable required kernel features for systemd (suggested by SamuelM).
Changes v1 -> v2:
- reworked systemd help text (suggested by ThomasP).
- removed shell commands in virtual package infra (suggested by ThomasP).
Best regards,
ELB
Eric Le Bihan (2):
udev: update udev to new virtual package infra.
systemd: enable required kernel features.
linux/linux.mk | 6 +++++-
package/eudev/Config.in | 3 +++
package/systemd/Config.in | 19 +++++++++++++++++--
package/udev/Config.in | 8 ++++----
package/udev/udev.mk | 16 ++++------------
5 files changed, 33 insertions(+), 19 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 8+ messages in thread* [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra. 2014-02-24 9:25 [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Eric Le Bihan @ 2014-02-24 9:25 ` Eric Le Bihan 2014-02-25 16:59 ` Arnout Vandecappelle 2014-02-24 9:25 ` [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features Eric Le Bihan 2014-02-25 20:29 ` [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Peter Korsgaard 2 siblings, 1 reply; 8+ messages in thread From: Eric Le Bihan @ 2014-02-24 9:25 UTC (permalink / raw) To: buildroot The udev virtual package and its current providers (eudev and systemd) have been updated to use the latest version of virtual package infrastructure. A provider should now select BR2_PACKAGE_HAS_UDEV and well as set a value for BR2_PACKAGE_PROVIDES_UDEV. Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> --- package/eudev/Config.in | 3 +++ package/systemd/Config.in | 3 +++ package/udev/Config.in | 8 ++++---- package/udev/udev.mk | 16 ++++------------ 4 files changed, 14 insertions(+), 16 deletions(-) diff --git a/package/eudev/Config.in b/package/eudev/Config.in index bfad99a..40ff721 100644 --- a/package/eudev/Config.in +++ b/package/eudev/Config.in @@ -21,6 +21,9 @@ config BR2_PACKAGE_EUDEV if BR2_PACKAGE_EUDEV +config BR2_PACKAGE_PROVIDES_UDEV + default "eudev" + config BR2_PACKAGE_EUDEV_RULES_GEN bool "enable rules generator" help diff --git a/package/systemd/Config.in b/package/systemd/Config.in index e3ea433..eacc23c 100644 --- a/package/systemd/Config.in +++ b/package/systemd/Config.in @@ -40,6 +40,9 @@ config BR2_PACKAGE_SYSTEMD if BR2_PACKAGE_SYSTEMD +config BR2_PACKAGE_PROVIDES_UDEV + default "systemd" + config BR2_PACKAGE_SYSTEMD_ALL_EXTRAS bool "enable all extras" select BR2_PACKAGE_XZ diff --git a/package/udev/Config.in b/package/udev/Config.in index 5cd4051..941a515 100644 --- a/package/udev/Config.in +++ b/package/udev/Config.in @@ -1,6 +1,6 @@ config BR2_PACKAGE_HAS_UDEV bool - help - udev is now a virtual package. - Packages requiring udevd at run time or libudev/gudev at build time - should select it. + +config BR2_PACKAGE_PROVIDES_UDEV + depends on BR2_PACKAGE_HAS_UDEV + string diff --git a/package/udev/udev.mk b/package/udev/udev.mk index a5d0f80..f5eeeb4 100644 --- a/package/udev/udev.mk +++ b/package/udev/udev.mk @@ -5,20 +5,12 @@ ################################################################################ UDEV_SOURCE = +UDEV_DEPENDENCIES = $(call qstrip,$(BR2_PACKAGE_PROVIDES_UDEV)) -ifeq ($(BR2_PACKAGE_EUDEV),y) -UDEV_DEPENDENCIES += eudev -endif - -ifeq ($(BR2_PACKAGE_SYSTEMD),y) -UDEV_DEPENDENCIES += systemd -endif - +ifeq ($(BR2_PACKAGE_HAS_UDEV),y) ifeq ($(UDEV_DEPENDENCIES),) -define UDEV_CONFIGURE_CMDS - echo "No Udev implementation selected. Configuration error." - exit 1 -endef +$(error No Udev implementation selected. Configuration error) +endif endif $(eval $(generic-package)) -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra. 2014-02-24 9:25 ` [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra Eric Le Bihan @ 2014-02-25 16:59 ` Arnout Vandecappelle 2014-02-25 20:28 ` Samuel Martin 0 siblings, 1 reply; 8+ messages in thread From: Arnout Vandecappelle @ 2014-02-25 16:59 UTC (permalink / raw) To: buildroot On 24/02/14 10:25, Eric Le Bihan wrote: > The udev virtual package and its current providers (eudev and systemd) > have been updated to use the latest version of virtual package > infrastructure. > > A provider should now select BR2_PACKAGE_HAS_UDEV and well as set a > value for BR2_PACKAGE_PROVIDES_UDEV. > > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > --- > package/eudev/Config.in | 3 +++ > package/systemd/Config.in | 3 +++ > package/udev/Config.in | 8 ++++---- > package/udev/udev.mk | 16 ++++------------ > 4 files changed, 14 insertions(+), 16 deletions(-) > > diff --git a/package/eudev/Config.in b/package/eudev/Config.in > index bfad99a..40ff721 100644 > --- a/package/eudev/Config.in > +++ b/package/eudev/Config.in > @@ -21,6 +21,9 @@ config BR2_PACKAGE_EUDEV > > if BR2_PACKAGE_EUDEV > > +config BR2_PACKAGE_PROVIDES_UDEV > + default "eudev" > + > config BR2_PACKAGE_EUDEV_RULES_GEN > bool "enable rules generator" > help > diff --git a/package/systemd/Config.in b/package/systemd/Config.in > index e3ea433..eacc23c 100644 > --- a/package/systemd/Config.in > +++ b/package/systemd/Config.in > @@ -40,6 +40,9 @@ config BR2_PACKAGE_SYSTEMD > > if BR2_PACKAGE_SYSTEMD > > +config BR2_PACKAGE_PROVIDES_UDEV > + default "systemd" > + > config BR2_PACKAGE_SYSTEMD_ALL_EXTRAS > bool "enable all extras" > select BR2_PACKAGE_XZ > diff --git a/package/udev/Config.in b/package/udev/Config.in > index 5cd4051..941a515 100644 > --- a/package/udev/Config.in > +++ b/package/udev/Config.in > @@ -1,6 +1,6 @@ > config BR2_PACKAGE_HAS_UDEV > bool > - help > - udev is now a virtual package. > - Packages requiring udevd at run time or libudev/gudev at build time > - should select it. > + > +config BR2_PACKAGE_PROVIDES_UDEV > + depends on BR2_PACKAGE_HAS_UDEV > + string > diff --git a/package/udev/udev.mk b/package/udev/udev.mk > index a5d0f80..f5eeeb4 100644 > --- a/package/udev/udev.mk > +++ b/package/udev/udev.mk > @@ -5,20 +5,12 @@ > ################################################################################ > > UDEV_SOURCE = > +UDEV_DEPENDENCIES = $(call qstrip,$(BR2_PACKAGE_PROVIDES_UDEV)) > > -ifeq ($(BR2_PACKAGE_EUDEV),y) > -UDEV_DEPENDENCIES += eudev > -endif > - > -ifeq ($(BR2_PACKAGE_SYSTEMD),y) > -UDEV_DEPENDENCIES += systemd > -endif > - > +ifeq ($(BR2_PACKAGE_HAS_UDEV),y) > ifeq ($(UDEV_DEPENDENCIES),) > -define UDEV_CONFIGURE_CMDS > - echo "No Udev implementation selected. Configuration error." > - exit 1 > -endef > +$(error No Udev implementation selected. Configuration error) > +endif > endif > > $(eval $(generic-package)) > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra. 2014-02-25 16:59 ` Arnout Vandecappelle @ 2014-02-25 20:28 ` Samuel Martin 0 siblings, 0 replies; 8+ messages in thread From: Samuel Martin @ 2014-02-25 20:28 UTC (permalink / raw) To: buildroot On Tue, Feb 25, 2014 at 5:59 PM, Arnout Vandecappelle <arnout@mind.be> wrote: > On 24/02/14 10:25, Eric Le Bihan wrote: >> The udev virtual package and its current providers (eudev and systemd) >> have been updated to use the latest version of virtual package >> infrastructure. >> >> A provider should now select BR2_PACKAGE_HAS_UDEV and well as set a >> value for BR2_PACKAGE_PROVIDES_UDEV. >> >> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Reviewed-by: Samuel Martin <s.martin49@gmail.com> Regards, -- Samuel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features. 2014-02-24 9:25 [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Eric Le Bihan 2014-02-24 9:25 ` [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra Eric Le Bihan @ 2014-02-24 9:25 ` Eric Le Bihan 2014-02-25 17:04 ` Arnout Vandecappelle 2014-02-25 20:29 ` [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Peter Korsgaard 2 siblings, 1 reply; 8+ messages in thread From: Eric Le Bihan @ 2014-02-24 9:25 UTC (permalink / raw) To: buildroot When systemd is chosen as init system, the required kernel features are enabled. Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> --- linux/linux.mk | 6 +++++- package/systemd/Config.in | 16 ++++++++++++++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/linux/linux.mk b/linux/linux.mk index d7f51b3..f948e6c 100644 --- a/linux/linux.mk +++ b/linux/linux.mk @@ -195,7 +195,11 @@ define LINUX_CONFIGURE_CMDS $(call KCONFIG_ENABLE_OPT,CONFIG_FUNCTION_TRACER,$(@D)/.config)) $(if $(BR2_PACKAGE_SYSTEMD), $(call KCONFIG_ENABLE_OPT,CONFIG_CGROUPS,$(@D)/.config) - $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)) + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_FHANDLE,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_AUTOFS4_FS,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_ACL,$(@D)/.config) + $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_XATTR,$(@D)/.config)) $(if $(BR2_LINUX_KERNEL_APPENDED_DTB), $(call KCONFIG_ENABLE_OPT,CONFIG_ARM_APPENDED_DTB,$(@D)/.config)) yes '' | $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) oldconfig diff --git a/package/systemd/Config.in b/package/systemd/Config.in index eacc23c..4f180a1 100644 --- a/package/systemd/Config.in +++ b/package/systemd/Config.in @@ -26,8 +26,20 @@ config BR2_PACKAGE_SYSTEMD elaborate transactional dependency-based service control logic. It can work as a drop-in replacement for sysvinit. - Systemd requires a Linux kernel >= 3.0, with inotify, devtmpfs, - tmpfs vfs and tmpfs POSIX ACL enabled. + Systemd requires a Linux kernel >= 3.0 with the following options + enabled: + + - CONFIG_CGROUPS + - CONFIG_INOTIFY_USER + - CONFIG_FHANDLE + - CONFIG_AUTOFS4_FS + - CONFIG_TMPFS_POSIX_ACL + - CONFIG_TMPFS_XATTR + + These options will be automatically enabled by Buildroot if + it is responsible for building the kernel. Otherwise, if you + are building your kernel outside of Buildroot, make sure + these options are enabled. Systemd also provides udev, the userspace device daemon. -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features. 2014-02-24 9:25 ` [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features Eric Le Bihan @ 2014-02-25 17:04 ` Arnout Vandecappelle 2014-02-25 20:32 ` Samuel Martin 0 siblings, 1 reply; 8+ messages in thread From: Arnout Vandecappelle @ 2014-02-25 17:04 UTC (permalink / raw) To: buildroot On 24/02/14 10:25, Eric Le Bihan wrote: > When systemd is chosen as init system, the required kernel features are > enabled. > > Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> However, it would be good to add the same information to the end of docs/manual/configure.txt Regards, Arnout > --- > linux/linux.mk | 6 +++++- > package/systemd/Config.in | 16 ++++++++++++++-- > 2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/linux/linux.mk b/linux/linux.mk > index d7f51b3..f948e6c 100644 > --- a/linux/linux.mk > +++ b/linux/linux.mk > @@ -195,7 +195,11 @@ define LINUX_CONFIGURE_CMDS > $(call KCONFIG_ENABLE_OPT,CONFIG_FUNCTION_TRACER,$(@D)/.config)) > $(if $(BR2_PACKAGE_SYSTEMD), > $(call KCONFIG_ENABLE_OPT,CONFIG_CGROUPS,$(@D)/.config) > - $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config)) > + $(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config) > + $(call KCONFIG_ENABLE_OPT,CONFIG_FHANDLE,$(@D)/.config) > + $(call KCONFIG_ENABLE_OPT,CONFIG_AUTOFS4_FS,$(@D)/.config) > + $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_ACL,$(@D)/.config) > + $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_XATTR,$(@D)/.config)) > $(if $(BR2_LINUX_KERNEL_APPENDED_DTB), > $(call KCONFIG_ENABLE_OPT,CONFIG_ARM_APPENDED_DTB,$(@D)/.config)) > yes '' | $(TARGET_MAKE_ENV) $(MAKE1) $(LINUX_MAKE_FLAGS) -C $(@D) oldconfig > diff --git a/package/systemd/Config.in b/package/systemd/Config.in > index eacc23c..4f180a1 100644 > --- a/package/systemd/Config.in > +++ b/package/systemd/Config.in > @@ -26,8 +26,20 @@ config BR2_PACKAGE_SYSTEMD > elaborate transactional dependency-based service control logic. > It can work as a drop-in replacement for sysvinit. > > - Systemd requires a Linux kernel >= 3.0, with inotify, devtmpfs, > - tmpfs vfs and tmpfs POSIX ACL enabled. > + Systemd requires a Linux kernel >= 3.0 with the following options > + enabled: > + > + - CONFIG_CGROUPS > + - CONFIG_INOTIFY_USER > + - CONFIG_FHANDLE > + - CONFIG_AUTOFS4_FS > + - CONFIG_TMPFS_POSIX_ACL > + - CONFIG_TMPFS_XATTR > + > + These options will be automatically enabled by Buildroot if > + it is responsible for building the kernel. Otherwise, if you > + are building your kernel outside of Buildroot, make sure > + these options are enabled. > > Systemd also provides udev, the userspace device daemon. > > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features. 2014-02-25 17:04 ` Arnout Vandecappelle @ 2014-02-25 20:32 ` Samuel Martin 0 siblings, 0 replies; 8+ messages in thread From: Samuel Martin @ 2014-02-25 20:32 UTC (permalink / raw) To: buildroot On Tue, Feb 25, 2014 at 6:04 PM, Arnout Vandecappelle <arnout@mind.be> wrote: > On 24/02/14 10:25, Eric Le Bihan wrote: >> When systemd is chosen as init system, the required kernel features are >> enabled. >> >> Signed-off-by: Eric Le Bihan <eric.le.bihan.dev@free.fr> > > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Reviewed-by: Samuel Martin <s.martin49@gmail.com> > > However, it would be good to add the same information to the end of > docs/manual/configure.txt May be good indeed, but it can be done in another patch. Regards, -- Samuel ^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing 2014-02-24 9:25 [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Eric Le Bihan 2014-02-24 9:25 ` [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra Eric Le Bihan 2014-02-24 9:25 ` [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features Eric Le Bihan @ 2014-02-25 20:29 ` Peter Korsgaard 2 siblings, 0 replies; 8+ messages in thread From: Peter Korsgaard @ 2014-02-25 20:29 UTC (permalink / raw) To: buildroot >>>>> "Eric" == Eric Le Bihan <eric.le.bihan.dev@free.fr> writes: > This patch series contains enhancements for systemd, udev and eudev, intended > for next branch: > - use of proper virtual package infrastructure (suggested by Arnout). > - enable required kernel features for systemd (suggested by SamuelM). > Changes v1 -> v2: > - reworked systemd help text (suggested by ThomasP). > - removed shell commands in virtual package infra (suggested by ThomasP). Committed both to next, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-02-25 20:32 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-02-24 9:25 [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Eric Le Bihan 2014-02-24 9:25 ` [Buildroot] [PATCH v2 1/2] udev: update udev to new virtual package infra Eric Le Bihan 2014-02-25 16:59 ` Arnout Vandecappelle 2014-02-25 20:28 ` Samuel Martin 2014-02-24 9:25 ` [Buildroot] [PATCH v2 2/2] systemd: enable required kernel features Eric Le Bihan 2014-02-25 17:04 ` Arnout Vandecappelle 2014-02-25 20:32 ` Samuel Martin 2014-02-25 20:29 ` [Buildroot] [PATCH v2 0/2] systemd/udev/eudev polishing Peter Korsgaard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox