[Buildroot] [PATCH] gstreamer-imx: new package

[Buildroot] [PATCH] gstreamer-imx: new package

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/gstreamer1/Config.in                       |  1 +
 package/gstreamer1/gstreamer-imx/Config.in         | 21 ++++++++++++
 ...headers-include-path-to-src-v4l2src-compi.patch | 31 ++++++++++++++++++
 package/gstreamer1/gstreamer-imx/gstreamer-imx.mk  | 37 ++++++++++++++++++++++
 4 files changed, 90 insertions(+)
 create mode 100644 package/gstreamer1/gstreamer-imx/Config.in
 create mode 100644 package/gstreamer1/gstreamer-imx/gstreamer-imx-0001-Add-kernel-headers-include-path-to-src-v4l2src-compi.patch
 create mode 100644 package/gstreamer1/gstreamer-imx/gstreamer-imx.mk

diff --git a/package/gstreamer1/Config.in b/package/gstreamer1/Config.in
index fe0ad48..0068a8f 100644
--- a/package/gstreamer1/Config.in
+++ b/package/gstreamer1/Config.in
@@ -8,4 +8,5 @@ source "package/gstreamer1/gst1-plugins-bad/Config.in"
 source "package/gstreamer1/gst1-plugins-ugly/Config.in"
 source "package/gstreamer1/gst1-libav/Config.in"
 source "package/gstreamer1/gst-omx/Config.in"
+source "package/gstreamer1/gstreamer-imx/Config.in"
 endif
diff --git a/package/gstreamer1/gstreamer-imx/Config.in b/package/gstreamer1/gstreamer-imx/Config.in
new file mode 100644
index 0000000..bcd77ca
--- /dev/null
+++ b/package/gstreamer1/gstreamer-imx/Config.in
@@ -0,0 +1,21 @@
+comment "gst-fsl-plugins needs an imx-specific Linux kernel to be built"
+	depends on BR2_arm && !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_GSTREAMER_IMX
+	bool "gstreamer-imx"
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_arm # Only relevant for i.MX
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_IMX_LIB
+	select BR2_PACKAGE_LIBFSLPARSER
+	select BR2_PACKAGE_LIBFSLCODEC
+	help
+	  GStreamer-1.x plugins for hardware-accelerated audio and video
+	  parsers and codecs on i.MX6 platform. It requires a kernel that
+	  includes the i.MX6 specific headers to be built.
+
+	  To use the VPU, its firmware blob must be installed as well. This
+	  can be found in the firmware-imx package in the "Hardware handling"
+	  menu.
+
+	  https://github.com/Freescale/gstreamer-imx
diff --git a/package/gstreamer1/gstreamer-imx/gstreamer-imx-0001-Add-kernel-headers-include-path-to-src-v4l2src-compi.patch b/package/gstreamer1/gstreamer-imx/gstreamer-imx-0001-Add-kernel-headers-include-path-to-src-v4l2src-compi.patch
new file mode 100644
index 0000000..48e2c16
--- /dev/null
+++ b/package/gstreamer1/gstreamer-imx/gstreamer-imx-0001-Add-kernel-headers-include-path-to-src-v4l2src-compi.patch
@@ -0,0 +1,31 @@
+From 107767b506de69692436205c04a002e5de0f7bee Mon Sep 17 00:00:00 2001
+From: Peter Seiderer <ps.report@gmx.net>
+Date: Sat, 22 Feb 2014 23:22:26 +0100
+Subject: [PATCH] Add kernel headers include path to src/v4l2src compile.
+
+Fixes buildroot compile with newer sysroot kernel headers
+(> 3.10 because of VIDIOC_DBG_G_CHIP_IDENT ioctl removale).
+
+Signed-off-by: Peter Seiderer <ps.report@gmx.net>
+---
+ src/v4l2src/wscript | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/src/v4l2src/wscript b/src/v4l2src/wscript
+index 0b8fbb1..3013ba7 100644
+--- a/src/v4l2src/wscript
++++ b/src/v4l2src/wscript
+@@ -2,7 +2,9 @@
+ 
+ 
+ def configure(conf):
+-	pass
++	import os
++	if conf.options.kernel_headers:
++		conf.env.append_value('INCLUDES', [os.path.abspath(os.path.expanduser(conf.options.kernel_headers))])
+ 
+ 
+ def build(bld):
+-- 
+1.8.1.4
+
diff --git a/package/gstreamer1/gstreamer-imx/gstreamer-imx.mk b/package/gstreamer1/gstreamer-imx/gstreamer-imx.mk
new file mode 100644
index 0000000..3192056
--- /dev/null
+++ b/package/gstreamer1/gstreamer-imx/gstreamer-imx.mk
@@ -0,0 +1,37 @@
+################################################################################
+#
+# gstreamer-imx
+#
+################################################################################
+
+GSTREAMER_IMX_VERSION = 0.9.3
+GSTREAMER_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GSTREAMER_IMX_VERSION))
+
+GSTREAMER_IMX_LICENSE = LGPLv2+
+GSTREAMER_IMX_LICENSE_FILES = LICENSE
+
+GSTREAMER_IMX_DEPENDENCIES = gstreamer1 gst1-plugins-base libfslvpuwrap \
+	imx-lib libfslparser libfslcodec
+
+# needs access to imx-specific kernel headers
+GST_FSL_PLUGINS_DEPENDENCIES += linux
+
+define GSTREAMER_IMX_CONFIGURE_CMDS
+	$(GSTREAMER_IMX_WITHOUT_X11)
+	(cd $(@D); \
+		$(TARGET_CONFIGURE_OPTS) \
+		./waf configure \
+		--prefix=/usr \
+		--kernel-headers=$(LINUX_DIR)/include \
+	)
+endef
+
+define GSTREAMER_IMX_BUILD_CMDS
+       (cd $(@D); ./waf build -j $(PARALLEL_JOBS))
+endef
+
+define GSTREAMER_IMX_INSTALL_TARGET_CMDS
+       (cd $(@D); ./waf --destdir=$(TARGET_DIR) install)
+endef
+
+$(eval $(generic-package))
-- 
1.8.1.4

[Buildroot] [PATCH] gstreamer-imx: new package

[Yann E. MORIN]

Peter, All,

On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

How is gstreamer-imx different from gst-fsl-plugins?

From package/gstreamer/gst-fsl-plugins/Config.in:

    GStreamer plugins for hardware-accelerated audio and video
    parsers and codecs on i.MX platforms. [...]

So, it seems we already have a package that handles accelerated
audio/video decoding on i.MX.

[--SNIP--]
> diff --git a/package/gstreamer1/gstreamer-imx/Config.in b/package/gstreamer1/gstreamer-imx/Config.in
> new file mode 100644
> index 0000000..bcd77ca
> --- /dev/null
> +++ b/package/gstreamer1/gstreamer-imx/Config.in
> @@ -0,0 +1,21 @@
> +comment "gst-fsl-plugins needs an imx-specific Linux kernel to be built"
> +	depends on BR2_arm && !BR2_LINUX_KERNEL
> +
> +config BR2_PACKAGE_GSTREAMER_IMX
> +	bool "gstreamer-imx"
> +	depends on BR2_LINUX_KERNEL
> +	depends on BR2_arm # Only relevant for i.MX
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE
> +	select BR2_PACKAGE_IMX_LIB
> +	select BR2_PACKAGE_LIBFSLPARSER
> +	select BR2_PACKAGE_LIBFSLCODEC
> +	help
> +	  GStreamer-1.x plugins for hardware-accelerated audio and video
> +	  parsers and codecs on i.MX6 platform. It requires a kernel that
> +	  includes the i.MX6 specific headers to be built.
> +
> +	  To use the VPU, its firmware blob must be installed as well. This
> +	  can be found in the firmware-imx package in the "Hardware handling"
> +	  menu.

You even use a very similar wording in the help text.

Care to elaborate in the commit log why we need this gstreamer-imx
package:
  - is it specific to i.MX6?
  - can it replace the existing gst-fsl-plugins?

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] gstreamer-imx: new package

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:
 >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

 > How is gstreamer-imx different from gst-fsl-plugins?

 >> From package/gstreamer/gst-fsl-plugins/Config.in:

 >     GStreamer plugins for hardware-accelerated audio and video
 >     parsers and codecs on i.MX platforms. [...]

 > So, it seems we already have a package that handles accelerated
 > audio/video decoding on i.MX.

Yes, but gst-fsl-plugins is for the deprecated gstreamer 0.10.x series,
this is for gstreamer 1.x.

 >> diff --git a/package/gstreamer1/gstreamer-imx/Config.in b/package/gstreamer1/gstreamer-imx/Config.in

Which is also why it is under package/gstreamer1. Perhaps the package
should be called gstreamer1-imx to make it completely clear.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] gstreamer-imx: new package

[Samuel Martin]

On Tue, Feb 25, 2014 at 9:09 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>
>  > Peter, All,
>  > On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:
>  >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
>  > How is gstreamer-imx different from gst-fsl-plugins?
>
>  >> From package/gstreamer/gst-fsl-plugins/Config.in:
>
>  >     GStreamer plugins for hardware-accelerated audio and video
>  >     parsers and codecs on i.MX platforms. [...]
>
>  > So, it seems we already have a package that handles accelerated
>  > audio/video decoding on i.MX.
>
> Yes, but gst-fsl-plugins is for the deprecated gstreamer 0.10.x series,
> this is for gstreamer 1.x.
>
>  >> diff --git a/package/gstreamer1/gstreamer-imx/Config.in b/package/gstreamer1/gstreamer-imx/Config.in
>
> Which is also why it is under package/gstreamer1. Perhaps the package
> should be called gstreamer1-imx to make it completely clear.

I agree with the suggested rename

Regards,

-- 
Samuel

[Buildroot] [PATCH] gstreamer-imx: new package

[Arnout Vandecappelle]

On 25/02/14 21:19, Samuel Martin wrote:
> On Tue, Feb 25, 2014 at 9:09 PM, Peter Korsgaard <jacmet@uclibc.org> wrote:
>>>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
>>
>>  > Peter, All,
>>  > On 2014-02-24 22:50 +0100, Peter Seiderer spake thusly:
>>  >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>>
>>  > How is gstreamer-imx different from gst-fsl-plugins?
>>
>>  >> From package/gstreamer/gst-fsl-plugins/Config.in:
>>
>>  >     GStreamer plugins for hardware-accelerated audio and video
>>  >     parsers and codecs on i.MX platforms. [...]
>>
>>  > So, it seems we already have a package that handles accelerated
>>  > audio/video decoding on i.MX.
>>
>> Yes, but gst-fsl-plugins is for the deprecated gstreamer 0.10.x series,
>> this is for gstreamer 1.x.
>>
>>  >> diff --git a/package/gstreamer1/gstreamer-imx/Config.in b/package/gstreamer1/gstreamer-imx/Config.in
>>
>> Which is also why it is under package/gstreamer1. Perhaps the package
>> should be called gstreamer1-imx to make it completely clear.
> 
> I agree with the suggested rename

 We didn't do that for gst-omx, however. Does anyone remember why not?


 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F