* [Buildroot] [PATCH] pcsc-lite: not available for static builds
@ 2014-03-10 12:10 Vicente Olivert Riera
2014-03-11 22:38 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-03-10 12:10 UTC (permalink / raw)
To: buildroot
This package requires dlopen and checks for it in the configure phase.
If it's not present, then the build process is stopped.
Fixes:
http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/pcsc-lite/Config.in | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
index aab42e8..24981bd 100644
--- a/package/pcsc-lite/Config.in
+++ b/package/pcsc-lite/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
bool "pcsc-lite"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
+ depends on !BR2_PREFER_STATIC_LIB
help
Middleware to access smart card using SCard API (PC/SC).
@@ -31,3 +32,6 @@ endif
comment "pcsc-lite needs a toolchain w/ threads"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS
+
+comment "pcsc-lite needs a toolchain w/ dynamic library"
+ depends on BR2_PREFER_STATIC_LIB
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] pcsc-lite: not available for static builds
2014-03-10 12:10 [Buildroot] [PATCH] pcsc-lite: not available for static builds Vicente Olivert Riera
@ 2014-03-11 22:38 ` Peter Korsgaard
2014-03-12 10:08 ` Vicente Olivert Riera
0 siblings, 1 reply; 4+ messages in thread
From: Peter Korsgaard @ 2014-03-11 22:38 UTC (permalink / raw)
To: buildroot
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> This package requires dlopen and checks for it in the configure phase.
> If it's not present, then the build process is stopped.
> Fixes:
> http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/pcsc-lite/Config.in | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
> diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
> index aab42e8..24981bd 100644
> --- a/package/pcsc-lite/Config.in
> +++ b/package/pcsc-lite/Config.in
> @@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
> bool "pcsc-lite"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_USE_MMU # fork()
> + depends on !BR2_PREFER_STATIC_LIB
This dependency should also be propagated to the reverse dependencies of pcsc-lite.
> help
> Middleware to access smart card using SCard API (PC/SC).
> @@ -31,3 +32,6 @@ endif
> comment "pcsc-lite needs a toolchain w/ threads"
> depends on BR2_USE_MMU
> depends on !BR2_TOOLCHAIN_HAS_THREADS
> +
> +comment "pcsc-lite needs a toolchain w/ dynamic library"
> + depends on BR2_PREFER_STATIC_LIB
We normally merge all the toolchain dependency options together, E.G.:
comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
depends on BR2_USE_MMU
depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB
Committed with these changes, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] pcsc-lite: not available for static builds
2014-03-11 22:38 ` Peter Korsgaard
@ 2014-03-12 10:08 ` Vicente Olivert Riera
2014-03-12 10:14 ` Vicente Olivert Riera
0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-03-12 10:08 UTC (permalink / raw)
To: buildroot
On 03/11/2014 10:38 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> > This package requires dlopen and checks for it in the configure phase.
> > If it's not present, then the build process is stopped.
>
> > Fixes:
> > http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > ---
> > package/pcsc-lite/Config.in | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
>
> > diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
> > index aab42e8..24981bd 100644
> > --- a/package/pcsc-lite/Config.in
> > +++ b/package/pcsc-lite/Config.in
> > @@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
> > bool "pcsc-lite"
> > depends on BR2_TOOLCHAIN_HAS_THREADS
> > depends on BR2_USE_MMU # fork()
> > + depends on !BR2_PREFER_STATIC_LIB
>
> This dependency should also be propagated to the reverse dependencies of pcsc-lite.
Have you done this, or do you want I submit patches for it?
> > help
> > Middleware to access smart card using SCard API (PC/SC).
>
> > @@ -31,3 +32,6 @@ endif
> > comment "pcsc-lite needs a toolchain w/ threads"
> > depends on BR2_USE_MMU
> > depends on !BR2_TOOLCHAIN_HAS_THREADS
> > +
> > +comment "pcsc-lite needs a toolchain w/ dynamic library"
> > + depends on BR2_PREFER_STATIC_LIB
>
> We normally merge all the toolchain dependency options together, E.G.:
>
> comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
> depends on BR2_USE_MMU
> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB
>
> Committed with these changes, thanks.
>
--
Vincent
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] pcsc-lite: not available for static builds
2014-03-12 10:08 ` Vicente Olivert Riera
@ 2014-03-12 10:14 ` Vicente Olivert Riera
0 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-03-12 10:14 UTC (permalink / raw)
To: buildroot
On 03/12/2014 10:08 AM, Vicente Olivert Riera wrote:
> On 03/11/2014 10:38 PM, Peter Korsgaard wrote:
>>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>>>>>> writes:
>>
>> > This package requires dlopen and checks for it in the configure
>> phase.
>> > If it's not present, then the build process is stopped.
>>
>> > Fixes:
>> >
>> http://autobuild.buildroot.net/results/34b/34b83c3ea4a8aac6aeda225e5859bd318b13a676/
>>
>>
>> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> > ---
>> > package/pcsc-lite/Config.in | 4 ++++
>> > 1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> > diff --git a/package/pcsc-lite/Config.in
>> b/package/pcsc-lite/Config.in
>> > index aab42e8..24981bd 100644
>> > --- a/package/pcsc-lite/Config.in
>> > +++ b/package/pcsc-lite/Config.in
>> > @@ -2,6 +2,7 @@ config BR2_PACKAGE_PCSC_LITE
>> > bool "pcsc-lite"
>> > depends on BR2_TOOLCHAIN_HAS_THREADS
>> > depends on BR2_USE_MMU # fork()
>> > + depends on !BR2_PREFER_STATIC_LIB
>>
>> This dependency should also be propagated to the reverse dependencies
>> of pcsc-lite.
>
> Have you done this, or do you want I submit patches for it?
Forget it, I have seen the commit.
>
>> > help
>> > Middleware to access smart card using SCard API (PC/SC).
>>
>> > @@ -31,3 +32,6 @@ endif
>> > comment "pcsc-lite needs a toolchain w/ threads"
>> > depends on BR2_USE_MMU
>> > depends on !BR2_TOOLCHAIN_HAS_THREADS
>> > +
>> > +comment "pcsc-lite needs a toolchain w/ dynamic library"
>> > + depends on BR2_PREFER_STATIC_LIB
>>
>> We normally merge all the toolchain dependency options together, E.G.:
>>
>> comment "pcsc-lite needs a toolchain w/ threads, dynamic library"
>> depends on BR2_USE_MMU
>> depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB
>>
>> Committed with these changes, thanks.
>>
>
>
--
Vincent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-12 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-10 12:10 [Buildroot] [PATCH] pcsc-lite: not available for static builds Vicente Olivert Riera
2014-03-11 22:38 ` Peter Korsgaard
2014-03-12 10:08 ` Vicente Olivert Riera
2014-03-12 10:14 ` Vicente Olivert Riera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox