From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libtool: revert a commit which re-introduced an already fixed problem
Date: Wed, 19 Mar 2014 09:40:22 +0000 [thread overview]
Message-ID: <53296606.9070104@imgtec.com> (raw)
In-Reply-To: <53294D50.3040800@mind.be>
On 03/19/2014 07:54 AM, Arnout Vandecappelle wrote:
> On 03/18/14 11:44, Vicente Olivert Riera wrote:
>> On 03/18/2014 07:46 AM, Arnout Vandecappelle wrote:
>>> On 03/17/14 23:08, Peter Korsgaard wrote:
>>>>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>>>>>>>> writes:
>>>>
>>>> > The commit ed73d1d2e3703290e74bb076bc6dd0417aa3ba21 modified the
>>>> changes
>>>> > made by the commit 4268d3967e2d691c151d6b5629e4051deb077b9a. The
>>>> problem
>>>> > that was fixed by the former commit is present again due to those
>>>> > modifications. This patch reverts those modifications to have that
>>>> > problem fixed again.
>>>>
>>>> > Fixes:
>>>> >
>>>> http://autobuild.buildroot.net/results/b86/b86a83c6549004f226e7255242e54ef4e50c5ec3/
>>>>
>>>>
>>>> So this basically just reverts Arnouts fix for old automake versions? Do
>>>> we understand why it doesn't work? Can we come up with a solution that
>>>> both fixes the n64 issue and old automake?
>>>
>>> I indeed never tested if the issue of 4268d39 was still fixed. I just
>>> understood from the commit message that it is only relevant for the
>>> libtool.m4 that is installed in the host dir, so I made use of that.
>>>
>>> It should be rather easy to get this right then: a patch that fixes up
>>> configure directly, rather than libtool.m4.
>>
>> Hello Arnout,
>>
>> how do you suggest to do it? Requiring an older automake would not be
>> possible because of this:
>>
>> dnl These are bootstrap requirements! Once built, libtool may work with
>> dnl much older releases of autoconf and automake. See release notes.
>> dnl 1.11 is needed for color-tests, 1.11.1 fixes a security issue.
>> AM_INIT_AUTOMAKE([1.11.1 gnu subdir-objects dist-xz color-tests
>> parallel-tests])
>
> I meant: create a patch that fixes up the configure script directly.
>
> Can you give me a minimal defconfig that shows the problem (preferably
> using an external toolchain, e.g. from the autobuilders)? Then I can try
> to create that patch.
Hello Arnout,
unfortunately I don't have a minimal defconfig to reproduce that
failure. I use the one in the autobuild:
http://autobuild.buildroot.net/results/b86/b86a83c6549004f226e7255242e54ef4e50c5ec3/
Regards,
Vincent
> Regards,
> Arnout
>
>
> [snip]
>
>
--
Vincent
next prev parent reply other threads:[~2014-03-19 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 17:40 [Buildroot] [PATCH] libtool: revert a commit which re-introduced an already fixed problem Vicente Olivert Riera
2014-03-17 22:08 ` Peter Korsgaard
2014-03-18 7:46 ` Arnout Vandecappelle
2014-03-18 10:44 ` Vicente Olivert Riera
2014-03-18 10:55 ` Vicente Olivert Riera
2014-03-19 7:54 ` Arnout Vandecappelle
2014-03-19 9:40 ` Vicente Olivert Riera [this message]
2014-03-19 13:50 ` Arnout Vandecappelle
2014-03-19 14:41 ` Vicente Olivert Riera
2014-03-19 15:02 ` Arnout Vandecappelle
2014-03-19 15:07 ` Vicente Olivert Riera
2014-03-19 16:23 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53296606.9070104@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox