[Buildroot] [PATCH 1/1] dbus-triggerd: new package

[Arnout Vandecappelle <arnout@mind.be>]

On 25/03/14 08:59, Arnaud R?billout wrote:
> dbus-triggerd is a little daemon that can monitor dbus events, match
> them against some watch-expressions, then trigger shell-commands.
> 
> It can be used in any situation where dbus-interaction is needed, and
> shell script is preferred over other languages.
> 
> Signed-off-by: Arnaud R?billout <rebillout@syscom.ch>
> ---
>  package/Config.in                                  |  1 +
>  package/dbus-triggerd/Config.in                    |  9 ++++++++
>  .../dbus-triggerd-01-cross-compil.patch            | 13 ++++++++++++
>  package/dbus-triggerd/dbus-triggerd.mk             | 24 ++++++++++++++++++++++
>  4 files changed, 47 insertions(+)
>  create mode 100644 package/dbus-triggerd/Config.in
>  create mode 100644 package/dbus-triggerd/dbus-triggerd-01-cross-compil.patch
>  create mode 100644 package/dbus-triggerd/dbus-triggerd.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index cfa53d3..fa24b57 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -272,6 +272,7 @@ source "package/dbus/Config.in"
>  source "package/dbus-cpp/Config.in"
>  source "package/dbus-glib/Config.in"
>  source "package/dbus-python/Config.in"
> +source "package/dbus-triggerd/Config.in"
>  if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
>  source "package/devmem2/Config.in"
>  endif
> diff --git a/package/dbus-triggerd/Config.in b/package/dbus-triggerd/Config.in
> new file mode 100644
> index 0000000..e7f65b8
> --- /dev/null
> +++ b/package/dbus-triggerd/Config.in
> @@ -0,0 +1,9 @@
> +config BR2_PACKAGE_DBUS_TRIGGERD
> +	bool "dbus-triggerd"
> +	depends on BR2_USE_MMU # fork()
> +	depends on BR2_PACKAGE_DBUS

 For the other dbus-* packages, the dbus dependencies are repeated (even
though they're automatic because of the depends on DBUS). So I would do
that here as well. And that means of course that there should also be a
comment in case of missing toolchain features. See dbus-cpp for an example.

> +	help
> +	  dbus-triggerd is a tool to trigger shell-commands upon receiving
> +	  a given dbus-signal.
> +
> +	  http://gareus.org/oss/dbustriggerd/start
> diff --git a/package/dbus-triggerd/dbus-triggerd-01-cross-compil.patch b/package/dbus-triggerd/dbus-triggerd-01-cross-compil.patch
> new file mode 100644
> index 0000000..67a2755
> --- /dev/null
> +++ b/package/dbus-triggerd/dbus-triggerd-01-cross-compil.patch
> @@ -0,0 +1,13 @@

 Patch misses a description + Signed-off-by.

> +--- a/Makefile	2014-03-25 07:27:15.761217767 +0100
> ++++ b/Makefile	2014-03-25 07:31:28.523028955 +0100
> +@@ -1,7 +1,8 @@
> + PREFIX=/usr
> ++PKG_CONFIG?=pkg-config
> + 
> +-CFLAGS=`pkg-config --cflags dbus-1` -Wall -O3
> +-LDLIBS=`pkg-config --libs dbus-1`
> ++CFLAGS+=`$(PKG_CONFIG) --cflags dbus-1` -Wall -O3
> ++LDLIBS+=`$(PKG_CONFIG) --libs dbus-1`

 If you're anyway patching the Makefile, you can just as well make it:

CFLAGS?=-Wall -O3
CFLAGS+=`$(PKG_CONFIG) --cflags dbus-1`
LDLIBS+=`$(PKG_CONFIG) --libs dbus-1`



 Will you send this patch upstream?

> + 
> + all: dbus-triggerd
> + 
> diff --git a/package/dbus-triggerd/dbus-triggerd.mk b/package/dbus-triggerd/dbus-triggerd.mk
> new file mode 100644
> index 0000000..fa04c06
> --- /dev/null
> +++ b/package/dbus-triggerd/dbus-triggerd.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# dbus-triggerd
> +#
> +################################################################################
> +
> +DBUS_TRIGGERD_VERSION = 749a7a83a79439395ebdc52ff86f2601396b8c72
> +DBUS_TRIGGERD_SITE = git://rg42.org/dbustriggerd.git
> +DBUS_TRIGGERD_LICENSE = GPLv2+
> +DBUS_TRIGGERD_DEPENDENCIES = dbus
> +
> +define DBUS_TRIGGERD_BUILD_CMDS
> +	CC="$(TARGET_CC)" \
> +	CFLAGS="$(TARGET_CFLAGS)" \
> +	LDFLAGS="$(TARGET_LDFLAGS)" \
> +	PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \

 This should be $(TARGET_CONFIGURE_OPTS) which includes all of the above
and more.

 Note BTW that the patch above refers to LDLIBS instead of LDFLAGS. Is
LDFLAGS used?


 Regards,
 Arnout

> +	$(MAKE) -C $(@D) all
> +endef
> +
> +define DBUS_TRIGGERD_INSTALL_TARGET_CMDS
> +	$(MAKE) DESTDIR="$(TARGET_DIR)" -C $(@D) install
> +endef
> +
> +$(eval $(generic-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F