Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] Disable o32 ABI for MIPS64 architectures
Date: Thu, 27 Mar 2014 09:56:54 +0000	[thread overview]
Message-ID: <5333F5E6.1040604@imgtec.com> (raw)
In-Reply-To: <87txakk5tr.fsf@dell.be.48ers.dk>

On 03/26/2014 09:28 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> Hi,
>
>   >>> +config BR2_MIPS_OABI32
>   >>> +	bool
>   >>> +	default y		if BR2_mips || BR2_mipsel
>   >>> +	default n		if BR2_mips64 || BR2_mips64el
>   >>
>   >> Did you forget to remove this or is there a reason to keep it? In the
>   >> latter case, please add an explanatory comment.
>
>   > Why would I want to remove this? The BR2_MIPS_OABI32 symbol is used by
>   > glibc and uclibc packages.
>
> Arnout is just asking about the 'default n' line. Symbols are 'n' by
> default, so the line doesn't do anything as far as I can see.
>

I have maintained that line because if you remove it and then select any 
MIPS64 target, the "# BR2_MIPS_OABI32 is not set" is not present on the 
.config file.

Isn't that a problem?

-- 
Vincent

  reply	other threads:[~2014-03-27  9:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-26 14:15 [Buildroot] [PATCH v3] Disable o32 ABI for MIPS64 architectures Vicente Olivert Riera
2014-03-26 17:18 ` Arnout Vandecappelle
2014-03-26 18:03   ` Vicente Olivert Riera
2014-03-26 21:28     ` Peter Korsgaard
2014-03-27  9:56       ` Vicente Olivert Riera [this message]
2014-03-28  0:02         ` Joshua Kinard
2014-03-28  9:51           ` Vicente Olivert Riera
2014-03-28 10:27             ` Markos Chandras
2014-03-28 10:38               ` Vicente Olivert Riera
2014-03-28 10:41                 ` Markos Chandras
2014-03-28 10:52                   ` Joshua Kinard
2014-03-28 11:01                     ` Vicente Olivert Riera
2014-03-28 11:07                 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5333F5E6.1040604@imgtec.com \
    --to=vincent.riera@imgtec.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox