[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Vicente Olivert Riera]

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
 package/valgrind/Config.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
index dacdd86..fd5649b 100644
--- a/package/valgrind/Config.in
+++ b/package/valgrind/Config.in
@@ -1,7 +1,8 @@
 config BR2_PACKAGE_VALGRIND
 	bool "valgrind"
 	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
-		   BR2_cortex_a9 || BR2_powerpc
+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
 	help
 	  Tool for debugging and profiling Linux programs.
 
-- 
1.7.1

[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Thomas De Schampheleire]

Hi Vicente,

Vicente Olivert Riera <Vincent.Riera@imgtec.com> schreef:
>Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
>Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>---
> package/valgrind/Config.in |    3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
>diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
>index dacdd86..fd5649b 100644
>--- a/package/valgrind/Config.in
>+++ b/package/valgrind/Config.in
>@@ -1,7 +1,8 @@
> config BR2_PACKAGE_VALGRIND
> 	bool "valgrind"
> 	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
>-		   BR2_cortex_a9 || BR2_powerpc
>+		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
>+		   BR2_mipsel || BR2_mips64 || BR2_mips64el
> 	help
> 	  Tool for debugging and profiling Linux programs.
> 

Did you test this on target?
Do you have any idea why it wasn't enabled for mips before?

Thanks,
Thomas

[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Vicente Olivert Riera]

On 03/28/2014 06:16 PM, Thomas De Schampheleire wrote:
> Hi Vicente,
>
> Vicente Olivert Riera <Vincent.Riera@imgtec.com> schreef:
>> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>> package/valgrind/Config.in |    3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
>> index dacdd86..fd5649b 100644
>> --- a/package/valgrind/Config.in
>> +++ b/package/valgrind/Config.in
>> @@ -1,7 +1,8 @@
>> config BR2_PACKAGE_VALGRIND
>> 	bool "valgrind"
>> 	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
>> -		   BR2_cortex_a9 || BR2_powerpc
>> +		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
>> +		   BR2_mipsel || BR2_mips64 || BR2_mips64el
>> 	help
>> 	  Tool for debugging and profiling Linux programs.
>>
>
> Did you test this on target?

Not yet, but it should work.

> Do you have any idea why it wasn't enabled for mips before?

Valgrind added support for MIPS on it's last release, 3.9.0:

http://sourceforge.net/p/valgrind/mailman/valgrind-announce/thread/52738DEF.1070801 at acm.org/

But you already knew that. The following message is yours:

"One of the new features of Valgrind 3.9.0 is the addition of MIPS
support. Maybe it would be good to enable Valgrind on these
architectures. I'm adding Vincente and Markos in the Cc list, since
they are our main MIPS contributors. They might probably be interested
in doing this work, after testing on MIPS hardware."

> Thanks,
> Thomas


-- 
Vincent

[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Thomas De Schampheleire]

Vicente Olivert Riera <Vincent.Riera@imgtec.com> schreef:
>On 03/28/2014 06:16 PM, Thomas De Schampheleire wrote:
>> Hi Vicente,
>>
>> Vicente Olivert Riera <Vincent.Riera@imgtec.com> schreef:
>>> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>> ---
>>> package/valgrind/Config.in |    3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
>>> index dacdd86..fd5649b 100644
>>> --- a/package/valgrind/Config.in
>>> +++ b/package/valgrind/Config.in
>>> @@ -1,7 +1,8 @@
>>> config BR2_PACKAGE_VALGRIND
>>> 	bool "valgrind"
>>> 	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
>>> -		   BR2_cortex_a9 || BR2_powerpc
>>> +		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
>>> +		   BR2_mipsel || BR2_mips64 || BR2_mips64el
>>> 	help
>>> 	  Tool for debugging and profiling Linux programs.
>>>
>>
>> Did you test this on target?
>
>Not yet, but it should work.
>
>> Do you have any idea why it wasn't enabled for mips before?
>
>Valgrind added support for MIPS on it's last release, 3.9.0:
>
>http://sourceforge.net/p/valgrind/mailman/valgrind-announce/thread/52738DEF.1070801 at acm.org/
>
>But you already knew that. The following message is yours:
>
>"One of the new features of Valgrind 3.9.0 is the addition of MIPS
>support. Maybe it would be good to enable Valgrind on these
>architectures. I'm adding Vincente and Markos in the Cc list, since
>they are our main MIPS contributors. They might probably be interested
>in doing this work, after testing on MIPS hardware."

I think you are confusing the two Thomas'es, but that's ok :-).

Thanks for your explanation...

Best regards,
Thomas

[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Fri, 28 Mar 2014 16:46:49 +0000, Vicente Olivert Riera wrote:
> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/valgrind/Config.in |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Thomas Petazzoni]

Dear Vicente Olivert Riera,

On Fri, 28 Mar 2014 16:46:49 +0000, Vicente Olivert Riera wrote:
> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
>  package/valgrind/Config.in |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
> index dacdd86..fd5649b 100644
> --- a/package/valgrind/Config.in
> +++ b/package/valgrind/Config.in
> @@ -1,7 +1,8 @@
>  config BR2_PACKAGE_VALGRIND
>  	bool "valgrind"
>  	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
> -		   BR2_cortex_a9 || BR2_powerpc
> +		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
> +		   BR2_mipsel || BR2_mips64 || BR2_mips64el
>  	help
>  	  Tool for debugging and profiling Linux programs.

This breaks the build on MIPS64:

  http://autobuild.buildroot.org/results/213/21352bcbe1b309fef0f996c275cdfcda08619d96/build-end.log

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] valgrind: Add support for MIPS architecture

[Vicente Olivert Riera]

On 03/29/2014 03:47 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Fri, 28 Mar 2014 16:46:49 +0000, Vicente Olivert Riera wrote:
>> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> ---
>>   package/valgrind/Config.in |    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in
>> index dacdd86..fd5649b 100644
>> --- a/package/valgrind/Config.in
>> +++ b/package/valgrind/Config.in
>> @@ -1,7 +1,8 @@
>>   config BR2_PACKAGE_VALGRIND
>>   	bool "valgrind"
>>   	depends on BR2_i386 || BR2_x86_64 || BR2_cortex_a8 || \
>> -		   BR2_cortex_a9 || BR2_powerpc
>> +		   BR2_cortex_a9 || BR2_powerpc || BR2_mips || \
>> +		   BR2_mipsel || BR2_mips64 || BR2_mips64el
>>   	help
>>   	  Tool for debugging and profiling Linux programs.
>
> This breaks the build on MIPS64:
>
>    http://autobuild.buildroot.org/results/213/21352bcbe1b309fef0f996c275cdfcda08619d96/build-end.log
>
> Thomas
>

Yeah, I sent a patch to upstream few weeks ago, and it was applied. I 
will send it to BR today.

Thanks for reminding me this problem.

-- 
Vincent