* [Buildroot] [PATCH 1/1] libdrm: needs threads
@ 2014-04-21 17:28 Romain Naour
2014-04-21 17:32 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Romain Naour @ 2014-04-21 17:28 UTC (permalink / raw)
To: buildroot
libdrm select libpthread-stubs that needs threads support.
Fixes:
http://autobuild.buildroot.net/results/1da/1dad13110312a44b40b9ee4050b265de1f3c8a42/build-end.log
Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
package/libdrm/Config.in | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
index 72cf5f8..fdb541e 100644
--- a/package/libdrm/Config.in
+++ b/package/libdrm/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_LIBDRM
bool "libdrm"
select BR2_PACKAGE_LIBPTHREAD_STUBS
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
depends on BR2_LARGEFILE
help
Direct Rendering Manager
@@ -59,5 +60,6 @@ endmenu
endif
-comment "libdrm needs a toolchain w/ largefile"
+comment "libdrm needs a toolchain w/ largefile, threads"
depends on !BR2_LARGEFILE
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
--
1.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] libdrm: needs threads
2014-04-21 17:28 [Buildroot] [PATCH 1/1] libdrm: needs threads Romain Naour
@ 2014-04-21 17:32 ` Yann E. MORIN
2014-04-21 17:39 ` Romain Naour
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2014-04-21 17:32 UTC (permalink / raw)
To: buildroot
Romain, All,
On 2014-04-21 19:28 +0200, Romain Naour spake thusly:
> libdrm select libpthread-stubs that needs threads support.
>
> Fixes:
> http://autobuild.buildroot.net/results/1da/1dad13110312a44b40b9ee4050b265de1f3c8a42/build-end.log
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
> ---
> package/libdrm/Config.in | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
> index 72cf5f8..fdb541e 100644
> --- a/package/libdrm/Config.in
> +++ b/package/libdrm/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_LIBDRM
> bool "libdrm"
> select BR2_PACKAGE_LIBPTHREAD_STUBS
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
> depends on BR2_LARGEFILE
> help
> Direct Rendering Manager
> @@ -59,5 +60,6 @@ endmenu
>
> endif
>
> -comment "libdrm needs a toolchain w/ largefile"
> +comment "libdrm needs a toolchain w/ largefile, threads"
> depends on !BR2_LARGEFILE
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
This should be:
depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
Otherwise, the comment is only visible when both are not set, while we
want to see the comment as soon as at least one is not set.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread* [Buildroot] [PATCH 1/1] libdrm: needs threads
2014-04-21 17:32 ` Yann E. MORIN
@ 2014-04-21 17:39 ` Romain Naour
0 siblings, 0 replies; 3+ messages in thread
From: Romain Naour @ 2014-04-21 17:39 UTC (permalink / raw)
To: buildroot
Hi Yann,
Le 21/04/2014 19:32, Yann E. MORIN a ?crit :
> Romain, All,
>
> On 2014-04-21 19:28 +0200, Romain Naour spake thusly:
>> libdrm select libpthread-stubs that needs threads support.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/1da/1dad13110312a44b40b9ee4050b265de1f3c8a42/build-end.log
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> package/libdrm/Config.in | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/libdrm/Config.in b/package/libdrm/Config.in
>> index 72cf5f8..fdb541e 100644
>> --- a/package/libdrm/Config.in
>> +++ b/package/libdrm/Config.in
>> @@ -1,6 +1,7 @@
>> config BR2_PACKAGE_LIBDRM
>> bool "libdrm"
>> select BR2_PACKAGE_LIBPTHREAD_STUBS
>> + depends on BR2_TOOLCHAIN_HAS_THREADS # libpthread-stubs
>> depends on BR2_LARGEFILE
>> help
>> Direct Rendering Manager
>> @@ -59,5 +60,6 @@ endmenu
>>
>> endif
>>
>> -comment "libdrm needs a toolchain w/ largefile"
>> +comment "libdrm needs a toolchain w/ largefile, threads"
>> depends on !BR2_LARGEFILE
>> + depends on !BR2_TOOLCHAIN_HAS_THREADS
>
> This should be:
> depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS
>
> Otherwise, the comment is only visible when both are not set, while we
> want to see the comment as soon as at least one is not set.
>
Thanks, I'll send a new patch.
Best regards,
Romain
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-21 17:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-21 17:28 [Buildroot] [PATCH 1/1] libdrm: needs threads Romain Naour
2014-04-21 17:32 ` Yann E. MORIN
2014-04-21 17:39 ` Romain Naour
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox