* [Buildroot] [PATCH] give a hint about git rebase
@ 2014-04-29 19:30 Waldemar Brodkorb
2014-04-29 22:05 ` Arnout Vandecappelle
2014-07-15 21:40 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Waldemar Brodkorb @ 2014-04-29 19:30 UTC (permalink / raw)
To: buildroot
It seems common knowledge to use git rebase in interactive mode
to fixup issues while respinning patch series, but I found it hard
to find any hint about it. Add a note for git beginners like me.
Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
docs/manual/contribute.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
index 47494cb..7795e71 100644
--- a/docs/manual/contribute.txt
+++ b/docs/manual/contribute.txt
@@ -230,6 +230,8 @@ should include a changelog of the modifications between each
submission. Note that when your patch series is introduced by a cover
letter, an overall changelog may be added to the cover letter in
addition to the changelog in the individual commits.
+The best thing to rework a patch series is by using +git rebase+
+in interactive mode.
When added to the individual commits, this changelog is added when
editing the commit message. Below the +Signed-off-by+ section, add
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] give a hint about git rebase
2014-04-29 19:30 [Buildroot] [PATCH] give a hint about git rebase Waldemar Brodkorb
@ 2014-04-29 22:05 ` Arnout Vandecappelle
2014-07-15 21:40 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2014-04-29 22:05 UTC (permalink / raw)
To: buildroot
On 29/04/14 21:30, Waldemar Brodkorb wrote:
> It seems common knowledge to use git rebase in interactive mode
> to fixup issues while respinning patch series, but I found it hard
> to find any hint about it. Add a note for git beginners like me.
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> docs/manual/contribute.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/docs/manual/contribute.txt b/docs/manual/contribute.txt
> index 47494cb..7795e71 100644
> --- a/docs/manual/contribute.txt
> +++ b/docs/manual/contribute.txt
> @@ -230,6 +230,8 @@ should include a changelog of the modifications between each
> submission. Note that when your patch series is introduced by a cover
> letter, an overall changelog may be added to the cover letter in
> addition to the changelog in the individual commits.
> +The best thing to rework a patch series is by using +git rebase+
> +in interactive mode.
If you're making such a suggestion, it's good to provide just a little
bit more information:
The best thing to rework a patch series is by interactive rebasing: +git
rebase -i origin/master+. Consult the git manual for more information.
Regards,
Arnout
>
> When added to the individual commits, this changelog is added when
> editing the commit message. Below the +Signed-off-by+ section, add
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] give a hint about git rebase
2014-04-29 19:30 [Buildroot] [PATCH] give a hint about git rebase Waldemar Brodkorb
2014-04-29 22:05 ` Arnout Vandecappelle
@ 2014-07-15 21:40 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2014-07-15 21:40 UTC (permalink / raw)
To: buildroot
Dear Waldemar Brodkorb,
On Tue, 29 Apr 2014 21:30:27 +0200, Waldemar Brodkorb wrote:
> It seems common knowledge to use git rebase in interactive mode
> to fixup issues while respinning patch series, but I found it hard
> to find any hint about it. Add a note for git beginners like me.
>
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
> docs/manual/contribute.txt | 2 ++
> 1 file changed, 2 insertions(+)
Applied after taking into account Arnout's comment. Next time, please
use a better commit title such as:
docs/manual: give a hint about git rebase
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-15 21:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-29 19:30 [Buildroot] [PATCH] give a hint about git rebase Waldemar Brodkorb
2014-04-29 22:05 ` Arnout Vandecappelle
2014-07-15 21:40 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox