* [Buildroot] [PATCH] clapack: Disable for MIPS platforms
@ 2014-05-06 11:11 Vicente Olivert Riera
2014-05-06 11:52 ` Thomas De Schampheleire
0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-05-06 11:11 UTC (permalink / raw)
To: buildroot
Disable this package for MIPS because it needs IRIX headers and
libraries.
Fixes:
http://autobuild.buildroot.net/results/370/370f964441722675820c644403dde7fbc683a315/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
---
package/armadillo/Config.in | 1 +
package/clapack/Config.in | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/armadillo/Config.in b/package/armadillo/Config.in
index 2251d91..0b86b77 100644
--- a/package/armadillo/Config.in
+++ b/package/armadillo/Config.in
@@ -5,6 +5,7 @@ config BR2_PACKAGE_ARMADILLO
bool "armadillo"
depends on BR2_INSTALL_LIBSTDCPP
depends on BR2_LARGEFILE # clapack
+ depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) # clapack
select BR2_PACKAGE_CLAPACK
help
Armadillo: An Open Source C++ Linear Algebra Library for
diff --git a/package/clapack/Config.in b/package/clapack/Config.in
index a77094f..95dd343 100644
--- a/package/clapack/Config.in
+++ b/package/clapack/Config.in
@@ -1,6 +1,7 @@
config BR2_PACKAGE_CLAPACK
bool "cblas/clapack"
depends on BR2_LARGEFILE
+ depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
help
BLAS and LAPACK C implementation (f2c'ed version of).
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] clapack: Disable for MIPS platforms
2014-05-06 11:11 [Buildroot] [PATCH] clapack: Disable for MIPS platforms Vicente Olivert Riera
@ 2014-05-06 11:52 ` Thomas De Schampheleire
2014-05-06 12:40 ` Vicente Olivert Riera
0 siblings, 1 reply; 4+ messages in thread
From: Thomas De Schampheleire @ 2014-05-06 11:52 UTC (permalink / raw)
To: buildroot
Hi Vicente,
On Tue, May 6, 2014 at 1:11 PM, Vicente Olivert Riera
<Vincent.Riera@imgtec.com> wrote:
> Disable this package for MIPS because it needs IRIX headers and
> libraries.
>
> Fixes:
> http://autobuild.buildroot.net/results/370/370f964441722675820c644403dde7fbc683a315/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
> ---
> package/armadillo/Config.in | 1 +
> package/clapack/Config.in | 1 +
> 2 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/package/armadillo/Config.in b/package/armadillo/Config.in
> index 2251d91..0b86b77 100644
> --- a/package/armadillo/Config.in
> +++ b/package/armadillo/Config.in
> @@ -5,6 +5,7 @@ config BR2_PACKAGE_ARMADILLO
> bool "armadillo"
> depends on BR2_INSTALL_LIBSTDCPP
> depends on BR2_LARGEFILE # clapack
> + depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) # clapack
> select BR2_PACKAGE_CLAPACK
> help
> Armadillo: An Open Source C++ Linear Algebra Library for
> diff --git a/package/clapack/Config.in b/package/clapack/Config.in
> index a77094f..95dd343 100644
> --- a/package/clapack/Config.in
> +++ b/package/clapack/Config.in
> @@ -1,6 +1,7 @@
> config BR2_PACKAGE_CLAPACK
> bool "cblas/clapack"
> depends on BR2_LARGEFILE
> + depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
> help
> BLAS and LAPACK C implementation (f2c'ed version of).
>
These dependencies should also be added to the respective comment lines, see
http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options
"The comment should only be visible if the config option itself would
be visible when the toolchain option dependencies are met. This means
that all other dependencies of the package (including dependencies on
target architecture and MMU support) have to be repeated on the
comment definition. To keep it clear, the depends on statement for
these non-toolchain option should be kept separate from the depends on
statement for the toolchain options. If there is a dependency on a
config option in that same file (typically the main package) it is
preferable to have a global if ? endif construct rather than repeating
the depends on statement on the comment and other config options."
Best regards,
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] clapack: Disable for MIPS platforms
2014-05-06 11:52 ` Thomas De Schampheleire
@ 2014-05-06 12:40 ` Vicente Olivert Riera
2014-05-06 12:48 ` Vicente Olivert Riera
0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-05-06 12:40 UTC (permalink / raw)
To: buildroot
On 05/06/2014 12:52 PM, Thomas De Schampheleire wrote:
> Hi Vicente,
>
> On Tue, May 6, 2014 at 1:11 PM, Vicente Olivert Riera
> <Vincent.Riera@imgtec.com> wrote:
>> Disable this package for MIPS because it needs IRIX headers and
>> libraries.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/370/370f964441722675820c644403dde7fbc683a315/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
>> ---
>> package/armadillo/Config.in | 1 +
>> package/clapack/Config.in | 1 +
>> 2 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/armadillo/Config.in b/package/armadillo/Config.in
>> index 2251d91..0b86b77 100644
>> --- a/package/armadillo/Config.in
>> +++ b/package/armadillo/Config.in
>> @@ -5,6 +5,7 @@ config BR2_PACKAGE_ARMADILLO
>> bool "armadillo"
>> depends on BR2_INSTALL_LIBSTDCPP
>> depends on BR2_LARGEFILE # clapack
>> + depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el) # clapack
>> select BR2_PACKAGE_CLAPACK
>> help
>> Armadillo: An Open Source C++ Linear Algebra Library for
>> diff --git a/package/clapack/Config.in b/package/clapack/Config.in
>> index a77094f..95dd343 100644
>> --- a/package/clapack/Config.in
>> +++ b/package/clapack/Config.in
>> @@ -1,6 +1,7 @@
>> config BR2_PACKAGE_CLAPACK
>> bool "cblas/clapack"
>> depends on BR2_LARGEFILE
>> + depends on !(BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el)
>> help
>> BLAS and LAPACK C implementation (f2c'ed version of).
>>
>
> These dependencies should also be added to the respective comment lines, see
> http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options
>
> "The comment should only be visible if the config option itself would
> be visible when the toolchain option dependencies are met. This means
> that all other dependencies of the package (including dependencies on
> target architecture and MMU support) have to be repeated on the
> comment definition. To keep it clear, the depends on statement for
> these non-toolchain option should be kept separate from the depends on
> statement for the toolchain options. If there is a dependency on a
> config option in that same file (typically the main package) it is
> preferable to have a global if ? endif construct rather than repeating
> the depends on statement on the comment and other config options."
>
> Best regards,
> Thomas
>
Hi Thomas,
it wasn't me who put the "depends on BR2_LARGEFILE" in that package.
Anyway, I will add that fix to my patch.
Cheers,
--
Vincent
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] clapack: Disable for MIPS platforms
2014-05-06 12:40 ` Vicente Olivert Riera
@ 2014-05-06 12:48 ` Vicente Olivert Riera
0 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-05-06 12:48 UTC (permalink / raw)
To: buildroot
On 05/06/2014 01:40 PM, Vicente Olivert Riera wrote:
> On 05/06/2014 12:52 PM, Thomas De Schampheleire wrote:
>> Hi Vicente,
>>
>> On Tue, May 6, 2014 at 1:11 PM, Vicente Olivert Riera
>> <Vincent.Riera@imgtec.com> wrote:
>>> Disable this package for MIPS because it needs IRIX headers and
>>> libraries.
>>>
>>> Fixes:
>>>
>>> http://autobuild.buildroot.net/results/370/370f964441722675820c644403dde7fbc683a315/
>>>
>>>
>>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>>> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
>>> ---
>>> package/armadillo/Config.in | 1 +
>>> package/clapack/Config.in | 1 +
>>> 2 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/package/armadillo/Config.in b/package/armadillo/Config.in
>>> index 2251d91..0b86b77 100644
>>> --- a/package/armadillo/Config.in
>>> +++ b/package/armadillo/Config.in
>>> @@ -5,6 +5,7 @@ config BR2_PACKAGE_ARMADILLO
>>> bool "armadillo"
>>> depends on BR2_INSTALL_LIBSTDCPP
>>> depends on BR2_LARGEFILE # clapack
>>> + depends on !(BR2_mips || BR2_mipsel || BR2_mips64 ||
>>> BR2_mips64el) # clapack
>>> select BR2_PACKAGE_CLAPACK
>>> help
>>> Armadillo: An Open Source C++ Linear Algebra Library for
>>> diff --git a/package/clapack/Config.in b/package/clapack/Config.in
>>> index a77094f..95dd343 100644
>>> --- a/package/clapack/Config.in
>>> +++ b/package/clapack/Config.in
>>> @@ -1,6 +1,7 @@
>>> config BR2_PACKAGE_CLAPACK
>>> bool "cblas/clapack"
>>> depends on BR2_LARGEFILE
>>> + depends on !(BR2_mips || BR2_mipsel || BR2_mips64 ||
>>> BR2_mips64el)
>>> help
>>> BLAS and LAPACK C implementation (f2c'ed version of).
>>>
>>
>> These dependencies should also be added to the respective comment
>> lines, see
>> http://buildroot.uclibc.org/downloads/manual/manual.html#dependencies-target-toolchain-options
>>
>>
>> "The comment should only be visible if the config option itself would
>> be visible when the toolchain option dependencies are met. This means
>> that all other dependencies of the package (including dependencies on
>> target architecture and MMU support) have to be repeated on the
>> comment definition. To keep it clear, the depends on statement for
>> these non-toolchain option should be kept separate from the depends on
>> statement for the toolchain options. If there is a dependency on a
>> config option in that same file (typically the main package) it is
>> preferable to have a global if ? endif construct rather than repeating
>> the depends on statement on the comment and other config options."
>>
>> Best regards,
>> Thomas
>>
>
> Hi Thomas,
>
> it wasn't me who put the "depends on BR2_LARGEFILE" in that package.
> Anyway, I will add that fix to my patch.
>
> Cheers,
>
Hi again Thomas,
sorry about my last email. I thought you were talking about
BR2_LARGEFILE. I have sent a V2 patch.
--
Vincent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-06 12:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-06 11:11 [Buildroot] [PATCH] clapack: Disable for MIPS platforms Vicente Olivert Riera
2014-05-06 11:52 ` Thomas De Schampheleire
2014-05-06 12:40 ` Vicente Olivert Riera
2014-05-06 12:48 ` Vicente Olivert Riera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox