* [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli
@ 2014-05-12 16:16 Oscar Hellström
2014-05-12 22:20 ` Gustavo Zacarias
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Oscar Hellström @ 2014-05-12 16:16 UTC (permalink / raw)
To: buildroot
Signed-off-by: Oscar Hellstr?m <oscar.hellstrom@vinnter.se>
---
package/wpa_supplicant/wpa_supplicant.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index 9fcda2e..9321f08 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -105,6 +105,11 @@ define WPA_SUPPLICANT_DEBUG_CONFIG
endef
endif
+ifeq ($(BR2_PACKAGE_READLINE),y)
+ WPA_SUPPLICANT_DEPENDENCIES += readline
+ WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE
+endif
+
define WPA_SUPPLICANT_CONFIGURE_CMDS
cp $(@D)/wpa_supplicant/defconfig $(WPA_SUPPLICANT_CONFIG)
sed -i $(patsubst %,-e 's/^#\(%\)/\1/',$(WPA_SUPPLICANT_CONFIG_ENABLE)) \
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli
2014-05-12 16:16 [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli Oscar Hellström
@ 2014-05-12 22:20 ` Gustavo Zacarias
2014-05-13 5:30 ` Arnout Vandecappelle
2014-05-13 7:27 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Gustavo Zacarias @ 2014-05-12 22:20 UTC (permalink / raw)
To: buildroot
On 05/12/2014 01:16 PM, Oscar Hellstr?m wrote:
> Signed-off-by: Oscar Hellstr?m <oscar.hellstrom@vinnter.se>
Acked-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli
2014-05-12 16:16 [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli Oscar Hellström
2014-05-12 22:20 ` Gustavo Zacarias
@ 2014-05-13 5:30 ` Arnout Vandecappelle
2014-05-13 7:28 ` Peter Korsgaard
2014-05-13 7:27 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2014-05-13 5:30 UTC (permalink / raw)
To: buildroot
On 12/05/14 18:16, Oscar Hellstr?m wrote:
> Signed-off-by: Oscar Hellstr?m <oscar.hellstrom@vinnter.se>
> ---
> package/wpa_supplicant/wpa_supplicant.mk | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
> index 9fcda2e..9321f08 100644
> --- a/package/wpa_supplicant/wpa_supplicant.mk
> +++ b/package/wpa_supplicant/wpa_supplicant.mk
> @@ -105,6 +105,11 @@ define WPA_SUPPLICANT_DEBUG_CONFIG
> endef
> endif
>
> +ifeq ($(BR2_PACKAGE_READLINE),y)
> + WPA_SUPPLICANT_DEPENDENCIES += readline
> + WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE
In package .mk file, we don't indent within if... constructs; we only use
indentation for commands and for continuation lines. I admit that that coding
style is objectionable, but it is what it is.
Regards,
Arnout
> +endif
> +
> define WPA_SUPPLICANT_CONFIGURE_CMDS
> cp $(@D)/wpa_supplicant/defconfig $(WPA_SUPPLICANT_CONFIG)
> sed -i $(patsubst %,-e 's/^#\(%\)/\1/',$(WPA_SUPPLICANT_CONFIG_ENABLE)) \
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli
2014-05-12 16:16 [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli Oscar Hellström
2014-05-12 22:20 ` Gustavo Zacarias
2014-05-13 5:30 ` Arnout Vandecappelle
@ 2014-05-13 7:27 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2014-05-13 7:27 UTC (permalink / raw)
To: buildroot
>>>>> "Oscar" == Oscar Hellstr?m <oscar.hellstrom@vinnter.se> writes:
> Signed-off-by: Oscar Hellstr?m <oscar.hellstrom@vinnter.se>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli
2014-05-13 5:30 ` Arnout Vandecappelle
@ 2014-05-13 7:28 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2014-05-13 7:28 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
> On 12/05/14 18:16, Oscar Hellstr?m wrote:
>> Signed-off-by: Oscar Hellstr?m <oscar.hellstrom@vinnter.se>
>> ---
>> package/wpa_supplicant/wpa_supplicant.mk | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
>> index 9fcda2e..9321f08 100644
>> --- a/package/wpa_supplicant/wpa_supplicant.mk
>> +++ b/package/wpa_supplicant/wpa_supplicant.mk
>> @@ -105,6 +105,11 @@ define WPA_SUPPLICANT_DEBUG_CONFIG
>> endef
>> endif
>>
>> +ifeq ($(BR2_PACKAGE_READLINE),y)
>> + WPA_SUPPLICANT_DEPENDENCIES += readline
>> + WPA_SUPPLICANT_CONFIG_ENABLE += CONFIG_READLINE
> In package .mk file, we don't indent within if... constructs; we only use
> indentation for commands and for continuation lines. I admit that that coding
> style is objectionable, but it is what it is.
True, but this is atleast consistent with the rest of the file, so I
will leave it like this for now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-05-13 7:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 16:16 [Buildroot] [PATCH 1/1] wpa_supplicant: detect readline support in wpa_cli Oscar Hellström
2014-05-12 22:20 ` Gustavo Zacarias
2014-05-13 5:30 ` Arnout Vandecappelle
2014-05-13 7:28 ` Peter Korsgaard
2014-05-13 7:27 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox