[Buildroot] [v2 0/2] perl/cpan stuff

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [v2 0/2] perl/cpan stuff
@ 2014-06-16 19:35 Francois Perrad
  2014-06-16 19:35 ` [Buildroot] [v2 1/2] support/script/scancpan: populates Config.in with homepage Francois Perrad
  2014-06-16 19:35 ` [Buildroot] [v2 2/2] perl-mojolicious: new package Francois Perrad
  0 siblings, 2 replies; 7+ messages in thread
From: Francois Perrad @ 2014-06-16 19:35 UTC (permalink / raw)
  To: buildroot

v1 -> v2
remove leading whitespace in generated Config.in.

note: perl-mojolicious is generated by scancpan

Francois Perrad (2):
  support/script/scancpan: populates Config.in with homepage
  perl-mojolicious: new package

 package/Config.in                            |  1 +
 package/perl-mojolicious/Config.in           |  6 ++++++
 package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
 support/scripts/scancpan                     |  6 ++++--
 4 files changed, 24 insertions(+), 2 deletions(-)
 create mode 100644 package/perl-mojolicious/Config.in
 create mode 100644 package/perl-mojolicious/perl-mojolicious.mk

-- 
1.9.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [v2 1/2] support/script/scancpan: populates Config.in with homepage
  2014-06-16 19:35 [Buildroot] [v2 0/2] perl/cpan stuff Francois Perrad
@ 2014-06-16 19:35 ` Francois Perrad
  2014-06-22 17:28   ` Thomas Petazzoni
  2014-06-16 19:35 ` [Buildroot] [v2 2/2] perl-mojolicious: new package Francois Perrad
  1 sibling, 1 reply; 7+ messages in thread
From: Francois Perrad @ 2014-06-16 19:35 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 support/scripts/scancpan | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/support/scripts/scancpan b/support/scripts/scancpan
index d8723f3..4be4754 100755
--- a/support/scripts/scancpan
+++ b/support/scripts/scancpan
@@ -577,6 +577,7 @@ while (my ($distname, $dist) = each %dist) {
     mkdir $dirname unless -d $dirname;
     if ($need_target{$distname} && ($force || !-f $cfgname)) {
         my $abstract = $dist->{abstract};
+        my $homepage = $dist->{resources}->{homepage} || qq{https://metacpan.org/release/${distname}};
         say qq{write ${cfgname}} unless $quiet;
         open my $fh, q{>}, $cfgname;
         say {$fh} qq{config BR2_PACKAGE_${brname}};
@@ -585,8 +586,9 @@ while (my ($distname, $dist) = each %dist) {
             my $brdep = brname( fsname( $dep ) );
             say {$fh} qq{\tselect BR2_PACKAGE_${brdep}};
         }
-        say {$fh} qq{\thelp} if $abstract;
-        say {$fh} qq{\t  ${abstract}} if $abstract;
+        say {$fh} qq{\thelp};
+        say {$fh} qq{\t  ${abstract}\n} if $abstract;
+        say {$fh} qq{\t  ${homepage}};
         close $fh;
     }
     if ($force || !-f $mkname) {
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [v2 1/2] support/script/scancpan: populates Config.in with homepage
  2014-06-16 19:35 ` [Buildroot] [v2 1/2] support/script/scancpan: populates Config.in with homepage Francois Perrad
@ 2014-06-22 17:28   ` Thomas Petazzoni
  0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2014-06-22 17:28 UTC (permalink / raw)
  To: buildroot

Dear Francois Perrad,

On Mon, 16 Jun 2014 21:35:56 +0200, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
>  support/scripts/scancpan | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [v2 2/2] perl-mojolicious: new package
  2014-06-16 19:35 [Buildroot] [v2 0/2] perl/cpan stuff Francois Perrad
  2014-06-16 19:35 ` [Buildroot] [v2 1/2] support/script/scancpan: populates Config.in with homepage Francois Perrad
@ 2014-06-16 19:35 ` Francois Perrad
  2014-06-18 20:33   ` Arnout Vandecappelle
                     ` (2 more replies)
  1 sibling, 3 replies; 7+ messages in thread
From: Francois Perrad @ 2014-06-16 19:35 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/Config.in                            |  1 +
 package/perl-mojolicious/Config.in           |  6 ++++++
 package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
 3 files changed, 20 insertions(+)
 create mode 100644 package/perl-mojolicious/Config.in
 create mode 100644 package/perl-mojolicious/perl-mojolicious.mk

diff --git a/package/Config.in b/package/Config.in
index f43e985..5e16ffa 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -423,6 +423,7 @@ endif
 	source "package/perl/Config.in"
 if BR2_PACKAGE_PERL
 menu "Perl libraries/modules"
+source "package/perl-mojolicious/Config.in"
 endmenu
 endif
 	source "package/php/Config.in"
diff --git a/package/perl-mojolicious/Config.in b/package/perl-mojolicious/Config.in
new file mode 100644
index 0000000..766d109
--- /dev/null
+++ b/package/perl-mojolicious/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PERL_MOJOLICIOUS
+	bool "perl-mojolicious"
+	help
+	  Real-time web framework
+
+	  http://mojolicio.us
diff --git a/package/perl-mojolicious/perl-mojolicious.mk b/package/perl-mojolicious/perl-mojolicious.mk
new file mode 100644
index 0000000..e4ced7e
--- /dev/null
+++ b/package/perl-mojolicious/perl-mojolicious.mk
@@ -0,0 +1,13 @@
+################################################################################
+#
+# perl-mojolicious
+#
+################################################################################
+
+PERL_MOJOLICIOUS_VERSION = 5.07
+PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
+PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
+PERL_MOJOLICIOUS_DEPENDENCIES = perl 
+PERL_MOJOLICIOUS_LICENSE = artistic_2
+
+$(eval $(perl-package))
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [Buildroot] [v2 2/2] perl-mojolicious: new package
  2014-06-16 19:35 ` [Buildroot] [v2 2/2] perl-mojolicious: new package Francois Perrad
@ 2014-06-18 20:33   ` Arnout Vandecappelle
  2014-06-22 17:29   ` Thomas Petazzoni
  2014-06-22 21:13   ` Yann E. MORIN
  2 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2014-06-18 20:33 UTC (permalink / raw)
  To: buildroot

On 16/06/14 21:35, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/Config.in                            |  1 +
>  package/perl-mojolicious/Config.in           |  6 ++++++
>  package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
>  3 files changed, 20 insertions(+)
>  create mode 100644 package/perl-mojolicious/Config.in
>  create mode 100644 package/perl-mojolicious/perl-mojolicious.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index f43e985..5e16ffa 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -423,6 +423,7 @@ endif
>  	source "package/perl/Config.in"
>  if BR2_PACKAGE_PERL
>  menu "Perl libraries/modules"
> +source "package/perl-mojolicious/Config.in"
>  endmenu
>  endif
>  	source "package/php/Config.in"
> diff --git a/package/perl-mojolicious/Config.in b/package/perl-mojolicious/Config.in
> new file mode 100644
> index 0000000..766d109
> --- /dev/null
> +++ b/package/perl-mojolicious/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_PERL_MOJOLICIOUS
> +	bool "perl-mojolicious"
> +	help
> +	  Real-time web framework
> +
> +	  http://mojolicio.us
> diff --git a/package/perl-mojolicious/perl-mojolicious.mk b/package/perl-mojolicious/perl-mojolicious.mk
> new file mode 100644
> index 0000000..e4ced7e
> --- /dev/null
> +++ b/package/perl-mojolicious/perl-mojolicious.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# perl-mojolicious
> +#
> +################################################################################
> +
> +PERL_MOJOLICIOUS_VERSION = 5.07
> +PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
> +PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
> +PERL_MOJOLICIOUS_DEPENDENCIES = perl 

 There's still trailing whitespace here.

> +PERL_MOJOLICIOUS_LICENSE = artistic_2

 artistic_2 is not in our list of licenses, and is also not a format that we
would typically use.  We already have pv with Artistic-2.0, which is also what
is used by spdx.

 Regards,
 Arnout

> +
> +$(eval $(perl-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [v2 2/2] perl-mojolicious: new package
  2014-06-16 19:35 ` [Buildroot] [v2 2/2] perl-mojolicious: new package Francois Perrad
  2014-06-18 20:33   ` Arnout Vandecappelle
@ 2014-06-22 17:29   ` Thomas Petazzoni
  2014-06-22 21:13   ` Yann E. MORIN
  2 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2014-06-22 17:29 UTC (permalink / raw)
  To: buildroot

Dear Francois Perrad,

On Mon, 16 Jun 2014 21:35:57 +0200, Francois Perrad wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/Config.in                            |  1 +
>  package/perl-mojolicious/Config.in           |  6 ++++++
>  package/perl-mojolicious/perl-mojolicious.mk | 13 +++++++++++++
>  3 files changed, 20 insertions(+)
>  create mode 100644 package/perl-mojolicious/Config.in
>  create mode 100644 package/perl-mojolicious/perl-mojolicious.mk

Patch applied, with a few changes, see below.

> 
> diff --git a/package/Config.in b/package/Config.in
> index f43e985..5e16ffa 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -423,6 +423,7 @@ endif
>  	source "package/perl/Config.in"
>  if BR2_PACKAGE_PERL
>  menu "Perl libraries/modules"
> +source "package/perl-mojolicious/Config.in"

We now indent by one tab all "source" invocations in package/Config.in.

> +PERL_MOJOLICIOUS_VERSION = 5.07
> +PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
> +PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
> +PERL_MOJOLICIOUS_DEPENDENCIES = perl 
> +PERL_MOJOLICIOUS_LICENSE = artistic_2

As noted by Arnout, I removed the trailing whitespace after "perl", and
I changed the license name to Artistic-2.0. If the license name
"artistic_2" was automatically generated by the scancpan script, you
might want to tune it to automatically change it to Artistic-2.0 in
this case.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [Buildroot] [v2 2/2] perl-mojolicious: new package
  2014-06-16 19:35 ` [Buildroot] [v2 2/2] perl-mojolicious: new package Francois Perrad
  2014-06-18 20:33   ` Arnout Vandecappelle
  2014-06-22 17:29   ` Thomas Petazzoni
@ 2014-06-22 21:13   ` Yann E. MORIN
  2 siblings, 0 replies; 7+ messages in thread
From: Yann E. MORIN @ 2014-06-22 21:13 UTC (permalink / raw)
  To: buildroot

Francois, All,

On 2014-06-16 21:35 +0200, Francois Perrad spake thusly:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
[--SNIP--]
> diff --git a/package/perl-mojolicious/perl-mojolicious.mk b/package/perl-mojolicious/perl-mojolicious.mk
> new file mode 100644
> index 0000000..e4ced7e
> --- /dev/null
> +++ b/package/perl-mojolicious/perl-mojolicious.mk
> @@ -0,0 +1,13 @@
> +################################################################################
> +#
> +# perl-mojolicious
> +#
> +################################################################################
> +
> +PERL_MOJOLICIOUS_VERSION = 5.07

5.07 is no longer available. There's now 5.08, and it seems only the
latest version is ever available on CPAN. :-(

This is causing autobuild failures:
    http://autobuild.buildroot.net/results/358/358f531f2db90b9bc3b1e4e2158c68d2bf6587fc/

I'll send a patch bumping to 5.08 in a moment...

Regards,
Yann E. MORIN.

> +PERL_MOJOLICIOUS_SOURCE = Mojolicious-$(PERL_MOJOLICIOUS_VERSION).tar.gz
> +PERL_MOJOLICIOUS_SITE = $(BR2_CPAN_MIRROR)/authors/id/S/SR/SRI/
> +PERL_MOJOLICIOUS_DEPENDENCIES = perl 
> +PERL_MOJOLICIOUS_LICENSE = artistic_2
> +
> +$(eval $(perl-package))
> -- 
> 1.9.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2014-06-22 21:13 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 19:35 [Buildroot] [v2 0/2] perl/cpan stuff Francois Perrad
2014-06-16 19:35 ` [Buildroot] [v2 1/2] support/script/scancpan: populates Config.in with homepage Francois Perrad
2014-06-22 17:28   ` Thomas Petazzoni
2014-06-16 19:35 ` [Buildroot] [v2 2/2] perl-mojolicious: new package Francois Perrad
2014-06-18 20:33   ` Arnout Vandecappelle
2014-06-22 17:29   ` Thomas Petazzoni
2014-06-22 21:13   ` Yann E. MORIN

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox