From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] binutils: Use the default version by default
Date: Wed, 2 Jul 2014 10:41:25 +0100 [thread overview]
Message-ID: <53B3D3C5.7060409@imgtec.com> (raw)
In-Reply-To: <53B3D2F7.8080508@imgtec.com>
On 07/02/2014 10:36 AM, Baruch Siach wrote:> Hi Vicente,
>
> On Wed, Jul 02, 2014 at 10:29:45AM +0100, Vicente Olivert Riera wrote:
>> >Signed-off-by: Vicente Olivert Riera<Vincent.Riera@imgtec.com>
>> >Reviewed-by: Markos Chandras<markos.chandras@imgtec.com>
> Subject should mention that this commit only affects MIPS.
>
> baruch
>
On 07/02/2014 10:37 AM, Markos Chandras wrote:
> On 07/02/2014 10:29 AM, Vicente Olivert Riera wrote:
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>
> Hi Vincent,
>
> The title (or the commit message) could have been a little more accurate
> now that I read it again. Your change changes the default version for
> MIPS so the commit message should have been clearer. Perhaps
>
> "Use the default version on MIPS"
>
Yeah, I realized about that few seconds after sending the patch. The v2
patch has been already sent.
--
Vincent
prev parent reply other threads:[~2014-07-02 9:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 9:29 [Buildroot] [PATCH] binutils: Use the default version by default Vicente Olivert Riera
2014-07-02 9:36 ` Baruch Siach
2014-07-02 9:37 ` Markos Chandras
2014-07-02 9:41 ` Vicente Olivert Riera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3D3C5.7060409@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox