* [Buildroot] [PATCH] binutils: Use the default version by default
@ 2014-07-02 9:29 Vicente Olivert Riera
2014-07-02 9:36 ` Baruch Siach
2014-07-02 9:37 ` Markos Chandras
0 siblings, 2 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-07-02 9:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
---
package/binutils/Config.in.host | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
index 08540a3..bc21f5e 100644
--- a/package/binutils/Config.in.host
+++ b/package/binutils/Config.in.host
@@ -3,7 +3,7 @@ comment "Binutils Options"
choice
prompt "Binutils Version"
depends on !BR2_arc
- default BR2_BINUTILS_VERSION_2_21 if (BR2_mips || BR2_mipsel || BR2_sh)
+ default BR2_BINUTILS_VERSION_2_21 if BR2_sh
default BR2_BINUTILS_VERSION_2_24 if BR2_microblaze || BR2_powerpc64le
default BR2_BINUTILS_VERSION_2_22
help
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] binutils: Use the default version by default
2014-07-02 9:29 [Buildroot] [PATCH] binutils: Use the default version by default Vicente Olivert Riera
@ 2014-07-02 9:36 ` Baruch Siach
2014-07-02 9:37 ` Markos Chandras
1 sibling, 0 replies; 4+ messages in thread
From: Baruch Siach @ 2014-07-02 9:36 UTC (permalink / raw)
To: buildroot
Hi Vicente,
On Wed, Jul 02, 2014 at 10:29:45AM +0100, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
Subject should mention that this commit only affects MIPS.
baruch
> ---
> package/binutils/Config.in.host | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> index 08540a3..bc21f5e 100644
> --- a/package/binutils/Config.in.host
> +++ b/package/binutils/Config.in.host
> @@ -3,7 +3,7 @@ comment "Binutils Options"
> choice
> prompt "Binutils Version"
> depends on !BR2_arc
> - default BR2_BINUTILS_VERSION_2_21 if (BR2_mips || BR2_mipsel || BR2_sh)
> + default BR2_BINUTILS_VERSION_2_21 if BR2_sh
> default BR2_BINUTILS_VERSION_2_24 if BR2_microblaze || BR2_powerpc64le
> default BR2_BINUTILS_VERSION_2_22
> help
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] binutils: Use the default version by default
2014-07-02 9:29 [Buildroot] [PATCH] binutils: Use the default version by default Vicente Olivert Riera
2014-07-02 9:36 ` Baruch Siach
@ 2014-07-02 9:37 ` Markos Chandras
2014-07-02 9:41 ` Vicente Olivert Riera
1 sibling, 1 reply; 4+ messages in thread
From: Markos Chandras @ 2014-07-02 9:37 UTC (permalink / raw)
To: buildroot
On 07/02/2014 10:29 AM, Vicente Olivert Riera wrote:
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
Hi Vincent,
The title (or the commit message) could have been a little more accurate
now that I read it again. Your change changes the default version for
MIPS so the commit message should have been clearer. Perhaps
"Use the default version on MIPS"
--
markos
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] binutils: Use the default version by default
2014-07-02 9:37 ` Markos Chandras
@ 2014-07-02 9:41 ` Vicente Olivert Riera
0 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2014-07-02 9:41 UTC (permalink / raw)
To: buildroot
On 07/02/2014 10:36 AM, Baruch Siach wrote:> Hi Vicente,
>
> On Wed, Jul 02, 2014 at 10:29:45AM +0100, Vicente Olivert Riera wrote:
>> >Signed-off-by: Vicente Olivert Riera<Vincent.Riera@imgtec.com>
>> >Reviewed-by: Markos Chandras<markos.chandras@imgtec.com>
> Subject should mention that this commit only affects MIPS.
>
> baruch
>
On 07/02/2014 10:37 AM, Markos Chandras wrote:
> On 07/02/2014 10:29 AM, Vicente Olivert Riera wrote:
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>
>> ---
>
> Hi Vincent,
>
> The title (or the commit message) could have been a little more accurate
> now that I read it again. Your change changes the default version for
> MIPS so the commit message should have been clearer. Perhaps
>
> "Use the default version on MIPS"
>
Yeah, I realized about that few seconds after sending the patch. The v2
patch has been already sent.
--
Vincent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-02 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-02 9:29 [Buildroot] [PATCH] binutils: Use the default version by default Vicente Olivert Riera
2014-07-02 9:36 ` Baruch Siach
2014-07-02 9:37 ` Markos Chandras
2014-07-02 9:41 ` Vicente Olivert Riera
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox