Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libnl: Move the pthread dependency menu comment
@ 2014-07-05 21:08 Ezequiel Garcia
  2014-07-07  6:14 ` Arnout Vandecappelle
  2014-07-09 13:28 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Ezequiel Garcia @ 2014-07-05 21:08 UTC (permalink / raw)
  To: buildroot

In order for this comment to be properly displayer, it must be moved to be
at the end of the file.

Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
 package/libnl/Config.in | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/package/libnl/Config.in b/package/libnl/Config.in
index 1173278..74a2e79 100644
--- a/package/libnl/Config.in
+++ b/package/libnl/Config.in
@@ -6,9 +6,6 @@ config BR2_PACKAGE_LIBNL
 
 	  http://people.suug.ch/~tgr/libnl/
 
-comment "libnl needs a toolchain w/ threads"
-	depends on !BR2_TOOLCHAIN_HAS_THREADS
-
 if BR2_PACKAGE_LIBNL
 
 config BR2_PACKAGE_LIBNL_TOOLS
@@ -20,5 +17,7 @@ config BR2_PACKAGE_LIBNL_TOOLS
 
 comment "libnl tools need a toolchain w/ dynamic library"
 	depends on BR2_PREFER_STATIC_LIB
-
 endif
+
+comment "libnl needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libnl: Move the pthread dependency menu comment
  2014-07-05 21:08 [Buildroot] [PATCH] libnl: Move the pthread dependency menu comment Ezequiel Garcia
@ 2014-07-07  6:14 ` Arnout Vandecappelle
  2014-07-09 13:28 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2014-07-07  6:14 UTC (permalink / raw)
  To: buildroot

On 05/07/14 23:08, Ezequiel Garcia wrote:
> In order for this comment to be properly displayer, it must be moved to be
> at the end of the file.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> ---
>  package/libnl/Config.in | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/package/libnl/Config.in b/package/libnl/Config.in
> index 1173278..74a2e79 100644
> --- a/package/libnl/Config.in
> +++ b/package/libnl/Config.in
> @@ -6,9 +6,6 @@ config BR2_PACKAGE_LIBNL
>  
>  	  http://people.suug.ch/~tgr/libnl/
>  
> -comment "libnl needs a toolchain w/ threads"
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> -
>  if BR2_PACKAGE_LIBNL
>  
>  config BR2_PACKAGE_LIBNL_TOOLS
> @@ -20,5 +17,7 @@ config BR2_PACKAGE_LIBNL_TOOLS
>  
>  comment "libnl tools need a toolchain w/ dynamic library"
>  	depends on BR2_PREFER_STATIC_LIB
> -
>  endif
> +
> +comment "libnl needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] libnl: Move the pthread dependency menu comment
  2014-07-05 21:08 [Buildroot] [PATCH] libnl: Move the pthread dependency menu comment Ezequiel Garcia
  2014-07-07  6:14 ` Arnout Vandecappelle
@ 2014-07-09 13:28 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2014-07-09 13:28 UTC (permalink / raw)
  To: buildroot

>>>>> "Ezequiel" == Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

 > In order for this comment to be properly displayer, it must be moved to be

s/displayer/displayed/

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-07-09 13:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-05 21:08 [Buildroot] [PATCH] libnl: Move the pthread dependency menu comment Ezequiel Garcia
2014-07-07  6:14 ` Arnout Vandecappelle
2014-07-09 13:28 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox