[Buildroot] [PATCH] lxc: disable lua and python

[Buildroot] [PATCH] lxc: disable lua and python

[Gustavo Zacarias]

Also conditionally disable bash if bash isn't built. Fixes:
http://autobuild.buildroot.net/results/8ea/8ea1d682706ba5fee27a64008bb7237d53120e9b/

Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
---
 package/lxc/lxc.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/lxc/lxc.mk b/package/lxc/lxc.mk
index b251b14..abb0a1b 100644
--- a/package/lxc/lxc.mk
+++ b/package/lxc/lxc.mk
@@ -11,6 +11,8 @@ LXC_LICENSE_FILES = COPYING
 LXC_DEPENDENCIES = libcap host-pkgconf
 # configure not shipped
 LXC_AUTORECONF = YES
-LXC_CONF_OPT = --disable-apparmor --with-distro=buildroot
+LXC_CONF_OPT = --disable-apparmor --with-distro=buildroot \
+	--disable-lua --disable-python \
+	$(if $(BR2_PACKAGE_BASH),,--disable-bash)
 
 $(eval $(autotools-package))
-- 
1.8.5.5

[Buildroot] [PATCH] lxc: disable lua and python

[Peter Korsgaard]

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > Also conditionally disable bash if bash isn't built. Fixes:
 > http://autobuild.buildroot.net/results/8ea/8ea1d682706ba5fee27a64008bb7237d53120e9b/

 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>

Committed, thanks.

Any reason to not enable this support if lua/python is enabled?

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] lxc: disable lua and python

[Gustavo Zacarias]

On 07/06/2014 04:52 PM, Peter Korsgaard wrote:

> Committed, thanks.
> 
> Any reason to not enable this support if lua/python is enabled?

Well, it breaks :)
Being an autotools package and sharing that with python infra is not
straightforward, it would require patching to not build/install the
python bits in the main build and doing so in separate steps with python
workarounds/love - it's probably better to just make it an option in the
python extensions menu as python-lxc.
And it didn't have that feature before, the bump being related to not
building on a gentoo distro/chroot, the autobuilders just didn't pick it
up because they're based on debian.
Regards.

[Buildroot] [PATCH] lxc: disable lua and python

[Peter Korsgaard]

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > On 07/06/2014 04:52 PM, Peter Korsgaard wrote:
 >> Committed, thanks.
 >> 
 >> Any reason to not enable this support if lua/python is enabled?

 > Well, it breaks :)
 > Being an autotools package and sharing that with python infra is not
 > straightforward, it would require patching to not build/install the
 > python bits in the main build and doing so in separate steps with python
 > workarounds/love - it's probably better to just make it an option in the
 > python extensions menu as python-lxc.
 > And it didn't have that feature before, the bump being related to not
 > building on a gentoo distro/chroot, the autobuilders just didn't pick it
 > up because they're based on debian.

Ok, thanks. It would be good to have that kind of info in the commit
message.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH] lxc: disable lua and python

[Gustavo Zacarias]

On 07/07/2014 02:47 PM, Peter Korsgaard wrote:
> Ok, thanks. It would be good to have that kind of info in the commit
> message.

There are other packages that do the same as well for the same reason,
what would be interesting to know is how to handle it in general
(examples: alsa-lib, avahi, libxml2, libxslt, cups, newt and a few more).
One notable split package for this is thrift but it's a special case in
that it bundles python-thrift but is really a separate package upstream.
Regards.