Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] PHP-FPM support
Date: Mon, 14 Jul 2014 19:28:30 -0300	[thread overview]
Message-ID: <53C4598E.90000@zacarias.com.ar> (raw)
In-Reply-To: <1405365326-2414-1-git-send-email-jordi.llonch@rochsystems.com>

On 07/14/2014 04:15 PM, Jordi Llonch wrote:

Hi, let's look at this.

> +config BR2_PACKAGE_PHP_SAPI_FPM
> +	bool "FPM"
> +	select BR2_PACKAGE_PHP_FPM
> +	help
> +	  PHP-FPM (FastCGI Process Manager)
> +

Pretty sure it depends on MMU just like CGI does.

> +config BR2_PACKAGE_PHP_SAPI_CLI_FPM
> +	bool "FPM and CLI"
> +	select BR2_PACKAGE_PHP_CLI
> +	select BR2_PACKAGE_PHP_FPM
> +	help
> +	  Command line and PHP-FPM (FastCGI Process Manager)
> +

Another option for FPM alone would be good too, not everyone needs CLI
and php binaries are somewhat big.

> +PHP_CONF_OPT += $(if $(BR2_PACKAGE_PHP_FPM),--enable-fpm --disable-cgi,--disable--fpm)

This should focus on just enable/disabling it's own option, cgi disables
itself via:

PHP_CONF_OPT += $(if $(BR2_PACKAGE_PHP_CGI),,--disable-cgi)

So no need to re-state that.
Regards.

  reply	other threads:[~2014-07-14 22:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 19:15 [Buildroot] [PATCH 1/1] PHP-FPM support Jordi Llonch
2014-07-14 22:28 ` Gustavo Zacarias [this message]
2014-07-14 22:58   ` Jordi Llonch
2014-07-15 12:43     ` Gustavo Zacarias
  -- strict thread matches above, loose matches on Subject: below --
2014-07-15 18:07 Jordi Llonch
2014-07-15 18:31 ` Gustavo Zacarias
2014-07-15 19:12 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C4598E.90000@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox