From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] PHP-FPM support
Date: Tue, 15 Jul 2014 09:43:27 -0300 [thread overview]
Message-ID: <53C521EF.8020008@zacarias.com.ar> (raw)
In-Reply-To: <FEA3AD43-7908-460F-B390-077CBD689B37@rochsystems.com>
On 07/14/2014 07:58 PM, Jordi Llonch wrote:
> Thanks Gustavo,
> This is my first contribution to the project and I appreciate your guidance.
>
> Will those changes suit better?
Yes, contributions are always welcome, i never added fpm because i don't
use it for my embedded cases.
There's a small typo...
> +PHP_CONF_OPT += $(if $(BR2_PACKAGE_PHP_FPM),--enable-fpm,--disable--fpm)
...an extra - in --disable-fpm :)
Otherwise looks good, care to resend with that tiny fix?
Thanks.
Regards.
next prev parent reply other threads:[~2014-07-15 12:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 19:15 [Buildroot] [PATCH 1/1] PHP-FPM support Jordi Llonch
2014-07-14 22:28 ` Gustavo Zacarias
2014-07-14 22:58 ` Jordi Llonch
2014-07-15 12:43 ` Gustavo Zacarias [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-07-15 18:07 Jordi Llonch
2014-07-15 18:31 ` Gustavo Zacarias
2014-07-15 19:12 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C521EF.8020008@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox