* [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32
@ 2014-09-08 12:17 Vicente Olivert Riera
2014-09-08 12:23 ` Baruch Siach
2014-09-08 12:51 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-09-08 12:17 UTC (permalink / raw)
To: buildroot
qt4 webkit fails to compile for MIPS64 n32. A bug has been reported
upstream, so we disable this package until upstream fixes the problem.
Upstream bug:
https://bugreports.qt-project.org/browse/QTBUG-39224
Fixes:
http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
---
package/qt/Config.in | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/package/qt/Config.in b/package/qt/Config.in
index da159b4..8c0fe54 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
config BR2_PACKAGE_QT_WEBKIT
bool "WebKit Module"
+ # qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
+ # https://bugreports.qt-project.org/browse/QTBUG-39224
+ depends on !BR2_MIPS_NABI32
depends on BR2_PACKAGE_QT_SHARED
depends on BR2_PACKAGE_QT_GUI_MODULE
depends on BR2_PACKAGE_QT_NETWORK
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32
2014-09-08 12:17 [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32 Vicente Olivert Riera
@ 2014-09-08 12:23 ` Baruch Siach
2014-09-08 12:29 ` Vicente Olivert Riera
2014-09-08 12:51 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2014-09-08 12:23 UTC (permalink / raw)
To: buildroot
Hi Vicente,
On Mon, Sep 08, 2014 at 01:17:15PM +0100, Vicente Olivert Riera wrote:
> qt4 webkit fails to compile for MIPS64 n32. A bug has been reported
> upstream, so we disable this package until upstream fixes the problem.
>
> Upstream bug:
> https://bugreports.qt-project.org/browse/QTBUG-39224
>
> Fixes:
> http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/
>
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
> ---
> package/qt/Config.in | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index da159b4..8c0fe54 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>
> config BR2_PACKAGE_QT_WEBKIT
> bool "WebKit Module"
> + # qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
> + # https://bugreports.qt-project.org/browse/QTBUG-39224
> + depends on !BR2_MIPS_NABI32
Please update the dependencies of the comment below accordingly.
baruch
> depends on BR2_PACKAGE_QT_SHARED
> depends on BR2_PACKAGE_QT_GUI_MODULE
> depends on BR2_PACKAGE_QT_NETWORK
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32
2014-09-08 12:23 ` Baruch Siach
@ 2014-09-08 12:29 ` Vicente Olivert Riera
2014-09-08 12:38 ` Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-09-08 12:29 UTC (permalink / raw)
To: buildroot
On 09/08/2014 01:23 PM, Baruch Siach wrote:
> Hi Vicente,
>
> On Mon, Sep 08, 2014 at 01:17:15PM +0100, Vicente Olivert Riera wrote:
>> qt4 webkit fails to compile for MIPS64 n32. A bug has been reported
>> upstream, so we disable this package until upstream fixes the problem.
>>
>> Upstream bug:
>> https://bugreports.qt-project.org/browse/QTBUG-39224
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
>> ---
>> package/qt/Config.in | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/package/qt/Config.in b/package/qt/Config.in
>> index da159b4..8c0fe54 100644
>> --- a/package/qt/Config.in
>> +++ b/package/qt/Config.in
>> @@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>>
>> config BR2_PACKAGE_QT_WEBKIT
>> bool "WebKit Module"
>> + # qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
>> + # https://bugreports.qt-project.org/browse/QTBUG-39224
>> + depends on !BR2_MIPS_NABI32
>
> Please update the dependencies of the comment below accordingly.
>
> baruch
>
>> depends on BR2_PACKAGE_QT_SHARED
>> depends on BR2_PACKAGE_QT_GUI_MODULE
>> depends on BR2_PACKAGE_QT_NETWORK
>
Are you sure this is necessary? I thought that was needed only for
toolchain dependencies.
For instance, there are packages which depend on !BR2_MIPS_NABI32 and
they don't have a comment for that:
ecryptfs-utils/Config.in
tinymembench/Config.in
--
Vincent
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32
2014-09-08 12:29 ` Vicente Olivert Riera
@ 2014-09-08 12:38 ` Baruch Siach
0 siblings, 0 replies; 5+ messages in thread
From: Baruch Siach @ 2014-09-08 12:38 UTC (permalink / raw)
To: buildroot
Hi Vicente,
On Mon, Sep 08, 2014 at 01:29:14PM +0100, Vicente Olivert Riera wrote:
> On 09/08/2014 01:23 PM, Baruch Siach wrote:
> >On Mon, Sep 08, 2014 at 01:17:15PM +0100, Vicente Olivert Riera wrote:
> >>qt4 webkit fails to compile for MIPS64 n32. A bug has been reported
> >>upstream, so we disable this package until upstream fixes the problem.
> >>
> >>Upstream bug:
> >> https://bugreports.qt-project.org/browse/QTBUG-39224
> >>
> >>Fixes:
> >> http://autobuild.buildroot.net/results/2ab/2ab5ab179dab9e1a47092b066f97d48c75ab935b/
> >>
> >>Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> >>Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
> >>---
> >> package/qt/Config.in | 3 +++
> >> 1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >>diff --git a/package/qt/Config.in b/package/qt/Config.in
> >>index da159b4..8c0fe54 100644
> >>--- a/package/qt/Config.in
> >>+++ b/package/qt/Config.in
> >>@@ -371,6 +371,9 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
> >>
> >> config BR2_PACKAGE_QT_WEBKIT
> >> bool "WebKit Module"
> >>+ # qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
> >>+ # https://bugreports.qt-project.org/browse/QTBUG-39224
> >>+ depends on !BR2_MIPS_NABI32
> >
> >Please update the dependencies of the comment below accordingly.
> >
> >baruch
> >
> >> depends on BR2_PACKAGE_QT_SHARED
> >> depends on BR2_PACKAGE_QT_GUI_MODULE
> >> depends on BR2_PACKAGE_QT_NETWORK
>
> Are you sure this is necessary? I thought that was needed only for toolchain
> dependencies.
>
> For instance, there are packages which depend on !BR2_MIPS_NABI32 and they
> don't have a comment for that:
>
> ecryptfs-utils/Config.in
> tinymembench/Config.in
You don't need the comment text to refer to architecture dependencies, since
the user can't do much about them. But you do need to not show the comment
when not applicable for the same reason. Note that the comment already depends
on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT for this reason.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32
2014-09-08 12:17 [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32 Vicente Olivert Riera
2014-09-08 12:23 ` Baruch Siach
@ 2014-09-08 12:51 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-09-08 12:51 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Mon, 8 Sep 2014 13:17:15 +0100, Vicente Olivert Riera wrote:
> config BR2_PACKAGE_QT_WEBKIT
> bool "WebKit Module"
> + # qt-4.8.6 webkit: fails to compile on MIPS64 n32 platforms
> + # https://bugreports.qt-project.org/browse/QTBUG-39224
> + depends on !BR2_MIPS_NABI32
> depends on BR2_PACKAGE_QT_SHARED
> depends on BR2_PACKAGE_QT_GUI_MODULE
> depends on BR2_PACKAGE_QT_NETWORK
No. As explained in a separate thread, you should use
BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-08 12:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-08 12:17 [Buildroot] [PATCH] qt4 webkit: Disable for MIPS64 n32 Vicente Olivert Riera
2014-09-08 12:23 ` Baruch Siach
2014-09-08 12:29 ` Vicente Olivert Riera
2014-09-08 12:38 ` Baruch Siach
2014-09-08 12:51 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox