* [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses
@ 2014-09-23 9:33 Vicente Olivert Riera
2014-09-23 9:38 ` Thomas Petazzoni
2014-09-25 9:01 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-09-23 9:33 UTC (permalink / raw)
To: buildroot
Some packages use -lcurses when they are linking, so they try to link to
a library called libcurses. The library provided by our ncurses package
is called libncurses, so those packages fail to link with a message like
this one:
/bin/ld: cannot find -lcurses
Installing a libcurses symlink to libncurses fixes the problem.
Fixes:
http://autobuild.buildroot.net/results/466/466995f9534447a4f54327a14c44ef9e16dd1123/
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
---
package/ncurses/ncurses.mk | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/package/ncurses/ncurses.mk b/package/ncurses/ncurses.mk
index 81a3998..3f57407 100644
--- a/package/ncurses/ncurses.mk
+++ b/package/ncurses/ncurses.mk
@@ -46,6 +46,8 @@ define NCURSES_LINK_LIBS
ln -sf $${lib}$(NCURSES_LIB_SUFFIX).a \
$(1)/usr/lib/$${lib}.a; \
done
+ ln -sf libncurses$(NCURSES_LIB_SUFFIX).a \
+ $(1)/usr/lib/libcurses.a
endef
else
define NCURSES_LINK_LIBS
@@ -55,6 +57,10 @@ define NCURSES_LINK_LIBS
ln -sf $${lib}$(NCURSES_LIB_SUFFIX).so \
$(1)/usr/lib/$${lib}.so; \
done
+ ln -sf libncurses$(NCURSES_LIB_SUFFIX).a \
+ $(1)/usr/lib/libcurses.a
+ ln -sf libncurses$(NCURSES_LIB_SUFFIX).so \
+ $(1)/usr/lib/libcurses.so
endef
endif
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses
2014-09-23 9:33 [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses Vicente Olivert Riera
@ 2014-09-23 9:38 ` Thomas Petazzoni
2014-09-23 9:42 ` Vicente Olivert Riera
2014-09-25 9:01 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2014-09-23 9:38 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Tue, 23 Sep 2014 10:33:11 +0100, Vicente Olivert Riera wrote:
> Some packages use -lcurses when they are linking, so they try to link to
> a library called libcurses. The library provided by our ncurses package
> is called libncurses, so those packages fail to link with a message like
> this one:
Can you define "some" in "Some packages" ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses
2014-09-23 9:38 ` Thomas Petazzoni
@ 2014-09-23 9:42 ` Vicente Olivert Riera
2014-09-23 9:53 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Vicente Olivert Riera @ 2014-09-23 9:42 UTC (permalink / raw)
To: buildroot
On 09/23/2014 10:38 AM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Tue, 23 Sep 2014 10:33:11 +0100, Vicente Olivert Riera wrote:
>> Some packages use -lcurses when they are linking, so they try to link to
>> a library called libcurses. The library provided by our ncurses package
>> is called libncurses, so those packages fail to link with a message like
>> this one:
>
> Can you define "some" in "Some packages" ?
>
> Thanks!
>
> Thomas
Hi Thomas,
there is an autobuild report at the bottom of the commit message where
you can see a package which is failing due to that problem.
--
Vincent
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses
2014-09-23 9:42 ` Vicente Olivert Riera
@ 2014-09-23 9:53 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2014-09-23 9:53 UTC (permalink / raw)
To: buildroot
Dear Vicente Olivert Riera,
On Tue, 23 Sep 2014 10:42:23 +0100, Vicente Olivert Riera wrote:
> there is an autobuild report at the bottom of the commit message where
> you can see a package which is failing due to that problem.
Indeed, I missed it. Sorry for the silly comment. Patch looks good to
me.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses
2014-09-23 9:33 [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses Vicente Olivert Riera
2014-09-23 9:38 ` Thomas Petazzoni
@ 2014-09-25 9:01 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2014-09-25 9:01 UTC (permalink / raw)
To: buildroot
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> Some packages use -lcurses when they are linking, so they try to link to
> a library called libcurses. The library provided by our ncurses package
> is called libncurses, so those packages fail to link with a message like
> this one:
> /bin/ld: cannot find -lcurses
> Installing a libcurses symlink to libncurses fixes the problem.
> Fixes:
> http://autobuild.buildroot.net/results/466/466995f9534447a4f54327a14c44ef9e16dd1123/
> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-25 9:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-23 9:33 [Buildroot] [PATCH] ncurses: Add libcurses symlink to libncurses Vicente Olivert Riera
2014-09-23 9:38 ` Thomas Petazzoni
2014-09-23 9:42 ` Vicente Olivert Riera
2014-09-23 9:53 ` Thomas Petazzoni
2014-09-25 9:01 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox